Skip to content

[CHORE] Imporve fast sync config params #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 29, 2020

Conversation

KonradStaniec
Copy link
Contributor

Description

With those params and with #672 , fast sync appears to be fast enough to sync up to the top of the mainnet before peers prune their stats

@ntallar
Copy link

ntallar commented Sep 21, 2020

Were any of this configurations taken from geth or were they all obtained from trial and error with different values?

@KonradStaniec
Copy link
Contributor Author

so:

  1. Throttling main purpose wast to not be blacklisted by remote peers, but tbh i did not see such a behaviour over several runs
  2. With restartSync idle set to 15s fastsync sometimes just sit idly so it does make little sense to have it such large
  3. FastSyncTargetOffset is set in manner similar to geth i.e geth actually choses top block as target but declares that target is stale when its 128 blocks behind the top, as for now we can't set target block as top network block, but we can minimize the offset to reduce the possibility of remote peer pruning their stale nodes.

Copy link

@ntallar ntallar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

 .\\            //.
. \ \          / /.
.\  ,\     /` /,.-
 -.   \  /'/ /  .
 ` -   `-'  \  -
   '.       /.\`
      -    .-
      :`//.'
      .`.'
      .' BP 

Copy link
Contributor

@mmrozek mmrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing I would like to fix is to change a log. With retry interval = 0,5 s there is a lot of garbage logged

@KonradStaniec KonradStaniec merged commit 39f3fb1 into develop Sep 29, 2020
@KonradStaniec KonradStaniec deleted the tweak/tweak-fast-sync-config-params branch September 29, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants