Skip to content

[ETCM-126] RPC cleanup #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 29, 2020
Merged

[ETCM-126] RPC cleanup #705

merged 4 commits into from
Sep 29, 2020

Conversation

lemastero
Copy link
Contributor

@lemastero lemastero commented Sep 28, 2020 •
edited by mirkoAlic
Loading

Description

Remove redundant daedalus_deleteWallet and daedalus_changePassphrase RPC methods.

@lemastero lemastero requested review from kapke and mmrozek September 29, 2020 09:47
kapke
kapke approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@kapke kapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lemastero lemastero merged commit d818fd9 into develop Sep 29, 2020
@lemastero lemastero deleted the feature/ETCM-126-rpc-cleanup branch September 29, 2020 11:15
@lemastero lemastero added the BREAKS API Affects services that interacts with APIs label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapke kapke kapke approved these changes

@mmrozek mmrozek Awaiting requested review from mmrozek

Assignees
No one assigned
Labels
BREAKS API Affects services that interacts with APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemastero @kapke