ETCM-345: Message order can be reversed in test.

Author: aakoshh

scalanet/test/src/io/iohk/scalanet/peergroup/udp/StaticUDPPeerGroupSpec.scala

@@ -133,7 +133,7 @@ class StaticUDPPeerGroupSpec extends UDPPeerGroupSpec("StaticUDPPeerGroup") with
             received <- receivers.traverse(_.join)
           } yield {
             received(0) shouldBe List("Two to One")
-            received(1) shouldBe List("Three to One A", "Three to One B")
+            received(1) should contain theSameElementsAs List("Three to One A", "Three to One B")
             received(2) shouldBe received(1)
           }
       }

scalanet/test/src/io/iohk/scalanet/peergroup/udp/UDPPeerGroupSpec.scala

@@ -30,6 +30,8 @@ abstract class UDPPeerGroupSpec[PG <: UDPPeerGroupSpec.TestGroup[_]](name: Strin
   import UDPPeerGroupSpec.TestGroup
   import scala.language.reflectiveCalls
 
+  val testTimeout = 15.seconds
+
   implicit val scheduler = Scheduler.fixedPool("test", 16)
 
   implicit val pc: PatienceConfig = PatienceConfig(5 seconds)
@@ -57,7 +59,7 @@ abstract class UDPPeerGroupSpec[PG <: UDPPeerGroupSpec.TestGroup[_]](name: Strin
         case (pg1, pg2) =>
           testCode(pg1, pg2).void
       }
-      .runSyncUnsafe(15.seconds)
+      .runSyncUnsafe(testTimeout)
   }
 
   def withARandomUDPPeerGroup[M](
@@ -67,7 +69,7 @@ abstract class UDPPeerGroupSpec[PG <: UDPPeerGroupSpec.TestGroup[_]](name: Strin
       .use { pg =>
         testCode(pg).void
       }
-      .runSyncUnsafe(15.seconds)
+      .runSyncUnsafe(testTimeout)
   }
 
   it should "report an error for sending a message greater than the MTU" in
@@ -91,7 +93,7 @@ abstract class UDPPeerGroupSpec[PG <: UDPPeerGroupSpec.TestGroup[_]](name: Strin
     }
 
   it should "send and receive a message" in withTwoRandomUDPPeerGroups[String] { (alice, bob) =>
-    StandardTestPack.messagingTest(alice, bob).recover {
+    StandardTestPack.messagingTest(alice, bob).timeout(testTimeout - 1.second).recover {
       case _: TimeoutException if sys.env.get("CI").contains("true") =>
         cancel("ETCM-345: Intermittent timeout on Circle CI.")
     }