Skip to content

Commit 6d2edcb

Browse files
committed
mirage/crates: Fix error handling for GET /api/v1/crates/:id/versions request handler
1 parent 5b1e23c commit 6d2edcb

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

mirage/route-handlers/crates.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,11 @@ export function register(server) {
5757
});
5858

5959
server.get('/api/v1/crates/:crate_id/versions', (schema, request) => {
60-
let crate = request.params.crate_id;
61-
return schema.versions.where({ crate }).sort((a, b) => compareIsoDates(b.created_at, a.created_at));
60+
let crateId = request.params.crate_id;
61+
let crate = schema.crates.find(crateId);
62+
if (!crate) return notFound();
63+
64+
return schema.versions.where({ crate: crateId }).sort((a, b) => compareIsoDates(b.created_at, a.created_at));
6265
});
6366

6467
server.get('/api/v1/crates/:crate_id/:version_num/authors', (schema, request) => {

0 commit comments

Comments
 (0)