Retrun valid status on createAllocation64k fail

Change-Id: Iaaed107c995a79125236196b6a956696dfe20875

Author: BartoszDunajski

runtime/os_interface/windows/wddm/wddm.cpp

@@ -443,7 +443,6 @@ bool Wddm::createAllocation64k(WddmAllocation *alloc) {
     NTSTATUS status = STATUS_SUCCESS;
     D3DDDI_ALLOCATIONINFO AllocationInfo = {0};
     D3DKMT_CREATEALLOCATION CreateAllocation = {0};
-    bool success = false;
 
     AllocationInfo.pSystemMem = 0;
     AllocationInfo.pPrivateDriverData = alloc->gmm->gmmResourceInfo->peekHandle();
@@ -457,20 +456,16 @@ bool Wddm::createAllocation64k(WddmAllocation *alloc) {
     CreateAllocation.pAllocationInfo = &AllocationInfo;
     CreateAllocation.hDevice = device;
 
-    while (!success) {
-        status = gdi->createAllocation(&CreateAllocation);
-
-        if (status != STATUS_SUCCESS) {
-            DEBUG_BREAK_IF(true);
-            break;
-        }
+    status = gdi->createAllocation(&CreateAllocation);
 
-        alloc->handle = AllocationInfo.hAllocation;
+    if (status != STATUS_SUCCESS) {
+        DEBUG_BREAK_IF(true);
+        return false;
+    }
 
-        kmDafListener->notifyWriteTarget(featureTable->ftrKmdDaf, adapter, device, alloc->handle, gdi->escape);
+    alloc->handle = AllocationInfo.hAllocation;
 
-        success = true;
-    }
+    kmDafListener->notifyWriteTarget(featureTable->ftrKmdDaf, adapter, device, alloc->handle, gdi->escape);
     return true;
 }
 

unit_tests/os_interface/windows/wddm20_tests.cpp

@@ -789,6 +789,22 @@ TEST_F(Wddm20Tests, givenOpenSharedHandleWhenZeroAllocationsThenReturnNull) {
     EXPECT_EQ(false, ret);
 }
 
+TEST_F(Wddm20Tests, whenCreateAllocation64kFailsThenReturnFalse) {
+    struct FailingCreateAllocation {
+        static NTSTATUS APIENTRY mockCreateAllocation(D3DKMT_CREATEALLOCATION *param) {
+            return STATUS_GRAPHICS_NO_VIDEO_MEMORY;
+        };
+    };
+    gdi->createAllocation = FailingCreateAllocation::mockCreateAllocation;
+
+    void *fakePtr = reinterpret_cast<void *>(0x123);
+    auto gmm = std::make_unique<Gmm>(fakePtr, 100, false);
+    WddmAllocation allocation(fakePtr, 100, fakePtr, 200, nullptr, MemoryPool::MemoryNull);
+    allocation.gmm = gmm.get();
+
+    EXPECT_FALSE(wddm->createAllocation64k(&allocation));
+}
+
 TEST_F(Wddm20Tests, givenReadOnlyMemoryWhenCreateAllocationFailsWithNoVideoMemoryThenCorrectStatusIsReturned) {
     class MockCreateAllocation {
       public: