Revert "Enable Symbol Table Generation by Default for L0 modules"

This reverts commit c2e3d24.

Signed-off-by: Compute-Runtime-Validation <[email protected]>

Author: Compute-Runtime-Validation

level_zero/core/source/module/module_imp.cpp

@@ -49,7 +49,6 @@ NEO::ConstStringRef optLevel = "-ze-opt-level";
 NEO::ConstStringRef greaterThan4GbRequired = "-ze-opt-greater-than-4GB-buffer-required";
 NEO::ConstStringRef hasBufferOffsetArg = "-ze-intel-has-buffer-offset-arg";
 NEO::ConstStringRef debugKernelEnable = "-ze-kernel-debug-enable";
-NEO::ConstStringRef enableLibraryCompile = "-library-compilation";
 } // namespace BuildOptions
 
 ModuleTranslationUnit::ModuleTranslationUnit(L0::Device *device)
@@ -666,16 +665,12 @@ void ModuleImp::createBuildOptions(const char *pBuildFlags, std::string &apiOpti
         moveBuildOption(apiOptions, apiOptions, NEO::CompilerOptions::optLevel, BuildOptions::optLevel);
         moveBuildOption(internalBuildOptions, apiOptions, NEO::CompilerOptions::greaterThan4gbBuffersRequired, BuildOptions::greaterThan4GbRequired);
         moveBuildOption(internalBuildOptions, apiOptions, NEO::CompilerOptions::allowZebin, NEO::CompilerOptions::allowZebin);
-        this->libraryExportEnabled = moveBuildOption(apiOptions, apiOptions, BuildOptions::enableLibraryCompile, BuildOptions::enableLibraryCompile);
 
         createBuildExtraOptions(apiOptions, internalBuildOptions);
     }
     if (NEO::ApiSpecificConfig::getBindlessConfiguration()) {
         NEO::CompilerOptions::concatenateAppend(internalBuildOptions, NEO::CompilerOptions::bindlessMode.str());
     }
-    if (!this->libraryExportEnabled && NEO::DebugManager.flags.EnableProgramSymbolTableGeneration.get()) {
-        NEO::CompilerOptions::concatenateAppend(apiOptions, BuildOptions::enableLibraryCompile.str());
-    }
 }
 
 void ModuleImp::updateBuildLog(NEO::Device *neoDevice) {

level_zero/core/source/module/module_imp.h

@@ -30,7 +30,6 @@ extern NEO::ConstStringRef optLevel;
 extern NEO::ConstStringRef greaterThan4GbRequired;
 extern NEO::ConstStringRef hasBufferOffsetArg;
 extern NEO::ConstStringRef debugKernelEnable;
-extern NEO::ConstStringRef enableLibraryCompile;
 } // namespace BuildOptions
 
 struct ModuleTranslationUnit {
@@ -159,7 +158,6 @@ struct ModuleImp : public Module {
     bool debugEnabled = false;
     bool isFullyLinked = false;
     bool allocatePrivateMemoryPerDispatch = true;
-    bool libraryExportEnabled = false;
     ModuleType type;
     NEO::Linker::UnresolvedExternals unresolvedExternalsInfo{};
     std::set<NEO::GraphicsAllocation *> importedSymbolAllocations{};

level_zero/core/test/unit_tests/sources/module/test_module.cpp

@@ -2421,62 +2421,6 @@ TEST(BuildOptions, givenSrcOptLevelWithoutLevelIntegerInSrcNamesWhenMovingBuildO
     EXPECT_FALSE(result);
 }
 
-TEST_F(ModuleTest, givenBuildOptionsWhenEnableProgramSymbolTableGenerationIsEnabledThenEnableLibraryCompileIsSet) {
-    DebugManagerStateRestore restorer;
-    DebugManager.flags.EnableProgramSymbolTableGeneration.set(1);
-    auto module = std::make_unique<ModuleImp>(device, nullptr, ModuleType::User);
-    ASSERT_NE(nullptr, module);
-
-    std::string buildOptions;
-    std::string internalBuildOptions;
-
-    module->createBuildOptions("", buildOptions, internalBuildOptions);
-
-    EXPECT_TRUE(NEO::CompilerOptions::contains(buildOptions, BuildOptions::enableLibraryCompile));
-}
-
-TEST_F(ModuleTest, givenBuildOptionsWhenEnableProgramSymbolTableGenerationIsDisabledThenEnableLibraryCompileIsNotSet) {
-    DebugManagerStateRestore restorer;
-    DebugManager.flags.EnableProgramSymbolTableGeneration.set(0);
-    auto module = std::make_unique<ModuleImp>(device, nullptr, ModuleType::User);
-    ASSERT_NE(nullptr, module);
-
-    std::string buildOptions;
-    std::string internalBuildOptions;
-
-    module->createBuildOptions("", buildOptions, internalBuildOptions);
-
-    EXPECT_FALSE(NEO::CompilerOptions::contains(buildOptions, BuildOptions::enableLibraryCompile));
-}
-
-TEST_F(ModuleTest, givenBuildOptionsWithEnableLibraryCompileWhenEnableProgramSymbolTableGenerationIsDisabledThenEnableLibraryCompileIsSet) {
-    DebugManagerStateRestore restorer;
-    DebugManager.flags.EnableProgramSymbolTableGeneration.set(0);
-    auto module = std::make_unique<ModuleImp>(device, nullptr, ModuleType::User);
-    ASSERT_NE(nullptr, module);
-
-    std::string buildOptions;
-    std::string internalBuildOptions;
-
-    module->createBuildOptions(BuildOptions::enableLibraryCompile.str().c_str(), buildOptions, internalBuildOptions);
-
-    EXPECT_TRUE(NEO::CompilerOptions::contains(buildOptions, BuildOptions::enableLibraryCompile));
-}
-
-TEST_F(ModuleTest, givenBuildOptionsWithEnableLibraryCompileWhenEnableProgramSymbolTableGenerationIsEnabledThenEnableLibraryCompileIsSet) {
-    DebugManagerStateRestore restorer;
-    DebugManager.flags.EnableProgramSymbolTableGeneration.set(1);
-    auto module = std::make_unique<ModuleImp>(device, nullptr, ModuleType::User);
-    ASSERT_NE(nullptr, module);
-
-    std::string buildOptions;
-    std::string internalBuildOptions;
-
-    module->createBuildOptions(BuildOptions::enableLibraryCompile.str().c_str(), buildOptions, internalBuildOptions);
-
-    EXPECT_TRUE(NEO::CompilerOptions::contains(buildOptions, BuildOptions::enableLibraryCompile));
-}
-
 TEST_F(ModuleTest, givenInternalOptionsWhenBindlessEnabledThenBindlesOptionsPassed) {
     DebugManagerStateRestore restorer;
     DebugManager.flags.UseBindlessMode.set(1);

shared/source/debug_settings/debug_variables_base.inl

@@ -334,7 +334,6 @@ DECLARE_DEBUG_VARIABLE(bool, ForceSamplerLowFilteringPrecision, false, "Force Lo
 DECLARE_DEBUG_VARIABLE(bool, EngineInstancedSubDevices, false, "Create subdevices assigned to specific engine")
 DECLARE_DEBUG_VARIABLE(bool, AllowSingleTileEngineInstancedSubDevices, false, "Create subdevices assigned to specific engine on single tile config")
 DECLARE_DEBUG_VARIABLE(bool, EnablePrivateBO, false, "Enable PRELIM_I915_GEM_CREATE_EXT_VM_PRIVATE extension creating VM_PRIVATE BOs")
-DECLARE_DEBUG_VARIABLE(bool, EnableProgramSymbolTableGeneration, true, "Enforce IGC to always generate the Program Symbol Table for Exported Functions for all Modules used by Level Zero.")
 DECLARE_DEBUG_VARIABLE(int32_t, ReturnSubDevicesAsApiDevices, -1, "Expose each subdevice as a separate device during clGetDeviceIDs or zeDeviceGet API call")
 DECLARE_DEBUG_VARIABLE(int32_t, ForceRunAloneContext, -1, "Control creation of run-alone HW context, -1:default, 0:disable, 1:enable")
 DECLARE_DEBUG_VARIABLE(int32_t, AddClGlSharing, -1, "Add cl-gl extension")

shared/test/common/test_files/igdrcl.config

@@ -349,7 +349,6 @@ AllowPatchingVfeStateInCommandLists = 0
 PrintMemoryRegionSizes = 0
 OverrideDrmRegion = -1
 AllowSingleTileEngineInstancedSubDevices = 0
-EnableProgramSymbolTableGeneration = 1
 BinaryCacheTrace = false
 OverrideL1CacheControlInSurfaceState = -1
 OverrideL1CacheControlInSurfaceStateForScratchSpace = -1