Skip to content

Commit bbffbd1

Browse files
refactor: remove not needed code
Signed-off-by: Mateusz Jablonski <[email protected]>
1 parent 8687a88 commit bbffbd1

File tree

6 files changed

+4
-16
lines changed

6 files changed

+4
-16
lines changed

level_zero/core/source/cmdlist/cmdlist_hw.inl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -293,8 +293,7 @@ ze_result_t CommandListCoreFamily<gfxCoreFamily>::initialize(Device *device, NEO
293293
getCsr(false) &&
294294
getCsr(false)->isAnyDirectSubmissionEnabled() &&
295295
!neoDevice->getExecutionEnvironment()->areMetricsEnabled() &&
296-
neoDevice->getMemoryManager()->isLocalMemorySupported(neoDevice->getRootDeviceIndex()) &&
297-
productHelper.isFlatRingBufferSupported();
296+
neoDevice->getMemoryManager()->isLocalMemorySupported(neoDevice->getRootDeviceIndex());
298297

299298
if (NEO::debugManager.flags.DirectSubmissionFlatRingBuffer.get() != -1) {
300299
createSecondaryCmdBufferInHostMem &= !!NEO::debugManager.flags.DirectSubmissionFlatRingBuffer.get();

level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_5.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -881,7 +881,7 @@ HWTEST_F(CommandListCreate, givenImmediateCopyOnlySingleTileDirectSubmissionComm
881881
std::unique_ptr<L0::CommandList> commandList(CommandList::createImmediate(productFamily, device, &desc, false, NEO::EngineGroupType::copy, returnValue));
882882
ASSERT_NE(nullptr, commandList);
883883

884-
auto flatRingSupported = device->getHwInfo().featureTable.flags.ftrLocalMemory && device->getProductHelper().isFlatRingBufferSupported();
884+
auto flatRingSupported = device->getHwInfo().featureTable.flags.ftrLocalMemory;
885885
EXPECT_EQ(reinterpret_cast<CmdContainerMock *>(&commandList->getCmdContainer())->secondaryCommandStreamForImmediateCmdList.get() != nullptr, flatRingSupported);
886886
if (flatRingSupported) {
887887
EXPECT_TRUE(MemoryPoolHelper::isSystemMemoryPool(reinterpret_cast<CmdContainerMock *>(&commandList->getCmdContainer())->secondaryCommandStreamForImmediateCmdList->getGraphicsAllocation()->getMemoryPool()));
@@ -906,7 +906,7 @@ HWTEST_F(CommandListCreate, givenMetricsImmediateCopyOnlySingleTileDirectSubmiss
906906
}
907907

908908
HWTEST2_F(CommandListCreate, givenSecondaryCommandStreamForImmediateCmdListWhenCheckAvailableSpaceThenSwapCommandStreams, MatchAny) {
909-
if (!device->getHwInfo().featureTable.flags.ftrLocalMemory || !device->getProductHelper().isFlatRingBufferSupported()) {
909+
if (!device->getHwInfo().featureTable.flags.ftrLocalMemory) {
910910
GTEST_SKIP();
911911
}
912912
DebugManagerStateRestore restorer;
@@ -939,7 +939,7 @@ HWTEST2_F(CommandListCreate, givenSecondaryCommandStreamForImmediateCmdListWhenC
939939
}
940940

941941
HWTEST2_F(CommandListCreate, givenNoSecondaryCommandStreamForImmediateCmdListWhenCheckAvailableSpaceThenNotSwapCommandStreams, MatchAny) {
942-
if (!device->getHwInfo().featureTable.flags.ftrLocalMemory || !device->getProductHelper().isFlatRingBufferSupported()) {
942+
if (!device->getHwInfo().featureTable.flags.ftrLocalMemory) {
943943
GTEST_SKIP();
944944
}
945945
DebugManagerStateRestore restorer;

shared/source/os_interface/product_helper.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ class ProductHelper {
126126
virtual bool is3DPipelineSelectWARequired() const = 0;
127127
virtual bool isStorageInfoAdjustmentRequired() const = 0;
128128
virtual bool isBlitterForImagesSupported() const = 0;
129-
virtual bool isFlatRingBufferSupported() const = 0;
130129
virtual bool isPageFaultSupported() const = 0;
131130
virtual bool isKmdMigrationSupported() const = 0;
132131
virtual bool isDisableScratchPagesSupported() const = 0;

shared/source/os_interface/product_helper.inl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -552,11 +552,6 @@ bool ProductHelperHw<gfxProduct>::isThreadArbitrationPolicyReportedWithScm() con
552552
return ProductHelperHw<gfxProduct>::getScmPropertyThreadArbitrationPolicySupport();
553553
}
554554

555-
template <PRODUCT_FAMILY gfxProduct>
556-
bool ProductHelperHw<gfxProduct>::isFlatRingBufferSupported() const {
557-
return true;
558-
}
559-
560555
template <PRODUCT_FAMILY gfxProduct>
561556
bool ProductHelperHw<gfxProduct>::isCooperativeEngineSupported(const HardwareInfo &hwInfo) const {
562557
return false;

shared/source/os_interface/product_helper_hw.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ class ProductHelperHw : public ProductHelper {
9797
bool isGrfNumReportedWithScm() const override;
9898
bool isThreadArbitrationPolicyReportedWithScm() const override;
9999
bool isCopyBufferRectSplitSupported() const override;
100-
bool isFlatRingBufferSupported() const override;
101100
bool isCooperativeEngineSupported(const HardwareInfo &hwInfo) const override;
102101
bool isTimestampWaitSupportedForEvents() const override;
103102
bool isTilePlacementResourceWaRequired(const HardwareInfo &hwInfo) const override;

shared/test/unit_test/os_interface/product_helper_tests.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -447,10 +447,6 @@ HWTEST2_F(ProductHelperTest, givenProductHelperWhenCallUseGemCreateExtInAllocate
447447
EXPECT_FALSE(productHelper->useGemCreateExtInAllocateMemoryByKMD());
448448
}
449449

450-
HWTEST2_F(ProductHelperTest, givenProductHelperWhenCallIsFlatRingBufferSupportedThenTrueIsReturned, IsAtMostXeHpgCore) {
451-
EXPECT_TRUE(productHelper->isFlatRingBufferSupported());
452-
}
453-
454450
HWTEST_F(ProductHelperTest, givenProductHelperWhenAskedIfBlitterForImagesIsSupportedThenFalseIsReturned) {
455451

456452
EXPECT_FALSE(productHelper->isBlitterForImagesSupported());

0 commit comments

Comments
 (0)