Skip to content

Commit c02dc82

Browse files
Revert "fix: do not enable compression on xe_lpg"
This reverts commit a6abda8. Signed-off-by: Compute-Runtime-Validation <[email protected]>
1 parent 258fcc8 commit c02dc82

File tree

5 files changed

+6
-26
lines changed

5 files changed

+6
-26
lines changed

shared/source/os_interface/product_helper_xe_hpg_and_xe_hpc.inl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,12 @@ uint64_t ProductHelperHw<gfxProduct>::getCrossDeviceSharedMemCapabilities() cons
3939
return capabilities;
4040
}
4141

42+
template <PRODUCT_FAMILY gfxProduct>
43+
void ProductHelperHw<gfxProduct>::enableCompression(HardwareInfo *hwInfo) const {
44+
hwInfo->capabilityTable.ftrRenderCompressedImages = hwInfo->featureTable.flags.ftrE2ECompression;
45+
hwInfo->capabilityTable.ftrRenderCompressedBuffers = hwInfo->featureTable.flags.ftrE2ECompression;
46+
}
47+
4248
template <PRODUCT_FAMILY gfxProduct>
4349
uint32_t ProductHelperHw<gfxProduct>::getMaxThreadsForWorkgroupInDSSOrSS(const HardwareInfo &hwInfo, uint32_t maxNumEUsPerSubSlice, uint32_t maxNumEUsPerDualSubSlice) const {
4450
if (isMaxThreadsForWorkgroupWARequired(hwInfo)) {

shared/source/xe_hpc_core/pvc/os_agnostic_product_helper_pvc.inl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -244,10 +244,4 @@ bool ProductHelperHw<gfxProduct>::isSharingWith3dOrMediaAllowed() const {
244244
return false;
245245
}
246246

247-
template <PRODUCT_FAMILY gfxProduct>
248-
void ProductHelperHw<gfxProduct>::enableCompression(HardwareInfo *hwInfo) const {
249-
hwInfo->capabilityTable.ftrRenderCompressedImages = hwInfo->featureTable.flags.ftrE2ECompression;
250-
hwInfo->capabilityTable.ftrRenderCompressedBuffers = hwInfo->featureTable.flags.ftrE2ECompression;
251-
}
252-
253247
} // namespace NEO

shared/source/xe_hpg_core/dg2/os_agnostic_product_helper_dg2.inl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -271,10 +271,4 @@ bool ProductHelperHw<gfxProduct>::isHostUsmAllocationReuseSupported() const {
271271
return true;
272272
}
273273

274-
template <PRODUCT_FAMILY gfxProduct>
275-
void ProductHelperHw<gfxProduct>::enableCompression(HardwareInfo *hwInfo) const {
276-
hwInfo->capabilityTable.ftrRenderCompressedImages = hwInfo->featureTable.flags.ftrE2ECompression;
277-
hwInfo->capabilityTable.ftrRenderCompressedBuffers = hwInfo->featureTable.flags.ftrE2ECompression;
278-
}
279-
280274
} // namespace NEO

shared/source/xe_hpg_core/xe_lpg/os_agnostic_product_helper_xe_lpg.inl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,4 @@ template <>
121121
bool ProductHelperHw<gfxProduct>::isHostUsmAllocationReuseSupported() const {
122122
return true;
123123
}
124-
125-
template <PRODUCT_FAMILY gfxProduct>
126-
void ProductHelperHw<gfxProduct>::enableCompression(HardwareInfo *hwInfo) const {}
127-
128124
} // namespace NEO

shared/test/unit_test/xe_hpg_core/os_agnostic_product_helper_xe_lpg_tests.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -371,13 +371,3 @@ HWTEST2_F(XeLpgProductHelperTests, givenPatIndexWhenCheckIsCoherentAllocationThe
371371
EXPECT_FALSE(productHelper->isCoherentAllocation(patIndex).value());
372372
}
373373
}
374-
375-
HWTEST2_F(XeLpgProductHelperTests, givenProductHelperWhenCallConfigureHardwareCustomThenCompressionIsDisabled, IsXeLpg) {
376-
auto hwInfo = *defaultHwInfo;
377-
hwInfo.featureTable.flags.ftrE2ECompression = true;
378-
379-
productHelper->configureHardwareCustom(&hwInfo, nullptr);
380-
381-
EXPECT_FALSE(hwInfo.capabilityTable.ftrRenderCompressedBuffers);
382-
EXPECT_FALSE(hwInfo.capabilityTable.ftrRenderCompressedImages);
383-
}

0 commit comments

Comments
 (0)