Add lock to downloading allocations on tbx

When running multiple threads, one thread could clear
allocationsForDownload while another was iterating over it.

Signed-off-by: Dominik Dabek <[email protected]>

Author: ddabek-i

shared/source/command_stream/tbx_command_stream_receiver_hw.inl

@@ -485,6 +485,7 @@ void TbxCommandStreamReceiverHw<GfxFamily>::flushSubmissionsAndDownloadAllocatio
         pollAddress = ptrOffset(pollAddress, this->postSyncWriteOffset);
     }
 
+    auto lockCSR = this->obtainUniqueOwnership();
     for (GraphicsAllocation *graphicsAllocation : this->allocationsForDownload) {
         downloadAllocation(*graphicsAllocation);
     }
@@ -555,6 +556,7 @@ void TbxCommandStreamReceiverHw<GfxFamily>::downloadAllocations() {
         }
         pollAddress = ptrOffset(pollAddress, this->postSyncWriteOffset);
     }
+    auto lockCSR = this->obtainUniqueOwnership();
     for (GraphicsAllocation *graphicsAllocation : this->allocationsForDownload) {
         downloadAllocation(*graphicsAllocation);
     }

shared/test/common/mocks/mock_tbx_csr.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2018-2021 Intel Corporation
+ * Copyright (C) 2018-2022 Intel Corporation
  *
  * SPDX-License-Identifier: MIT
  *
@@ -87,8 +87,14 @@ struct MockTbxCsrRegisterDownloadedAllocations : TbxCommandStreamReceiverHw<GfxF
     void flushTagUpdate() override {
         flushTagCalled = true;
     }
+
+    std::unique_lock<CommandStreamReceiver::MutexType> obtainUniqueOwnership() override {
+        obtainUniqueOwnershipCalled++;
+        return TbxCommandStreamReceiverHw<GfxFamily>::obtainUniqueOwnership();
+    }
     std::set<GraphicsAllocation *> downloadedAllocations;
     bool flushBatchedSubmissionsCalled = false;
     bool flushTagCalled = false;
+    size_t obtainUniqueOwnershipCalled = 0;
 };
 } // namespace NEO

shared/test/unit_test/command_stream/tbx_command_stream_tests.cpp

@@ -394,7 +394,9 @@ HWTEST_F(TbxCommandSteamSimpleTest, givenLatestFlushedTaskCountLowerThanTagWhenF
     tbxCsr.latestFlushedTaskCount = 0u;
     EXPECT_FALSE(tbxCsr.flushTagCalled);
 
+    EXPECT_EQ(0u, tbxCsr.obtainUniqueOwnershipCalled);
     tbxCsr.flushSubmissionsAndDownloadAllocations(1u);
+    EXPECT_EQ(1u, tbxCsr.obtainUniqueOwnershipCalled);
 
     EXPECT_TRUE(tbxCsr.flushTagCalled);
 }
@@ -410,7 +412,9 @@ HWTEST_F(TbxCommandSteamSimpleTest, givenTbxCsrWhenDownloadAllocatoinsCalledThen
     MockGraphicsAllocation allocation1, allocation2, allocation3;
     tbxCsr.allocationsForDownload = {&allocation1, &allocation2, &allocation3};
 
+    EXPECT_EQ(0u, tbxCsr.obtainUniqueOwnershipCalled);
     tbxCsr.downloadAllocations();
+    EXPECT_EQ(1u, tbxCsr.obtainUniqueOwnershipCalled);
 
     std::set<GraphicsAllocation *> expectedDownloadedAllocations = {tbxCsr.getTagAllocation(), &allocation1, &allocation2, &allocation3};
     EXPECT_EQ(0u, tbxCsr.allocationsForDownload.size());