acl_threadsupport: fix integer conversion warning

pcolberg · pcolberg · commit d707cc29636e · 2022-11-17T11:14:13.000-05:00
Use same type for timed_out as member of struct acl_condvar_s.

The return type is signed to accommodate for the error return value.

Signed-off-by: Peter Colberg &lt;peter.colberg@intel.com&gt;
diff --git a/lib/acl_threadsupport/src/acl_threadsupport.c b/lib/acl_threadsupport/src/acl_threadsupport.c
@@ -386,7 +386,7 @@ void acl_release_condvar(struct acl_condvar_s *C) {
 // value otherwise.
 int acl_timed_wait_condvar(struct acl_condvar_s *C, unsigned timeout_period) {
   int my_entry_q;
-  int timed_out = 0;
+  unsigned int timed_out = 0;
   if (!C)
     return -1;
 
@@ -449,7 +449,7 @@ int acl_timed_wait_condvar(struct acl_condvar_s *C, unsigned timeout_period) {
   }
 
   // Still have the waiter mutex!
-  return timed_out;
+  return (int)timed_out;
 }
 
 // Wait on the condition variable, then release the mutex.

Original file line number	Diff line number	Diff line change
`@@ -386,7 +386,7 @@ void acl_release_condvar(struct acl_condvar_s *C) {`
`386`	`386`	`// value otherwise.`
`387`	`387`	`int acl_timed_wait_condvar(struct acl_condvar_s *C, unsigned timeout_period) {`
`388`	`388`	`int my_entry_q;`
`389`		`- int timed_out = 0;`
	`389`	`+ unsigned int timed_out = 0;`
`390`	`390`	`if (!C)`
`391`	`391`	`return -1;`
`392`	`392`
`@@ -449,7 +449,7 @@ int acl_timed_wait_condvar(struct acl_condvar_s *C, unsigned timeout_period) {`
`449`	`449`	`}`
`450`	`450`
`451`	`451`	`// Still have the waiter mutex!`
`452`		`- return timed_out;`
	`452`	`+ return (int)timed_out;`
`453`	`453`	`}`
`454`	`454`
`455`	`455`	`// Wait on the condition variable, then release the mutex.`