Skip to content

Commit df4be19

Browse files
sherry-yuanpcolberg
authored andcommitted
Remove runtime assert for kernel finish_counter.
Currently the kerne's finish_counter assert > 0 is called whenever there is a kernel interrupt sent. However the kernel interrupt could be sent whenever: 1. printf buffer is full 2. The kernel change state: init -> running -> finish/stall 3. clGetProfileInfoIntelFPGA is called From the first reason, it already doesn't make sense to assert finish counter greater than 0, as is very possible for a printf buffer to be full before the kernel finishes.
1 parent 8295911 commit df4be19

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

src/acl_kernel_if.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1415,9 +1415,6 @@ void acl_kernel_if_update_status(acl_kernel_if *kern) {
14151415
&finish_counter);
14161416
ACL_KERNEL_IF_DEBUG_MSG(kern, ":: Accelerator %d has %d finishes.\n", k,
14171417
finish_counter);
1418-
// At this point, this kernel has finish bit set on CSR
1419-
// Finish counter should be > 0
1420-
assert(finish_counter > 0);
14211418
}
14221419

14231420
for (i = 0; i < finish_counter; i++) {

0 commit comments

Comments
 (0)