Skip to content

Commit fc99b92

Browse files
sherry-yuanpcolberg
authored andcommitted
Remove please in messages and documentations
------------------------------------------------------------- Avoid using please in technical documentations according to https://www.sitepoint.com/making-demands-when-to-say-please-in-instructions-and-ctas/
1 parent c91cf27 commit fc99b92

File tree

8 files changed

+11
-11
lines changed

8 files changed

+11
-11
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ endif()
2828

2929
# We exclusively support Ninja as the generator used to build the project.
3030
if(NOT CMAKE_GENERATOR STREQUAL "Ninja")
31-
message(FATAL_ERROR "unsupported cmake generator, please use `cmake -G Ninja`")
31+
message(FATAL_ERROR "unsupported cmake generator, use `cmake -G Ninja` instead")
3232
endif()
3333

3434
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake/modules")

src/acl_auto_configure.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ bool acl_load_device_def_from_str(const std::string &config_str,
206206
err_ss << "Error: The accelerator hardware currently programmed is "
207207
"incompatible with this\nversion of the runtime (" ACL_VERSION
208208
" Commit " ACL_GIT_COMMIT ")."
209-
" Please recompile the hardware with\nthe same version of the "
209+
" Recompile the hardware with\nthe same version of the "
210210
"compiler and program that onto the board.\n";
211211
err_str = err_ss.str();
212212
}

src/acl_context.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -585,7 +585,7 @@ static cl_int l_load_properties(cl_context context,
585585
override = override_deprecated;
586586
fprintf(stderr,
587587
"Warning: CL_CONTEXT_COMPILER_MODE_ALTERA has been deprecated. "
588-
"Please use CL_CONTEXT_COMPILER_MODE_INTELFPGA instead.\n");
588+
"Use CL_CONTEXT_COMPILER_MODE_INTELFPGA instead.\n");
589589
}
590590

591591
if (override) {

src/acl_device_binary.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ cl_int acl_device_binary_t::load_binary_pkg(int validate_compile_options,
243243
<< "This binary targets the BSP variant " << pkg_board_str
244244
<< ", while the FPGA has the BSP\n"
245245
<< "variant " << dev_prog->device->def.autodiscovery_def.name << ".\n"
246-
<< "Please use the command 'aocl initialize' to load the matching BSP\n"
246+
<< "Use the command 'aocl initialize' to load the matching BSP\n"
247247
<< "variant prior to invoking the host executable.";
248248
if (!acl_getenv("ACL_PCIE_PROGRAM_SKIP_BOARDNAME_CHECK")) {
249249
AND_CHECK(pkg_board_str == dev_prog->device->def.autodiscovery_def.name,

src/acl_globals.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const char *acl_get_offline_device_user_setting(int *use_offline_only_ret) {
8787
setting = setting_deprecated;
8888
if (0 == warn_depr1) {
8989
fprintf(stderr, "[Runtime Warning]: CL_CONTEXT_OFFLINE_DEVICE_ALTERA has "
90-
"been deprecated. Please use "
90+
"been deprecated. Use "
9191
"CL_CONTEXT_OFFLINE_DEVICE_INTELFPGA instead.\n");
9292
warn_depr1 = 1;
9393
}
@@ -119,7 +119,7 @@ const char *acl_get_offline_device_user_setting(int *use_offline_only_ret) {
119119
setting = setting_deprecated;
120120
if (0 == warn_depr3) {
121121
fprintf(stderr, "[Runtime Warning]: CL_CONTEXT_MSIM_DEVICE_ALTERA "
122-
"has been deprecated. Please use "
122+
"has been deprecated. Use "
123123
"CL_CONTEXT_MSIM_DEVICE_INTELFPGA instead.\n");
124124
warn_depr3 = 1;
125125
}

src/acl_hal_mmd.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1445,7 +1445,7 @@ int acl_hal_mmd_try_devices(cl_uint num_devices, const cl_device_id *devices,
14451445
" This combination of BSPs is not supported by "
14461446
"the Intel(R) FPGA SDK for OpenCL(TM) runtime.\n");
14471447
fprintf(stderr,
1448-
" Please uninstall the incompatible BSP(s) using "
1448+
" Uninstall the incompatible BSP(s) using "
14491449
"\"aocl uninstall <board_package_path>\".\n");
14501450
failed_device_id = physical_device_id;
14511451
goto failed;

src/acl_hostch.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ CL_API_ENTRY cl_int CL_API_CALL clReadPipeIntelFPGA(cl_mem pipe, void *ptr) {
268268
if (ptr == NULL) {
269269
acl_mutex_unlock(&(pipe->host_pipe_info->m_lock));
270270
ERR_RET(CL_INVALID_VALUE, pipe->context,
271-
"Please provide a valid pointer to host data");
271+
"Invalid pointer was provided to host data");
272272
}
273273

274274
// Is the pipe bound to a channel yet? If not then return unsuccessfully
@@ -368,7 +368,7 @@ CL_API_ENTRY cl_int CL_API_CALL clWritePipeIntelFPGA(cl_mem pipe, void *ptr) {
368368
if (ptr == NULL) {
369369
acl_mutex_unlock(&(pipe->host_pipe_info->m_lock));
370370
ERR_RET(CL_INVALID_VALUE, pipe->context,
371-
"Please provide a valid pointer to host data");
371+
"Invalid pointer was provided to host data");
372372
}
373373

374374
// If there is no queued op and the pipe is binded
@@ -472,7 +472,7 @@ CL_API_ENTRY void *CL_API_CALL clMapHostPipeIntelFPGA(cl_mem pipe,
472472
if (mapped_size == NULL) {
473473
acl_mutex_unlock(&(pipe->host_pipe_info->m_lock));
474474
BAIL_INFO(CL_INVALID_VALUE, pipe->context,
475-
"Please provide a valid pointer for mapped_size argument");
475+
"Invalid pointer was provided for mapped_size argument");
476476
}
477477
*mapped_size = 0;
478478

test/acl_auto_configure_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -877,7 +877,7 @@ TEST(auto_configure, bad_config) {
877877
std::string("Error: The accelerator hardware currently programmed is "
878878
"incompatible with this\nversion of the runtime (" ACL_VERSION
879879
" Commit " ACL_GIT_COMMIT
880-
"). Please recompile the hardware with\nthe same version of "
880+
"). Recompile the hardware with\nthe same version of "
881881
"the compiler and program that onto the board.\n"),
882882

883883
// Bad workgroup/workitem_invariant combination

0 commit comments

Comments
 (0)