Skip to content

Commit 4f87ec6

Browse files
authored
remove bindings and skip tests when GC_ENABLE_DNNL=OFF (#213)
1 parent f5bde39 commit 4f87ec6

File tree

7 files changed

+33
-14
lines changed

7 files changed

+33
-14
lines changed

python/CMakeLists.txt

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,23 +56,25 @@ declare_mlir_python_sources(GcPythonSources.Common
5656
# Dialect bindings
5757
################################################################################
5858

59-
declare_mlir_dialect_python_bindings(
59+
if(GC_ENABLE_DNNL)
60+
declare_mlir_dialect_python_bindings(
6061
ADD_TO_PARENT GcPythonSources
6162
ROOT_DIR "${CMAKE_CURRENT_SOURCE_DIR}/gc_mlir"
6263
TD_FILE dialects/OneDNNGraphOps.td
6364
SOURCES
6465
dialects/onednn_graph.py
6566
DIALECT_NAME onednn_graph
66-
)
67+
)
68+
endif()
6769

68-
declare_mlir_dialect_python_bindings(
69-
ADD_TO_PARENT GcPythonSources
70-
ROOT_DIR "${CMAKE_CURRENT_SOURCE_DIR}/gc_mlir"
71-
TD_FILE dialects/CPURuntimeOps.td
72-
SOURCES
73-
dialects/cpuruntime.py
74-
DIALECT_NAME cpuruntime
75-
)
70+
declare_mlir_dialect_python_bindings(
71+
ADD_TO_PARENT GcPythonSources
72+
ROOT_DIR "${CMAKE_CURRENT_SOURCE_DIR}/gc_mlir"
73+
TD_FILE dialects/CPURuntimeOps.td
74+
SOURCES
75+
dialects/cpuruntime.py
76+
DIALECT_NAME cpuruntime
77+
)
7678

7779
declare_mlir_python_extension(GcPythonSources.Extension
7880
MODULE_NAME _gc_mlir

python/MainModule.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ PYBIND11_MODULE(_gc_mlir, m) {
2929
//===----------------------------------------------------------------------===//
3030
// OneDNNGraph
3131
//===----------------------------------------------------------------------===//
32-
32+
#ifdef GC_HAS_ONEDNN_DIALECT
3333
auto onednn_graphM = m.def_submodule("onednn_graph");
3434
onednn_graphM.def(
3535
"register_dialect",
@@ -41,6 +41,7 @@ PYBIND11_MODULE(_gc_mlir, m) {
4141
}
4242
},
4343
py::arg("context") = py::none(), py::arg("load") = true);
44+
#endif
4445

4546
//===----------------------------------------------------------------------===//
4647
// CPURuntime

python/gc_mlir/_mlir_libs/_site_initialize_0.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,16 @@
88

99

1010
def context_init_hook(context):
11-
from ._gc_mlir.onednn_graph import register_dialect as register_onednn_graph_dialect
11+
1212
from ._gc_mlir.cpuruntime import register_dialect as register_cpuruntime_dialect
13-
14-
register_onednn_graph_dialect(context)
13+
1514
register_cpuruntime_dialect(context)
15+
16+
try:
17+
from ._gc_mlir.onednn_graph import (
18+
register_dialect as register_onednn_graph_dialect,
19+
)
20+
21+
register_onednn_graph_dialect(context)
22+
except ModuleNotFoundError:
23+
print("onednn_graph dialect not found")
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
if not config.gc_use_dnnl:
2+
config.unsupported = True
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
if not config.gc_use_dnnl:
2+
config.excludes.add("onednn_graph.py")
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
config.suffixes.add(".py")
22

3+
if not config.gc_use_dnnl:
4+
config.excludes.add("smoketest.py")
5+
36
if not config.enable_bindings_python:
47
config.unsupported = True

test/mlir/test/lit.site.cfg.py.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ config.mlir_runner_utils = os.path.normpath(os.path.join(config.mlir_runner_util
4343
config.mlir_c_runner_utils = os.path.normpath(os.path.join(config.mlir_runner_utils_dir, config.shlib_prefix + "mlir_c_runner_utils" + config.llvm_shlib_ext))
4444

4545
config.opencl_runtime = os.path.normpath(os.path.join(config.gc_lib_dir, config.shlib_prefix + "GcOpenclRuntime" + config.llvm_shlib_ext))
46+
config.gc_use_dnnl = "@GC_ENABLE_DNNL@" in ["ON", "1"]
4647

4748
import lit.llvm
4849
lit.llvm.initialize(lit_config, config)

0 commit comments

Comments
 (0)