add to declaration

yifeizh2 · yifeizh2 · commit 9ecf54e9a02f · 2024-10-09T18:51:07.000-07:00
diff --git a/include/gc/Analysis/MatmulConfigAnalysis.h b/include/gc/Analysis/MatmulConfigAnalysis.h
@@ -33,6 +33,8 @@ struct MatmulConfig {
   uint32_t innerMostMBlock, innerMostNBlock, innerMostKBlock;
 };
 
+bool validateConfig(const MatmulConfig &cfg, ArrayRef<uint32_t> shape = {});
+
 enum DimType { Batch, M, N, K };
 
 // Extract the index of the given DimType in the DimType list
diff --git a/lib/gc/Analysis/MatmulConfigAnalysis.cpp b/lib/gc/Analysis/MatmulConfigAnalysis.cpp
@@ -37,7 +37,7 @@ static llvm::raw_ostream &operator<<(llvm::raw_ostream &ss,
   return ss;
 }
 
-bool validateConfig(const MatmulConfig &cfg, ArrayRef<uint32_t> shape = {}) {
+bool validateConfig(const MatmulConfig &cfg, ArrayRef<uint32_t> shape) {
   if (cfg.MThreads <= 0 || cfg.NThreads <= 0 || cfg.KThreads <= 0 ||
       cfg.MBlock <= 0 || cfg.NBlock <= 0 || cfg.KBlock <= 0 ||
       cfg.innerMostMBlock <= 0 || cfg.innerMostNBlock <= 0 ||

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ static llvm::raw_ostream &operator<<(llvm::raw_ostream &ss,`
`37`	`37`	`return ss;`
`38`	`38`	`}`
`39`	`39`
`40`		`-bool validateConfig(const MatmulConfig &cfg, ArrayRef<uint32_t> shape = {}) {`
	`40`	`+bool validateConfig(const MatmulConfig &cfg, ArrayRef<uint32_t> shape) {`
`41`	`41`	`if (cfg.MThreads <= 0 \|\| cfg.NThreads <= 0 \|\| cfg.KThreads <= 0 \|\|`
`42`	`42`	`cfg.MBlock <= 0 \|\| cfg.NBlock <= 0 \|\| cfg.KBlock <= 0 \|\|`
`43`	`43`	`cfg.innerMostMBlock <= 0 \|\| cfg.innerMostNBlock <= 0 \|\|`