Skip to content

Commit fdba6cc

Browse files
committed
Fix static gc-opt build & add comments for components registration
1 parent ed473f5 commit fdba6cc

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

src/gc-opt/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,15 @@ if(GC_DEV_LINK_LLVM_DYLIB)
2626
)
2727
get_property(dialect_libs GLOBAL PROPERTY GC_DIALECT_LIBS)
2828
get_property(conversion_libs GLOBAL PROPERTY GC_PASS_LIBS)
29+
get_property(extension_libs GLOBAL PROPERTY GC_EXTENSION_LIBS)
2930
else()
3031
set(MLIR_LINK_COMPONENTS
3132
MLIROptLib
33+
MLIRToLLVMIRTranslationRegistration
3234
)
3335
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
3436
get_property(conversion_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS)
37+
get_property(extension_libs GLOBAL PROPERTY MLIR_EXTENSION_LIBS)
3538
endif()
3639

3740
add_llvm_executable(gc-opt gc-opt.cpp)

src/gc-opt/gc-opt.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,11 @@ int main(int argc, char *argv[]) {
6767
registry.insert<mlir::microkernel::MicrokernelDialect>();
6868
registry.insert<mlir::gen::GENDialect>();
6969
mlir::registerAllDialects(registry);
70+
// covers lowerings for weird dialects like ub
71+
// TODO: avoid `registerALL` to remove this
7072
mlir::registerAllExtensions(registry);
73+
// Adds missing `LLVMTranslationDialectInterface` registration for dialect for
74+
// gpu.module op
7175
mlir::registerAllToLLVMIRTranslations(registry);
7276
mlir::gen::registerGenTargetInterfaceExternalModels(registry);
7377
mlir::registerGENDialectTranslation(registry);

0 commit comments

Comments
 (0)