Avoid emitting the same instruction twice

Cmp sources were emitted twice, due to  unnecessary call to `GetSource`
function.

Author: aratajew

IGC/Compiler/CISACodeGen/EmitVISAPass.cpp

@@ -13943,8 +13943,6 @@ void EmitPass::emitAtomicCounter(llvm::GenIntrinsicInst* pInsn)
 
 void EmitPass::CmpBoolOp(Pattern* cmpPattern,
     llvm::BinaryOperator* inst,
-    llvm::CmpInst::Predicate predicate,
-    const SSource cmpSources[2],
     const SSource& bitSource,
     const DstModifier& modifier)
 {

IGC/Compiler/CISACodeGen/EmitVISAPass.hpp

@@ -101,8 +101,6 @@ class EmitPass : public llvm::FunctionPass
     void BinaryUnary(llvm::Instruction* inst, const  SSource source[2], const DstModifier& modifier);
     void CmpBoolOp(Pattern* cmpPattern,
         llvm::BinaryOperator* inst,
-        llvm::CmpInst::Predicate predicate,
-        const  SSource source[2],
         const SSource& bitSource,
         const DstModifier& modifier);
     void emitAluConditionMod(Pattern* aluPattern, llvm::Instruction* alu, llvm::CmpInst* cmp, int aluOprdNum);

IGC/Compiler/CISACodeGen/PatternMatchPass.cpp

@@ -4109,12 +4109,10 @@ namespace IGC
         {
             Pattern* cmpPattern;
             llvm::BinaryOperator* boolOp;
-            llvm::CmpInst::Predicate predicate;
-            SSource cmpSource[2];
             SSource binarySource;
             virtual void Emit(EmitPass* pass, const DstModifier& modifier)
             {
-                pass->CmpBoolOp(cmpPattern, boolOp, predicate, cmpSource, binarySource, modifier);
+                pass->CmpBoolOp(cmpPattern, boolOp, binarySource, modifier);
             }
         };
 
@@ -4130,12 +4128,8 @@ namespace IGC
                     if (I.getOperand(1 - i)->hasOneUse())
                     {
                         BoolOpPattern* pattern = new (m_allocator) BoolOpPattern();
-                        bool supportsMod = SupportsModifier(cmp);
                         pattern->cmpPattern = Match(*cmp);
                         pattern->boolOp = &I;
-                        pattern->predicate = cmp->getPredicate();
-                        pattern->cmpSource[0] = GetSource(cmp->getOperand(0), supportsMod, false);
-                        pattern->cmpSource[1] = GetSource(cmp->getOperand(1), supportsMod, false);
                         pattern->binarySource = GetSource(I.getOperand(1 - i), false, false);
                         AddPattern(pattern);
                         found = true;