Skip to content

Commit 19146c2

Browse files
dguzhaevigcbot
authored andcommitted
Removed pass dependency from GenTTI
Removed Dummy pass dependency
1 parent 669fbb0 commit 19146c2

File tree

3 files changed

+4
-25
lines changed

3 files changed

+4
-25
lines changed

IGC/Compiler/CISACodeGen/ShaderCodeGen.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -405,9 +405,8 @@ void AddLegalizationPasses(CodeGenContext& ctx, IGCPassManager& mpm, PSSignature
405405
IGC_IS_FLAG_ENABLED(ForceAllPrivateMemoryToSLM) ||
406406
IGC_IS_FLAG_ENABLED(ForcePrivateMemoryToSLMOnBuffers))
407407
{
408-
DummyPass* dummypass = new DummyPass();
409408
TargetIRAnalysis GenTTgetIIRAnalysis([&](const Function& F) {
410-
GenIntrinsicsTTIImpl GTTI(&ctx, dummypass);
409+
GenIntrinsicsTTIImpl GTTI(&ctx);
411410
return TargetTransformInfo(GTTI);
412411
});
413412
mpm.add(new TargetTransformInfoWrapperPass(GenTTgetIIRAnalysis));
@@ -1252,10 +1251,8 @@ void OptimizeIR(CodeGenContext* const pContext)
12521251
mpm.add(new MetaDataUtilsWrapper(pMdUtils, pContext->getModuleMetaData()));
12531252

12541253
mpm.add(new CodeGenContextWrapper(pContext));
1255-
DummyPass* dummypass = new DummyPass();
1256-
mpm.add(dummypass);
12571254
TargetIRAnalysis GenTTgetIIRAnalysis([&](const Function& F) {
1258-
GenIntrinsicsTTIImpl GTTI(pContext, dummypass);
1255+
GenIntrinsicsTTIImpl GTTI(pContext);
12591256
return TargetTransformInfo(GTTI);
12601257
});
12611258

IGC/Compiler/GenTTI.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,6 @@ using namespace IGC;
3232

3333
namespace llvm {
3434

35-
char DummyPass::ID = 0;
36-
void initializeDummyPassPass(PassRegistry& Registry);
37-
DummyPass::DummyPass() : ImmutablePass(ID) {
38-
initializeDummyPassPass(*PassRegistry::getPassRegistry());
39-
}
40-
4135
bool GenIntrinsicsTTIImpl::isLoweredToCall(const Function* F)
4236
{
4337
if (GenISAIntrinsic::isIntrinsic(F))
@@ -651,6 +645,3 @@ namespace llvm {
651645
#endif
652646

653647
} // namespace llvm
654-
// Register the basic pass.
655-
INITIALIZE_PASS(DummyPass, "gen-tti-dummy-pass",
656-
"Dummy Pass for GenTTIImpl", false, true)

IGC/Compiler/GenTTI.h

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@ SPDX-License-Identifier: MIT
1717

1818
namespace llvm
1919
{
20-
class DummyPass : public ImmutablePass
21-
{
22-
public:
23-
static char ID;
24-
DummyPass();
25-
};
2620

2721
// This implementation allows us to define our own costs for the GenIntrinsics
2822
// Did not use BasicTTIImplBase because the overloaded constructors have TragetMachine as an argument,
@@ -33,12 +27,9 @@ namespace llvm
3327
typedef TargetTransformInfo TTI;
3428
friend BaseT;
3529
IGC::CodeGenContext* ctx;
36-
DummyPass* dummyPass;
3730
public:
38-
GenIntrinsicsTTIImpl(IGC::CodeGenContext* pCtx, DummyPass* pDummyPass) :
39-
BaseT(pCtx->getModule()->getDataLayout()), ctx(pCtx) {
40-
dummyPass = pDummyPass;
41-
}
31+
GenIntrinsicsTTIImpl(IGC::CodeGenContext* pCtx) :
32+
BaseT(pCtx->getModule()->getDataLayout()), ctx(pCtx) {}
4233

4334
bool shouldBuildLookupTables();
4435

0 commit comments

Comments
 (0)