Make dump() no arg function. Add dumptofile(filename).

Those two are expected to be invoked inside debugger.

Author: jgu222

visa/FlowGraph.cpp

@@ -4574,7 +4574,7 @@ void FlowGraph::print(std::ostream& OS) const
         << (builder->getIsKernel() ? " [kernel]" : " [non-kernel function]")
         << "\n\n";
     for (auto BB : BBs) {
-        BB->dump(OS);
+        BB->print(OS);
     }
 }
 
@@ -4583,6 +4583,12 @@ void FlowGraph::dump() const
     print(std::cerr);
 }
 
+void FlowGraph::dumptofile(const char* Filename) const
+{
+    std::fstream ofile(Filename, std::ios::out);
+    print(ofile);
+}
+
 FlowGraph::~FlowGraph()
 {
     // even though G4_BBs are allocated in a mem pool and freed in one shot,

visa/FlowGraph.h

@@ -643,7 +643,8 @@ class FlowGraph
     void findNestedDivergentBBs(std::unordered_map<G4_BB*, int>& nestedDivergentBBs);
 
     void print(std::ostream& OS) const;
-    void dump() const;
+    void dump() const;  // used in debugger
+    void dumptofile(const char* Filename) const; // used in debugger
 private:
     // Use normalized region descriptors for each source operand if possible.
     void normalizeRegionDescriptors();

visa/G4_BB.cpp

@@ -1454,7 +1454,12 @@ const char* G4_BB::getBBTypeStr() const
     return " ";
 }
 
-void G4_BB::dump(std::ostream& OS) const
+void G4_BB::dump() const
+{
+    print(std::cerr);
+}
+
+void G4_BB::print(std::ostream& OS) const
 {
     OS << "BB" << getId() << ":";
     if (getBBType())

visa/G4_BB.hpp

@@ -321,7 +321,8 @@ class G4_BB
     /// Dump instructions into the standard error.
     const char* getBBTypeStr() const;
 
-    void dump(std::ostream& os = std::cerr) const;
+    void print(std::ostream& os = std::cerr) const;
+    void dump() const;  // used in debugger
     void dumpDefUse(std::ostream& os = std::cerr) const;
 
     // reset this BB's instruction's local id so they are [0,..#BBInst-1]

visa/G4_Kernel.cpp

@@ -577,9 +577,14 @@ void G4_Kernel::evalAddrExp()
     }
 }
 
-void G4_Kernel::dump(std::ostream& OS) const
+void G4_Kernel::dump() const
 {
-    fg.print(OS);
+    fg.print(std::cerr);
+}
+
+void G4_Kernel::dumptofile(const char* Filename) const
+{
+    fg.dumptofile(Filename);
 }
 
 void G4_Kernel::dumpDotFile(const char* appendix)

visa/G4_Kernel.hpp

@@ -251,7 +251,8 @@ class G4_Kernel
     void evalAddrExp();
 
     /// dump this kernel to the standard error
-    void dump(std::ostream& OS = std::cerr) const;
+    void dump() const;  // used in debugger
+    void dumptofile(const char* Filename) const;  // used in debugger
     void dumpDotFile(const char* appendix);
     void emit_asm(std::ostream& output, bool beforeRegAlloc, void * binary, uint32_t binarySize);
     void emit_RegInfo();