Skip to content

Commit 280b094

Browse files
DianaChensys_zuul
authored andcommitted
Enable A64 WA by default
Change-Id: I08946269ed19f71586d2e35673a67c22445cd65a
1 parent 3b92ca9 commit 280b094

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

IGC/Compiler/CISACodeGen/DriverInfo.hpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,9 @@ namespace IGC
271271
/// Check for flush to zero for DP emulated function
272272
virtual bool DPEmulationFlushToZero() const { return false; }
273273

274+
/// check if the API support A64 WA. Corresponding RegKey for A64 WA is EnableA64WA
275+
virtual bool EnableA64WA() const { return true; }
276+
274277

275278

276279
};

IGC/Compiler/CISACodeGen/EmitVISAPass.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14417,7 +14417,9 @@ void EmitPass::A64LSLoopTail(CVariable* curMask, CVariable* lsPred, uint label)
1441714417

1441814418
bool EmitPass::hasA64WAEnable() const
1441914419
{
14420-
if (m_pCtx->getModuleMetaData()->compOpt.DisableA64WA)
14420+
// check if the WA is disable by compiler flag or if the API can't support it
14421+
if (m_pCtx->getModuleMetaData()->compOpt.DisableA64WA ||
14422+
(!m_pCtx->m_DriverInfo.EnableA64WA()))
1442114423
return false;
1442214424
return m_currShader->m_Platform->WaEnableA64WA();
1442314425
}

IGC/common/igc_flags.def

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ DECLARE_IGC_REGKEY(bool, ForceNoFP64bRegioning, false, "force regioning rules fo
376376
DECLARE_IGC_REGKEY(bool, EnableOneStepElf, true, "Enable generation of direct elf mapping src->Gen ISA", false)
377377
DECLARE_IGC_REGKEY(bool, EmitDebugRanges, false, "Emit .debug_ranges section when instructions in a block are non-consecutive", false)
378378
DECLARE_IGC_REGKEY(bool, EmitDebugLoc, false, "Enable generation of .debug_loc section", false)
379-
DECLARE_IGC_REGKEY(bool, EnableA64WA, false, "Guarantee A64 load/store addres-hi is uniform", false)
379+
DECLARE_IGC_REGKEY(bool, EnableA64WA, true, "Guarantee A64 load/store addres-hi is uniform", false)
380380

381381
DECLARE_IGC_GROUP("Generating precompiled headers")
382382
DECLARE_IGC_REGKEY(bool, ApplyConservativeRastWAHeader, true, "Apply WaConservativeRasterization for the platforms enabled", false)

0 commit comments

Comments
 (0)