Skip to content

Commit 2c28e7a

Browse files
karolmikolajczukigcbot
authored andcommitted
Revert "Add NT_INTELGT_PRODUCT_CONFIG to IntelGTNotes"
Revert "Expand .note.intelgt.compat section of zebin files with a new NT_INTELGT_PRODUCT_CONFIG note so it can be used for program validation instead of NT_INTELGT_PRODUCT_FAMILY, NT_INTELGT_GFXCORE_FAMILY and NT_INTELGT_TARGET_METADATA."
1 parent cc078cf commit 2c28e7a

File tree

8 files changed

+2
-49
lines changed

8 files changed

+2
-49
lines changed

IGC/AdaptorOCL/OCL/sp/spp_g8.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,6 @@ bool CGen8OpenCLProgram::GetZEBinary(
458458
(const uint8_t*)buildOptions, buildOptionsSize);
459459
zebuilder.setProductFamily(m_Platform.eProductFamily);
460460
zebuilder.setGfxCoreFamily(m_Platform.eRenderCoreFamily);
461-
zebuilder.setGmdID(m_Platform.sRenderBlockID);
462461

463462
//
464463
// Creating ZE binary requires linking individual ELF files,

IGC/AdaptorOCL/OCL/sp/zebin_builder.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,6 @@ void ZEBinaryBuilder::setGfxCoreFamily(GFXCORE_FAMILY value)
6464
mBuilder.setGfxCoreFamily(value);
6565
}
6666

67-
void ZEBinaryBuilder::setGmdID(GFX_GMD_ID value)
68-
{
69-
mBuilder.setGmdID(value);
70-
}
71-
7267
void ZEBinaryBuilder::createKernel(
7368
const char* rawIsaBinary,
7469
unsigned int rawIsaBinarySize,

IGC/AdaptorOCL/OCL/sp/zebin_builder.hpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,6 @@ class ZEBinaryBuilder : DisallowCopy
5050
// Set the GfxCoreFamily as the specified value.
5151
void setGfxCoreFamily(GFXCORE_FAMILY value);
5252

53-
// Set the GmdId as the specified value.
54-
void setGmdID(GFX_GMD_ID value);
55-
5653
// Pair of name for the section (1st elem) and VISA asm text (2nd elem).
5754
using NamedVISAAsm = std::pair<std::string, std::string>;
5855

IGC/Compiler/CISACodeGen/EmitVISAPass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8239,7 +8239,7 @@ void EmitPass::EmitGenIntrinsicMessage(llvm::GenIntrinsicInst* inst)
82398239
case GenISAIntrinsic::GenISA_software_exception:
82408240
{
82418241
CVariable *Mask = m_currShader->ImmToVariable(
8242-
1 << 28,
8242+
1 << 29,
82438243
ISA_TYPE_UD);
82448244

82458245
m_encoder->SetSrcSubReg(0, 1);

IGC/ZEBinWriter/zebin/source/ZEELF.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,6 @@ enum {
5959
// attribute and section changes. The content is stored in a nul-terminated
6060
// string and the format is "<Major number>.<Minor number>".
6161
NT_INTELGT_ZEBIN_VERSION = 4,
62-
// The description is stored in a 4-byte ELF word and is used instead
63-
// of NT_INTELGT_PRODUCT_FAMILY, NT_INTELGT_GFXCORE_FAMILY and
64-
// NT_INTELGT_TARGET_METADATA because it contains all required info to
65-
// validate program for a target device
66-
NT_INTELGT_PRODUCT_CONFIG = 5,
6762
};
6863

6964
struct TargetMetadata {

IGC/ZEBinWriter/zebin/source/ZEELFObjectBuilder.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -630,12 +630,6 @@ std::pair<uint64_t, uint64_t> ELFWriter::writeCompatibilityNote() {
630630
writeOneStrNote("IntelGT",
631631
PreDefinedAttrGetter::getVersionNumber(),
632632
NT_INTELGT_ZEBIN_VERSION);
633-
634-
// write NT_INTELGT_PRODUCT_CONFIG
635-
writeOneNote("IntelGT",
636-
m_ObjBuilder.m_gmdID.Value,
637-
NT_INTELGT_PRODUCT_CONFIG);
638-
639633
return std::make_pair(start_off, m_W.OS.tell() - start_off);
640634
}
641635

IGC/ZEBinWriter/zebin/source/ZEELFObjectBuilder.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,6 @@ class ZEELFObjectBuilder {
6565
void setTargetMetadata(TargetMetadata metadata) { m_metadata = metadata; }
6666
TargetMetadata getTargetMetadata() const { return m_metadata; }
6767

68-
void setGmdID(GFX_GMD_ID gmdID) { m_gmdID = gmdID; }
69-
GFX_GMD_ID setGmdID() const { return m_gmdID; }
70-
7168
// add a text section contains gen binary
7269
// - name: section name. This is usually the kernel or function name of
7370
// this text section. Do not includes leading .text in given
@@ -378,7 +375,6 @@ class ZEELFObjectBuilder {
378375
PRODUCT_FAMILY m_productFamily = IGFX_UNKNOWN;
379376
GFXCORE_FAMILY m_gfxCoreFamily = IGFX_UNKNOWN_CORE;
380377
TargetMetadata m_metadata;
381-
GFX_GMD_ID m_gmdID;
382378

383379
StandardSectionListTy m_textSections;
384380
StandardSectionListTy m_dataAndbssSections; // data and bss sections

IGC/ZEBinWriter/zebin/spec/elf.md

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ information, depending on section type.
9898
## ELF note type for INTELGT
9999

100100
**n_type**
101-
Currently there are 5 note types defined for INTELGT and the notes are placed
101+
Currently there are 3 note types defined for INTELGT and the notes are placed
102102
in the .note.intelgt.compat section. The consumer of the ZE binary file should
103103
recognize both the owner name (INTELGT) and the type of an ELF note entry to
104104
interpret its description.
@@ -114,11 +114,6 @@ enum {
114114
// attribute and section changes. The content is stored in a nul-terminated
115115
// string and the format is "<Major number>.<Minor number>".
116116
NT_INTELGT_ZEBIN_VERSION = 4,
117-
// The description is stored in a 4-byte ELF word and is used instead
118-
// of NT_INTELGT_PRODUCT_FAMILY, NT_INTELGT_GFXCORE_FAMILY and
119-
// NT_INTELGT_TARGET_METADATA because it contains all required info to
120-
// validate program for a target device
121-
NT_INTELGT_PRODUCT_CONFIG = 5,
122117
};
123118
~~~
124119

@@ -163,24 +158,6 @@ struct TargetMetadata {
163158
};
164159
~~~
165160

166-
**The description of NT_INTELGT_PRODUCT_CONFIG note**
167-
~~~
168-
typedef struct GFX_GMD_ID_DEF
169-
{
170-
union
171-
{
172-
struct
173-
{
174-
unsigned int RevisionID : 6;
175-
unsigned int Reserved : 8;
176-
unsigned int GMDRelease : 8;
177-
unsigned int GMDArch : 10;
178-
}GmdID;
179-
unsigned int Value;
180-
};
181-
}GFX_GMD_ID;
182-
~~~
183-
184161
## Gen Relocation Type
185162
Relocation type for **ELF32_R_TYPE** or **ELF64_R_TYPE**
186163
~~~

0 commit comments

Comments
 (0)