Skip to content

Commit 3526b45

Browse files
houjenkoigcbot
authored andcommitted
[Autobackout][FuncReg]Revert of change: 7f04dc9
Cleanup unnecessary R1Lo Remove workaround from the code patching
1 parent 9bb8557 commit 3526b45

File tree

6 files changed

+9
-20
lines changed

6 files changed

+9
-20
lines changed

IGC/Compiler/CISACodeGen/PixelShaderCodeGen.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,10 @@ void CPixelShader::AllocatePSPayload()
145145
for (uint i = 0; i < GetR1()->GetNumberInstance(); i++)
146146
{
147147
AllocateInput(GetR1(), offset, i, forceLiveOut);
148+
for (auto R1Lo: GetR1Lo()) {
149+
AllocateInput(R1Lo, offset, i, forceLiveOut);
150+
}
151+
148152
offset += getGRFSize();
149153
}
150154
}

visa/BuildCISAIRImpl.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,10 +1025,7 @@ int CISA_IR_Builder::Compile(const char* nameInput, std::ostream* os, bool emit_
10251025
{
10261026
// Copy main kernel's declarations (shader body) into payload section
10271027
kernel->CopyVars(mainKernel);
1028-
kernel->getKernel()->Declares.insert(
1029-
kernel->getKernel()->Declares.end(),
1030-
mainKernel->getKernel()->Declares.begin(),
1031-
mainKernel->getKernel()->Declares.end());
1028+
kernel->getKernel()->Declares = mainKernel->getKernel()->Declares;
10321029

10331030
// Set payload LiveOuts to be output
10341031
uint32_t inputCount = mainKernel->getIRBuilder()->getInputCount();
@@ -1049,8 +1046,7 @@ int CISA_IR_Builder::Compile(const char* nameInput, std::ostream* os, bool emit_
10491046
mainKernel->getIRBuilder()->getRealR0()->setLiveOut();
10501047
}
10511048

1052-
if ((kernel->getIsKernel() && isInPatchingMode) ||
1053-
kernel->getCisaInstCount() == 1)
1049+
if (kernel->getIsKernel() && isInPatchingMode)
10541050
{
10551051
continue;
10561052
}

visa/LocalRA.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,10 +159,7 @@ void LocalRA::preLocalRAAnalysis()
159159
unsigned int numRowsReserved = numRowsEOT;
160160

161161
// Remove unreferenced dcls
162-
if (!builder.getOptions()->getuInt32Option(vISA_CodePatch))
163-
{
164-
gra.removeUnreferencedDcls();
165-
}
162+
gra.removeUnreferencedDcls();
166163

167164
if (builder.getOption(vISA_HybridRAWithSpill) || builder.getOption(vISA_FastCompileRA))
168165
{

visa/RegAlloc.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3547,10 +3547,7 @@ int regAlloc(IR_Builder& builder, PhyRegPool& regPool, G4_Kernel& kernel)
35473547
gra.markGraphBlockLocalVars();
35483548

35493549
//Remove the un-referenced declares
3550-
if (!builder.getOptions()->getuInt32Option(vISA_CodePatch))
3551-
{
3552-
gra.removeUnreferencedDcls();
3553-
}
3550+
gra.removeUnreferencedDcls();
35543551

35553552
if (kernel.getInt32KernelAttr(Attributes::ATTR_Target) == VISA_CM)
35563553
{

visa/VISAKernel.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,6 @@ class VISAKernelImpl : public VISAFunction
166166
std::list<CisaFramework::CisaInst *>::iterator getInstructionListBegin() { return m_instruction_list.begin(); }
167167
std::list<CisaFramework::CisaInst *>::iterator getInstructionListEnd() { return m_instruction_list.end(); }
168168

169-
int getCisaInstCount() { return m_instruction_list.size(); }
170-
171169
unsigned long getGenxBinarySize() { return m_genx_binary_size; }
172170

173171
char * getGenxBinaryBuffer() { return m_genx_binary_buffer; }

visa/VISAKernelImpl.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -570,10 +570,7 @@ int VISAKernelImpl::InitializeFastPath()
570570

571571
void VISAKernelImpl::CopyVars(VISAKernelImpl* from)
572572
{
573-
m_builder->dclpool.getDeclareList().insert(
574-
m_builder->dclpool.getDeclareList().end(),
575-
from->m_builder->dclpool.getDeclareList().begin(),
576-
from->m_builder->dclpool.getDeclareList().end());
573+
m_builder->dclpool.getDeclareList() = from->m_builder->dclpool.getDeclareList();
577574
}
578575

579576
int VISAKernelImpl::InitializeKernel(const char *kernel_name)

0 commit comments

Comments
 (0)