Various vISA refactors

Pass arguments as references.
Iterate in loops using references.
Fix potential nullptr dereferences.
Conform to rule of three or rule of five.

Author: fda0

visa/BinaryEncodingIGA.cpp

@@ -36,7 +36,7 @@ class BinaryEncodingIGA {
   const TARGET_PLATFORM platform;
 
 public:
-  BinaryEncodingIGA(vISA::G4_Kernel &k, std::string fname);
+  BinaryEncodingIGA(vISA::G4_Kernel &k, const std::string& fname);
   ~BinaryEncodingIGA() { delete IGAKernel; }
 
   void SetSWSB(G4_INST *inst, SWSB &sw);
@@ -378,7 +378,7 @@ BinaryEncodingIGA::getIGAInternalPlatform(TARGET_PLATFORM genxPlatform) {
   return platform;
 }
 
-BinaryEncodingIGA::BinaryEncodingIGA(vISA::G4_Kernel &k, std::string fname)
+BinaryEncodingIGA::BinaryEncodingIGA(vISA::G4_Kernel &k, const std::string& fname)
     : kernel(k), fileName(fname), m_kernelBuffer(nullptr),
       m_kernelBufferSize(0), platform(k.fg.builder->getPlatform()) {
   platformModel = Model::LookupModel(getIGAInternalPlatform(platform));

visa/BuildIR.h

@@ -651,6 +651,8 @@ class IR_Builder {
              const WA_TABLE *pWaTable);
 
   ~IR_Builder();
+  IR_Builder(const IR_Builder&) = delete;
+  IR_Builder& operator=(const IR_Builder&) = delete;
 
   void setR0ReadOnly() {
     // NONE is stronger than READ_ONLY, so don't change it

visa/Common_ISA.h

@@ -535,6 +535,7 @@ struct CISA_GEN_VAR {
   };
 
   CISA_GEN_VAR(const CISA_GEN_VAR &) = delete;
+  CISA_GEN_VAR& operator=(const CISA_GEN_VAR&) = delete;
 };
 
 // vISA variables share the same implementation, but are distinct types

visa/FrequencyInfo.cpp

@@ -63,7 +63,7 @@ void FrequencyInfo::storeStaticFrequencyAsMetadata(G4_INST* i)
 void FrequencyInfo::updateStaticFrequencyForBasicBlock(G4_BB *bb) {
   G4_INST *lastInst =
       !bb->getInstList().empty() ? bb->getInstList().back() : nullptr;
-  if (hasFreqMetaData(lastInst)) {
+  if (lastInst && hasFreqMetaData(lastInst)) {
     MDNode *mn_digits = lastInst->getMetadata("stats.blockFrequency.digits");
     MDNode *mn_scale = lastInst->getMetadata("stats.blockFrequency.scale");
     Scaled64 freq =

visa/G4_Operand.h

@@ -539,6 +539,7 @@ class G4_SrcRegRegion final : public G4_Operand {
 
 public:
   G4_SrcRegRegion(G4_SrcRegRegion &rgn);
+  G4_SrcRegRegion& operator=(const G4_SrcRegRegion&) = delete;
   void *operator new(size_t sz, Mem_Manager &m) { return m.alloc(sz); }
 
   bool operator==(const G4_SrcRegRegion &other) {
@@ -715,6 +716,7 @@ class G4_DstRegRegion final : public G4_Operand {
   G4_DstRegRegion(G4_DstRegRegion &rgn);
   G4_DstRegRegion(const IR_Builder &builder, G4_DstRegRegion &rgn,
                   G4_VarBase *new_base);
+  G4_DstRegRegion& operator=(const G4_DstRegRegion&) = delete;
 
   void computeLeftBound(const IR_Builder &builder);
 
@@ -847,6 +849,7 @@ class G4_Predicate final : public G4_Operand {
 
 public:
   G4_Predicate(G4_Predicate &prd);
+  G4_Predicate& operator=(const G4_Predicate&) = delete;
 
   void *operator new(size_t sz, Mem_Manager &m) { return m.alloc(sz); }
   unsigned short getSubRegOff() const { return subRegOff; }

visa/LocalDataflow.h

@@ -50,6 +50,7 @@ class DefEscapeBBAnalysis {
   DefEscapeBBAnalysis(const FlowGraph &cfg) : fg(cfg) {}
 
   DefEscapeBBAnalysis(const DefEscapeBBAnalysis &analysis) = delete;
+  DefEscapeBBAnalysis& operator=(const DefEscapeBBAnalysis&) = delete;
 
   virtual ~DefEscapeBBAnalysis() = default;
 

visa/LocalScheduler/SWSB_G4IR.h

@@ -182,7 +182,8 @@ struct SBBitSets {
   SparseBitVector src;
 
   SBBitSets() {}
-
+  SBBitSets(SBBitSets&& other) = delete;
+  SBBitSets& operator=(SBBitSets&& other) = delete;
   ~SBBitSets() {}
 
   void setDst(int ID, bool value) {

visa/Passes/AccSubstitution.hpp

@@ -36,6 +36,7 @@ class AccSubPass {
   AccSubPass(IR_Builder &B, G4_Kernel &K) : builder(B), kernel(K) {}
 
   AccSubPass(const AccSubPass &) = delete;
+  AccSubPass& operator=(const AccSubPass&) = delete;
 
   virtual ~AccSubPass() = default;
 

visa/Passes/StaticProfiling.hpp

@@ -24,6 +24,7 @@ class StaticProfiling {
       : builder(B), kernel(K) {}
 
   StaticProfiling(const StaticProfiling &) = delete;
+  StaticProfiling& operator=(const StaticProfiling&) = delete;
   virtual ~StaticProfiling() = default;
 
   void ALUInstructionProfile(G4_INST *inst);

visa/VISAKernel.h

@@ -482,7 +482,7 @@ class VISAKernelImpl : public VISAFunction {
   VISA_BUILDER_API int
   AppendVISACFFunctionCallInst(VISA_PredOpnd *pred, VISA_EMask_Ctrl emask,
                                VISA_Exec_Size executionSize,
-                               std::string funcName, unsigned char argSize,
+                               const std::string& funcName, unsigned char argSize,
                                unsigned char returnSize) override;
 
   VISA_BUILDER_API int
@@ -491,7 +491,7 @@ class VISAKernelImpl : public VISAFunction {
                                    VISA_VectorOpnd *funcAddr, uint8_t argSize,
                                    uint8_t returnSize) override;
 
-  VISA_BUILDER_API int AppendVISACFSymbolInst(std::string symbolName,
+  VISA_BUILDER_API int AppendVISACFSymbolInst(const std::string& symbolName,
                                               VISA_VectorOpnd *dst) override;
 
   VISA_BUILDER_API int

visa/VISAKernelImpl.cpp

@@ -3270,7 +3270,7 @@ int VISAKernelImpl::AppendVISACFLabelInst(VISA_LabelOpnd *label) {
 
 int VISAKernelImpl::AppendVISACFFunctionCallInst(
     VISA_PredOpnd *pred, VISA_EMask_Ctrl emask, VISA_Exec_Size executionSize,
-    std::string funcName, unsigned char argSize, unsigned char returnSize) {
+    const std::string& funcName, unsigned char argSize, unsigned char returnSize) {
   TIME_SCOPE(VISA_BUILDER_APPEND_INST);
 
   AppendVISAInstCommon();
@@ -3383,7 +3383,7 @@ int VISAKernelImpl::AppendVISACFIndirectFuncCallInst(
   return status;
 }
 
-int VISAKernelImpl::AppendVISACFSymbolInst(std::string symbolName,
+int VISAKernelImpl::AppendVISACFSymbolInst(const std::string& symbolName,
                                            VISA_VectorOpnd *dst) {
   TIME_SCOPE(VISA_BUILDER_APPEND_INST);
 

visa/iga/IGALibrary/Backend/Native/InstDecoder.hpp

@@ -221,7 +221,7 @@ struct InstDecoder {
 
   ///////////////////////////////////////////
   // PRIMITIVE FIELD ADDERS
-  void addDecodedField(const Field &f, std::string meaning) {
+  void addDecodedField(const Field &f, const std::string& meaning) {
     if (fields) {
       int encodedFragments = 0;
       for (const Fragment &fr : f.fragments) {

visa/iga/IGALibrary/Backend/Native/InstEncoder.hpp

@@ -127,6 +127,7 @@ class InstEncoder : public BitProcessor {
               const Model &_model)
       : BitProcessor(_parent), opts(_opts), model(_model) {}
   InstEncoder(const InstEncoder &) = delete;
+  InstEncoder& operator=(const InstEncoder&) = delete;
 
   BackpatchList &getBackpatches() { return backpatches; }
 

visa/iga/IGALibrary/IR/Block.cpp

@@ -182,7 +182,7 @@ Block::inferBlocks(ErrorHandler &errHandler, MemManager &mem, InstList &insts) {
   bi.run(errHandler, binaryLength, insts);
 #ifdef DEBUG_BLOCKS
   TRACE_BLOCK("**********************************************\n");
-  for (auto bitr : blockStarts) {
+  for (const auto& bitr : blockStarts) {
     auto instList = bitr.second->getInstList();
     TRACE_BLOCK("BLOCK ", (int)bitr.first, " (", bitr.second, ") => ",
                 (int)instList.size(), " instrs\n");

visa/iga/IGALibrary/IR/Instruction.hpp

@@ -62,6 +62,7 @@ class Instruction {
   {
   }
   Instruction(const Instruction &) = delete;
+  Instruction& operator=(const Instruction&) = delete;
 
   // for placement allocation
   void operator delete(void *, MemManager *) {}

visa/iga/IGALibrary/InstDiff.cpp

@@ -86,7 +86,7 @@ decodeFieldsWithWarnings(const Model &model, std::ostream &os, Loc loc,
   FragmentList fields;
   ErrorHandler errHandler;
   native::DecodeFields(loc, model, (const void *)mi, fields, errHandler);
-  for (auto &e : errHandler.getErrors()) {
+  for (const auto &e : errHandler.getErrors()) {
     std::stringstream ss;
     ss << "PC" << e.at.offset << ". " << e.message << "\n";
     emitYellowText(os, ss.str());

visa/iga/IGALibrary/api/igaEncoderWrapper.cpp

@@ -24,13 +24,13 @@ iga_status_t KernelEncoder::encode(std::ostream &errStr) {
 #ifdef _DEBUG
   if (errHandler.hasErrors()) {
     // failed encode
-    for (auto &e : errHandler.getErrors()) {
+    for (const auto &e : errHandler.getErrors()) {
       errStr << "vISA inst $" << e.at.offset << ": " << e.message << "\n";
     }
     return IGA_ERROR;
   }
   if (errHandler.hasWarnings()) {
-    for (auto &w : errHandler.getWarnings()) {
+    for (const auto &w : errHandler.getWarnings()) {
       std::cerr << "line " << w.at.line << ", col " << w.at.col << ": "
                 << w.message << "\n";
     }

visa/iga/IGALibrary/api/kv.cpp

@@ -136,7 +136,7 @@ kv_t *kv_create(iga_gen_t gen_platf, const void *bytes, size_t bytes_len,
          << "\n";
     };
     if (kvImpl->m_errHandler.hasErrors()) {
-      for (auto d : kvImpl->m_errHandler.getErrors()) {
+      for (const auto& d : kvImpl->m_errHandler.getErrors()) {
         fmtDiag("ERROR", d);
       }
     }

visa/include/VISABuilderAPIDefinition.h

@@ -634,7 +634,7 @@ class VISAKernel {
   VISA_BUILDER_API virtual int
   AppendVISACFFunctionCallInst(VISA_PredOpnd *pred, VISA_EMask_Ctrl emask,
                                VISA_Exec_Size executionSize,
-                               std::string funcName, unsigned char argSize,
+                               const std::string& funcName, unsigned char argSize,
                                unsigned char returnSize) = 0;
 
   /// AppendVISACFIndirectFuncCallInst -- append an indirect function call to
@@ -650,7 +650,7 @@ class VISAKernel {
   /// into <dst> faddr symbolName dst symbolName is the unique string to
   /// identify the symbol whose address is taken dst must have UD type with
   /// scalar region
-  VISA_BUILDER_API virtual int AppendVISACFSymbolInst(std::string symbolName,
+  VISA_BUILDER_API virtual int AppendVISACFSymbolInst(const std::string& symbolName,
                                                       VISA_VectorOpnd *dst) = 0;
 
   /// AppendVISACFFunctionRetInst -- append a function return instruction to