Skip to content

Commit 3c8d8a5

Browse files
houjenkopszymich
authored andcommitted
Revert "[IGC Core] Privatize hasNoInt64Inst() (3rd attempt)"
Revert due to functional regression
1 parent c7e2357 commit 3c8d8a5

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

IGC/Compiler/CISACodeGen/CISABuilder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1548,7 +1548,7 @@ namespace IGC
15481548
bool Is64BitDst = (dstT == ISA_TYPE_Q || dstT == ISA_TYPE_UQ);
15491549
bool Is64BitSrc = (srcT == ISA_TYPE_Q || srcT == ISA_TYPE_UQ);
15501550
bool Need64BitEmu =
1551-
m_program->GetContext()->platform.need64BitEmulation() &&
1551+
m_program->GetContext()->platform.hasNoInt64Inst() &&
15521552
(Is64BitDst || Is64BitSrc);
15531553

15541554
// If DP is not supported, need to split mov as well.

IGC/Compiler/CISACodeGen/Platform.hpp

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -46,22 +46,6 @@ bool hasQWAddSupport() const
4646
m_platformInfo.usRevId >= REVISION_D); // true from PVC XT B0 RevID==0x5==REVISION_D
4747
}
4848

49-
//all the platforms which DONOT support 64 bit int operations
50-
bool hasNoInt64Inst() const {
51-
return m_platformInfo.eProductFamily == IGFX_ICELAKE_LP ||
52-
m_platformInfo.eProductFamily == IGFX_LAKEFIELD ||
53-
m_platformInfo.eProductFamily == IGFX_ELKHARTLAKE ||
54-
m_platformInfo.eProductFamily == IGFX_JASPERLAKE ||
55-
m_platformInfo.eProductFamily == IGFX_TIGERLAKE_LP ||
56-
m_platformInfo.eProductFamily == IGFX_ROCKETLAKE ||
57-
m_platformInfo.eProductFamily == IGFX_ALDERLAKE_S ||
58-
m_platformInfo.eProductFamily == IGFX_ALDERLAKE_P ||
59-
m_platformInfo.eProductFamily == IGFX_ALDERLAKE_N ||
60-
m_platformInfo.eProductFamily == IGFX_DG1 ||
61-
m_platformInfo.eProductFamily == IGFX_DG2 ||
62-
m_platformInfo.eProductFamily == IGFX_METEORLAKE;
63-
}
64-
6549
public:
6650
void setOclCaps(OCLCaps& caps) { m_OCLCaps = caps; }
6751
uint32_t getMaxOCLParameteSize() const {
@@ -1082,6 +1066,22 @@ bool supportByteALUOperation() const
10821066
return !isCoreChildOf(IGFX_XE_HPC_CORE);
10831067
}
10841068

1069+
//all the platforms which DONOT support 64 bit int operations
1070+
bool hasNoInt64Inst() const {
1071+
return m_platformInfo.eProductFamily == IGFX_ICELAKE_LP ||
1072+
m_platformInfo.eProductFamily == IGFX_LAKEFIELD ||
1073+
m_platformInfo.eProductFamily == IGFX_ELKHARTLAKE ||
1074+
m_platformInfo.eProductFamily == IGFX_JASPERLAKE ||
1075+
m_platformInfo.eProductFamily == IGFX_TIGERLAKE_LP ||
1076+
m_platformInfo.eProductFamily == IGFX_ROCKETLAKE ||
1077+
m_platformInfo.eProductFamily == IGFX_ALDERLAKE_S ||
1078+
m_platformInfo.eProductFamily == IGFX_ALDERLAKE_P ||
1079+
m_platformInfo.eProductFamily == IGFX_ALDERLAKE_N ||
1080+
m_platformInfo.eProductFamily == IGFX_DG1 ||
1081+
m_platformInfo.eProductFamily == IGFX_DG2 ||
1082+
m_platformInfo.eProductFamily == IGFX_METEORLAKE;
1083+
}
1084+
10851085
//all the platforms which DONOT support 64 bit float operations
10861086
bool hasNoFP64Inst() const {
10871087
return m_platformInfo.eProductFamily == IGFX_ICELAKE_LP ||

0 commit comments

Comments
 (0)