Klocwork Fixes

Change-Id: Id16b0aedbce2dc70bdf3d8b2cde5d50fb7245cbc

Author: juanrod2

IGC/OCLFE/igd_fcl_mcl/source/clang_tb.cpp

@@ -132,7 +132,7 @@ namespace FCL
                 }
 
                 // Just return the string
-                strncpy((char*)pValue, envVal, size);
+                strncpy_s((char*)pValue, size, envVal, size);
 
                 return true;
             }

IGC/common/igc_regkeys.cpp

@@ -32,6 +32,8 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #include "common/LLVMWarningsPop.hpp"
 #include "common/SysUtils.hpp"
 #include "3d/common/iStdLib/File.h"
+#include "secure_mem.h"
+#include "secure_string.h"
 
 #include <string>
 #include <cassert>
@@ -76,7 +78,7 @@ static bool ReadIGCEnv(
             }
 
             // Just return the string
-            strncpy( (char*)pValue, envVal, size );
+            strncpy_s( (char*)pValue, size, envVal, size );
 
             return true;
         }
@@ -232,7 +234,7 @@ static void ParseCStringVector(std::vector<char *> &OutputVector,
 
         // Everything from 0 to Pos is the next word to copy.
         char *NewStr = (char*)malloc(Pos + 1);
-        memcpy(NewStr, WorkStr.data(), Pos);
+        memcpy_s(NewStr, Pos + 1, WorkStr.data(), Pos);
         NewStr[Pos] = 0;
         OutputVector.push_back(NewStr);
 
@@ -295,7 +297,7 @@ static void setRegkeyFromOption(
         if(!vstring.empty())
         {
             char* s = (char*)pRegkeyVar;
-            strcpy(s, vstring.c_str());
+            strcpy_s(s, vstring.size(), vstring.c_str());
             isKeySet = true;
         }
     }
@@ -352,7 +354,7 @@ static void declareIGCKey(std::string& line, const char* dataType, const char* r
     setRegkeyFromOption(line, dataType, regkeyName, &value, isSet);
     if (isSet)
     {
-        memcpy(regKey->m_string, value, sizeof(value));
+        memcpy_s(regKey->m_string, sizeof(value), value, sizeof(value));
         regKey->hashes = hashes;
     }
 }
@@ -408,7 +410,7 @@ static void LoadFromRegKeyOrEnvVar()
 
         if (isSet)
         {
-            memcpy(pRegKeyVariable[i].m_string, value, sizeof(value));
+            memcpy_s(pRegKeyVariable[i].m_string, sizeof(value), value, sizeof(value));
         }
     }
 }

visa/CISA.y

@@ -1938,7 +1938,7 @@ DoubleFloat :   DOUBLEFLOAT
 
 FloatPoint :    NUMBER DOT NUMBER
                 {   char floatstring[256];
-                    sprintf(floatstring, "%" PRId64 ".%" PRId64, $1, $3);
+                    sprintf_s(floatstring, sizeof(floatstring), "%" PRId64 ".%" PRId64, $1, $3);
                     $$ = atof(floatstring);
                 }
               | FLOATINGPOINT