Skip to content

Commit 533fe1b

Browse files
dlei6gigcbot
authored andcommitted
Re-enable FunctionCloningThreshold for ZeBin (Try #3)
FunctionCloningThreshold was disabled due to regressions on ZeBin enabling. Re-enable again after fixes for: * Implicit Arg bug for LocalID * Incorrect vISA scratch space calculation for indirect calls
1 parent b8e94a9 commit 533fe1b

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

IGC/Compiler/CISACodeGen/GenCodeGenModule.cpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -413,13 +413,11 @@ bool GenXCodeGenModule::runOnModule(Module& M)
413413
// function groups can be cloned. If the number exceeds the threshold, instead of cloning the
414414
// function N times, make it an indirect call and use relocation instead. The function will only be
415415
// compiled once and runtime must relocate its address for each caller.
416-
// TODO: For zebin path m_FunctionCloningThreshold should be enabled.
417-
// Temporary disabled, because it causing functional regressions
418-
//if (getAnalysis<CodeGenContextWrapper>().getCodeGenContext()->enableZEBinary())
419-
//{
420-
// // Enable by default for zebin
421-
// m_FunctionCloningThreshold = 1;
422-
//}
416+
if (getAnalysis<CodeGenContextWrapper>().getCodeGenContext()->enableZEBinary())
417+
{
418+
// Enable by default for zebin
419+
m_FunctionCloningThreshold = 1;
420+
}
423421
if (IGC_GET_FLAG_VALUE(FunctionCloningThreshold) != 0)
424422
{
425423
// Overwrite with debug flag

0 commit comments

Comments
 (0)