Skip to content

Commit 535c477

Browse files
traoux1gfxbot
authored andcommitted
Remove restriction preventing private memory layout to be
interleaved for OCL. All bugs should be fixed Change-Id: I82c3646dd14b8d7261cc04f3d337708742bb9db8
1 parent 3cb9b68 commit 535c477

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

IGC/AdaptorOCL/DriverInfoOCL.hpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,6 @@ namespace TC
4747
bool HasMemoryIntrinsics() const override { return true; }
4848

4949
bool HasNonNativeLoadStore() const override { return true; }
50-
51-
// WA for failure when transposing private memory
52-
bool SupportTransposeLayoutForPrivateMemory() const override { return false; }
5350

5451
bool NeedLoweringInlinedConstants() const override { return true; }
5552
bool benefitFromTypeDemotion() const override { return true; }

IGC/Compiler/CISACodeGen/DriverInfo.hpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,6 @@ class CDriverInfo
122122
/// Has load store not natively supported
123123
virtual bool HasNonNativeLoadStore() const { return false; }
124124

125-
/// Enable transposing private memory for better access pattern. Causes failures in some APIs
126-
virtual bool SupportTransposeLayoutForPrivateMemory() const { return true; }
127-
128125
/// Need lowering global inlined constant buffers
129126
virtual bool NeedLoweringInlinedConstants() const { return false; }
130127

IGC/Compiler/Optimizer/OpenCLPasses/PrivateMemory/PrivateMemoryResolution.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -815,8 +815,7 @@ bool PrivateMemoryResolution::resolveAllocaInstuctions(bool stackCall)
815815

816816
// If we can use SOA layout transpose the memory
817817
Type* pTypeOfAccessedObject = nullptr;
818-
bool TransposeMemLayout = CanUseSOALayout(pAI, pTypeOfAccessedObject) &&
819-
Ctx.m_DriverInfo.SupportTransposeLayoutForPrivateMemory(); // remove this check in next step
818+
bool TransposeMemLayout = CanUseSOALayout(pAI, pTypeOfAccessedObject);
820819

821820
unsigned int bufferSize = 0;
822821
if (TransposeMemLayout)

0 commit comments

Comments
 (0)