Skip to content

Commit 557b7b9

Browse files
wenju-heigcbot
authored andcommitted
Change 3D SYCL bindless image builtins to 3-component coordinates
intel/llvm#12581 changed 3D SYCL bindless image functions to accept 3-component coordinate instead of 4-component. The change causes unresolved builtin in IGC. Therefore, this PR makes the same change to 3D image builtins.
1 parent 90944b0 commit 557b7b9

File tree

3 files changed

+237
-85
lines changed

3 files changed

+237
-85
lines changed

IGC/BiFModule/Implementation/IGCBiF_Intrinsics.cl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,38 +41,38 @@ float4 __builtin_IB_OCL_1d_sample_l(int, int, float, float);
4141
float4 __builtin_IB_OCL_1darr_sample_l(int, int, float2, float);
4242
float4 __builtin_IB_OCL_2d_sample_l(int, int, float2, float);
4343
float4 __builtin_IB_OCL_2darr_sample_l(int, int, float4, float);
44-
float4 __builtin_IB_OCL_3d_sample_l(int, int, float4, float);
44+
float4 __builtin_IB_OCL_3d_sample_l(int, int, float3, float);
4545

4646
float4 __builtin_IB_OCL_1d_sample_d(int, int, float, float, float);
4747
float4 __builtin_IB_OCL_1darr_sample_d(int, int, float2, float, float);
4848
float4 __builtin_IB_OCL_2d_sample_d(int, int, float2, float2, float2);
4949
float4 __builtin_IB_OCL_2darr_sample_d(int, int, float4, float2, float2);
50-
float4 __builtin_IB_OCL_3d_sample_d(int, int, float4, float4, float4);
50+
float4 __builtin_IB_OCL_3d_sample_d(int, int, float3, float4, float4);
5151

5252
// versions that return uint for read_imageui
5353
uint4 __builtin_IB_OCL_1d_sample_lui(int, int, float, float);
5454
uint4 __builtin_IB_OCL_1darr_sample_lui(int, int, float2, float);
5555
uint4 __builtin_IB_OCL_2d_sample_lui(int, int, float2, float);
5656
uint4 __builtin_IB_OCL_2darr_sample_lui(int, int, float4, float);
57-
uint4 __builtin_IB_OCL_3d_sample_lui(int, int, float4, float);
57+
uint4 __builtin_IB_OCL_3d_sample_lui(int, int, float3, float);
5858

5959
uint4 __builtin_IB_OCL_1d_sample_dui(int, int, float, float, float);
6060
uint4 __builtin_IB_OCL_1darr_sample_dui(int, int, float2, float, float);
6161
uint4 __builtin_IB_OCL_2d_sample_dui(int, int, float2, float2, float2);
6262
uint4 __builtin_IB_OCL_2darr_sample_dui(int, int, float4, float2, float2);
63-
uint4 __builtin_IB_OCL_3d_sample_dui(int, int, float4, float4, float4);
63+
uint4 __builtin_IB_OCL_3d_sample_dui(int, int, float3, float4, float4);
6464

6565
uint4 __builtin_IB_OCL_1d_ldui(int, int, int);
6666
uint4 __builtin_IB_OCL_1darr_ldui(int, int2, int);
6767
uint4 __builtin_IB_OCL_2d_ldui(int, int2, int);
6868
uint4 __builtin_IB_OCL_2darr_ldui(int, int4, int);
69-
uint4 __builtin_IB_OCL_3d_ldui(int, int4, int);
69+
uint4 __builtin_IB_OCL_3d_ldui(int, int3, int);
7070

7171
float4 __builtin_IB_OCL_1d_ld(int, int, int);
7272
float4 __builtin_IB_OCL_1darr_ld(int, int2, int);
7373
float4 __builtin_IB_OCL_2d_ld(int, int2, int);
7474
float4 __builtin_IB_OCL_2darr_ld(int, int4, int);
75-
float4 __builtin_IB_OCL_3d_ld(int, int4, int);
75+
float4 __builtin_IB_OCL_3d_ld(int, int3, int);
7676

7777
float4 __builtin_IB_OCL_2d_ldmcs(int, int2);
7878
float4 __builtin_IB_OCL_2darr_ldmcs(int, int4);
@@ -94,7 +94,7 @@ void __builtin_IB_write_1darr_ui(int, int2, uint4, int);
9494
void __builtin_IB_write_1d_ui(int, int, uint4, int);
9595
void __builtin_IB_write_2darr_ui(int, int4, uint4, int);
9696
void __builtin_IB_write_2d_ui(int, int2, uint4, int);
97-
void __builtin_IB_write_3d_ui(int, int4, uint4, int);
97+
void __builtin_IB_write_3d_ui(int, int3, uint4, int);
9898
void __builtin_IB_write_2darr_f(int, int4, float4, int);
9999
void __builtin_IB_write_2d_f(int, int2, float4, int);
100100

0 commit comments

Comments
 (0)