Skip to content

Commit 572965e

Browse files
DianaChenigcbot
authored andcommitted
IGA: Updated -Xprint-deps for dpas
Updated RegSet::addDpasOperand for general cases.
1 parent 2d2aebf commit 572965e

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

visa/iga/IGALibrary/IR/RegSet.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -333,15 +333,15 @@ bool RegSet::addDpasOperand(const Instruction &i, int opIx) {
333333
} else if (opIx == 1) { // src1
334334
size_t bitsAccessed = execSize * typeSizeBits * opsPerChannel * S;
335335
changed |= add(RegName::GRF_R, startOff, bitsAccessed);
336-
} else { // src2
337-
// this is a little subtle
338-
// given bit precisions a src2 operand can stride across the
339-
// bottom or top of a GRF without touching the other half
340-
//
341-
// e.g. dpas.4x2 (8) r24.0:d r24.0:d r6.0:u2 r14.32:u4
342-
// src2 - touches r14[16-31] and r15[16-31]
343-
//
344-
// TODO: can something like this happen for src1
336+
} else if (opIx == 2) { // src2
337+
// this is a little subtle
338+
// given bit precisions a src2 operand can stride across the
339+
// bottom or top of a GRF without touching the other half
340+
//
341+
// e.g. dpas.4x2 (8) r24.0:d r24.0:d r6.0:u2 r14.32:u4
342+
// src2 - touches r14[16-31] and r15[16-31]
343+
//
344+
// TODO: can something like this happen for src1
345345
for (size_t r = 0; r < R; r++) {
346346
size_t startSubReg = r * opsPerChannel * typeSizeBits * 8;
347347
size_t repReads = S * opsPerChannel * typeSizeBits;

0 commit comments

Comments
 (0)