Skip to content

Commit 588adf8

Browse files
trbauerigcbot
authored andcommitted
minor doc cleanup
minor doc edit
1 parent dee6540 commit 588adf8

File tree

3 files changed

+0
-17
lines changed

3 files changed

+0
-17
lines changed

visa/HWConformity.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9394,7 +9394,6 @@ bool HWConformity::fixSrnd(INST_LIST_ITER it, G4_BB* bb)
93949394
// case 1. src0 cannot be imm.
93959395
// case 2. subreg must be zero (must be grf-aligned)
93969396
// case 3. For HF->BF8, both dst and src must be packed
9397-
// srnd: https://gfxspecs.intel.com/Predator/Home/Index/67451
93989397
G4_DstRegRegion* dst = inst->getDst();
93999398
uint32_t execsize = inst->getExecSize();
94009399
bool Packed = (dst->getType() == Type_UB);

visa/VisaToG4/TranslateSendLdStLsc.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,6 @@ static int lscBlock2dComputeDataRegs(
8383
return n;
8484
};
8585

86-
// this comes out of the HAS (1408569497)
87-
// non-transpose
88-
// 5.1.2.3 non-vnni (HAS pg. 8)
89-
// 5.1.1.2 vnni (pg.13) perversely, this comes after 5.1.2.3 in the doc
90-
// transpose
91-
// 5.1.3.2 non-vnni (HAS pg. 10)
92-
// 5.1.2.2 vnni (HAS pg. 15)
9386
bool transpose = dataShape2d.order == LSC_DATA_ORDER_TRANSPOSE;
9487
int grfRowPitchElems =
9588
roundUpToPowerOf2(!transpose ? dataShape2d.width : dataShape2d.height);
@@ -102,7 +95,6 @@ static int lscBlock2dComputeDataRegs(
10295
//
10396
int dataRegs = dataShape2d.blocks*regsPerBlock;
10497
// C.f. DP_LOAD_2DBLOCK_ARRAY
105-
// https://gfxspecs.intel.com/Predator/Home/Index/53680
10698
//
10799
// Data payload size, in registers. Destination length of 32 is
108100
// encoded as 31. Data port hardware derives the correct destination
@@ -202,7 +194,6 @@ int IR_Builder::translateLscUntypedInst(
202194
desc |= opInfo.encoding; // Desc[5:0]
203195

204196
// build the descriptor (Sect. 3.3.1 of the HAS)
205-
// (also https://gfxspecs.intel.com/Predator/Home/Index/53522)
206197
//
207198
// Desc[5:0] = OPCODE {LOAD,STORE,LOAD_BLOCK,STORE_BLOCK,...}
208199
// Desc[8:7] = addr size
@@ -1039,7 +1030,6 @@ G4_SrcRegRegion *IR_Builder::lscBuildBlock2DPayload(
10391030
// Similar to lscBuildStridedPayload, but this formats the payload
10401031
// as follows.
10411032
//
1042-
// https://gfxspecs.intel.com/Predator/Home/Index/53567
10431033
// A2DBLOCK_PAYLOAD:
10441034
// [31:0]: base address lo (32b)
10451035
// [63:32]: base address hi (32b)

visa/iga/IGALibrary/Backend/Messages/MessageDecoderHDC.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ static const char *MDC_DS_MEANINGS[] {
1717
"DE8 (8 data elements per address)",
1818
};
1919

20-
21-
// https://gfxspecs.intel.com/Predator/Home/Index/44782
22-
// https://gfxspecs.intel.com/Predator/Home/Index/44783
23-
// https://gfxspecs.intel.com/Predator/Home/Index/44785
2420
using HDCOpcode = uint32_t;
2521
enum DC0 : uint32_t {
2622
/////////////////////////////////////////
@@ -836,7 +832,6 @@ struct MessageDecoderHDC : MessageDecoderLegacy {
836832

837833

838834
// Enum of all DCRO ops
839-
// https://gfxspecs.intel.com/Predator/Home/Index/44785
840835
enum DCRO_MT {
841836
MT_CC_OWB = 0x00,
842837
MT_CC_OWAB = 0x01,
@@ -1028,7 +1023,6 @@ void MessageDecoderHDC::tryDecodeDCRO() {
10281023
}
10291024
}
10301025

1031-
// XE: DC0 https://gfxspecs.intel.com/Predator/Home/Index/44782
10321026
void MessageDecoderHDC::tryDecodeDC0()
10331027
{
10341028
const int msgType = getDescBits(14, 5);

0 commit comments

Comments
 (0)