Coverity fixes and refactors

Initialize uninitialized variables.
Use cast instead of dyn_cast.

Author: fda0

IGC/Compiler/CISACodeGen/OpenCLOptions.cpp

@@ -524,12 +524,12 @@ void Options::parseOptions(const char* opts)
         }
     }
 
-    for (auto arg : apiOptions.getAllArgValues(OPT_large_grf_kernel_common))
+    for (const auto& arg : apiOptions.getAllArgValues(OPT_large_grf_kernel_common))
     {
         LargeGRFKernels.push_back(arg);
     }
 
-    for (auto arg : apiOptions.getAllArgValues(OPT_regular_grf_kernel_common))
+    for (const auto& arg : apiOptions.getAllArgValues(OPT_regular_grf_kernel_common))
     {
         RegularGRFKernels.push_back(arg);
     }

IGC/Compiler/Optimizer/OpenCLPasses/BufferBoundsChecking/BufferBoundsChecking.cpp

@@ -42,8 +42,7 @@ IGC_INITIALIZE_PASS_END(BufferBoundsChecking, PASS_FLAG, PASS_DESCRIPTION, PASS_
 
 char BufferBoundsChecking::ID = 0;
 
-BufferBoundsChecking::BufferBoundsChecking()
-    : ModulePass(ID), modified(false), kernelArgs(nullptr), bufferSizePlaceholderFunction(nullptr)
+BufferBoundsChecking::BufferBoundsChecking() : ModulePass(ID)
 {
     initializeBufferBoundsCheckingPass(*PassRegistry::getPassRegistry());
 }

IGC/Compiler/Optimizer/OpenCLPasses/BufferBoundsChecking/BufferBoundsChecking.hpp

@@ -59,16 +59,16 @@ namespace IGC
             llvm::Value* elementSizeInBytes;
         };
 
-        bool modified;
+        bool modified = false;
 
-        IGCMD::MetaDataUtils* metadataUtils;
-        ModuleMetaData* moduleMetadata;
-        ImplicitArgs* implicitArgs;
-        KernelArgs* kernelArgs;
+        IGCMD::MetaDataUtils* metadataUtils = nullptr;
+        ModuleMetaData* moduleMetadata = nullptr;
+        ImplicitArgs* implicitArgs = nullptr;
+        KernelArgs* kernelArgs = nullptr;
         llvm::SmallVector<llvm::Instruction*, 4> loadsAndStoresToCheck;
         llvm::DenseMap<llvm::StringRef, llvm::GlobalVariable*> stringsCache;
-        llvm::DICompileUnit* compileUnit;
-        llvm::Function* bufferSizePlaceholderFunction;
+        llvm::DICompileUnit* compileUnit = nullptr;
+        llvm::Function* bufferSizePlaceholderFunction = nullptr;
 
         void handleLoadStore(llvm::Instruction* instruction);
 

IGC/Compiler/Optimizer/OpenCLPasses/BufferBoundsChecking/BufferBoundsCheckingPatcher.cpp

@@ -69,7 +69,7 @@ bool BufferBoundsCheckingPatcher::runOnModule(Module& M)
                     continue;
                 }
 
-                auto bufferSize = getBufferSizeArg(call->getFunction(), (uint32_t)dyn_cast<ConstantInt>(call->getArgOperand(0))->getSExtValue());
+                auto bufferSize = getBufferSizeArg(call->getFunction(), (uint32_t)cast<ConstantInt>(call->getArgOperand(0))->getSExtValue());
                 //auto bufferSize = ConstantInt::get(Type::getInt64Ty(call->getContext()), 64); // Only for testing purposes
                 call->replaceAllUsesWith(bufferSize);
                 toRemove.push_back(call);

IGC/Compiler/Optimizer/OpenCLPasses/BufferBoundsChecking/BufferBoundsCheckingPatcher.hpp

@@ -44,8 +44,8 @@ namespace IGC
         void visitCallInst(llvm::CallInst& icmp);
 
     private:
-        ImplicitArgs* implicitArgs;
-        IGCMD::MetaDataUtils* metadataUtils;
+        ImplicitArgs* implicitArgs = nullptr;
+        IGCMD::MetaDataUtils* metadataUtils = nullptr;
         llvm::SmallVector<llvm::CallInst*, 8> toRemove;
 
         llvm::Argument* getBufferSizeArg(llvm::Function* function, uint32_t n);

visa/LocalScheduler/SWSB_G4IR.h

@@ -621,7 +621,7 @@ class G4_BB_SB {
   // TODO: May want to change these to use llvm allocator as well.
   vISA::Mem_Manager &mem;
   G4_BB *bb;
-  G4_Label *BBLabel;
+  G4_Label *BBLabel = nullptr;
   int nodeID;
   int ALUID;
 
@@ -641,7 +641,7 @@ class G4_BB_SB {
   unsigned short getDpasSrcCacheSize(Gen4_Operand_Number opNum) const;
 
 public:
-  LiveGRFBuckets *send_use_kills;
+  LiveGRFBuckets *send_use_kills = nullptr;
   BB_SWSB_LIST Preds;
   BB_SWSB_LIST Succs;
 
@@ -680,8 +680,8 @@ class G4_BB_SB {
   std::vector<BitSet> tokeNodesMap;
   int first_DPASID = 0;
   int last_DPASID = 0;
-  unsigned *tokenLiveInDist;
-  unsigned *tokenLiveOutDist;
+  unsigned *tokenLiveInDist = nullptr;
+  unsigned *tokenLiveOutDist = nullptr;
   SBBitSets localReachingSends;
   SBBitSets
       BBGRF; // Is used to record the GRF registers accessed by each basic block