Allow VISA modifiers for indirect source operands

Allow VISA modifiers for indirect source operands

Author: jaladreips

IGC/Compiler/CISACodeGen/CISABuilder.cpp

@@ -929,7 +929,7 @@ namespace IGC
                     V(vKernel->CreateVISAIndirectSrcOperand(
                         operand,
                         var->visaAddrVariable,
-                        MODIFIER_NONE,
+                        ConvertModifierToVisaType(mod.mod),
                         0,
                         immOffset,
                         vStride,
@@ -949,7 +949,7 @@ namespace IGC
                     V(vKernel->CreateVISAIndirectSrcOperand(
                         operand,
                         var->visaAddrVariable,
-                        MODIFIER_NONE,
+                        ConvertModifierToVisaType(mod.mod),
                         0,
                         immOffset,
                         vStride,
@@ -965,6 +965,7 @@ namespace IGC
                     V(vKernel->CreateVISAIndirectOperandVxH(
                         operand,
                         var->visaAddrVariable,
+                        ConvertModifierToVisaType(mod.mod),
                         mod.subReg,
                         0,
                         var->GetType()));

visa/VISAKernel.h

@@ -304,6 +304,7 @@ class VISAKernelImpl : public VISAFunction {
 
   VISA_BUILDER_API int CreateVISAIndirectOperandVxH(VISA_VectorOpnd *&cisa_opnd,
                                                     VISA_AddrVar *decl,
+                                                    VISA_Modifier mod,
                                                     unsigned int addrOffset,
                                                     short immediateOffset,
                                                     VISA_Type type) override;

visa/VISAKernelImpl.cpp

@@ -1950,10 +1950,11 @@ int VISAKernelImpl::CreateVISAIndirectDstOperand(
 
 int VISAKernelImpl::CreateVISAIndirectOperandVxH(VISA_VectorOpnd *&cisa_opnd,
                                                  VISA_AddrVar *decl,
+                                                 VISA_Modifier mod,
                                                  unsigned int addrOffset,
                                                  short immediateOffset,
                                                  VISA_Type type) {
-  return CreateVISAIndirectGeneralOperand(cisa_opnd, decl, MODIFIER_NONE,
+  return CreateVISAIndirectGeneralOperand(cisa_opnd, decl, mod,
                                           addrOffset, immediateOffset, -1, 1, 0,
                                           type, false);
 }

visa/include/VISABuilderAPIDefinition.h

@@ -222,12 +222,13 @@ class VISAKernel {
                                VISA_Type type) = 0;
 
   /// CreateVISAIndirectOperandVxH -- create a vISA indirect source operand with
-  /// multiple addresses (r[A_N(addrOffset), immedOffset]<1,0>:type) addrOffset
-  /// is in number of elements immedOffset is in byte and must be [-512, 511]
+  /// multiple addresses (r[A_N(addrOffset), immedOffset]<1,0>:type) mod is the
+  /// source modifier addrOffset is in number of elements
+  /// immedOffset is in byte and must be [-512, 511]
   VISA_BUILDER_API virtual int
   CreateVISAIndirectOperandVxH(VISA_VectorOpnd *&cisa_opnd, VISA_AddrVar *decl,
-                               unsigned int addrOffset, short immediateOffset,
-                               VISA_Type type) = 0;
+                               VISA_Modifier mod, unsigned int addrOffset,
+                               short immediateOffset, VISA_Type type) = 0;
 
   /// CreateVISAPredicateOperand -- create a vISA predicate operand that can be
   /// used for predicated execution