Skip to content

Commit 7ce55d8

Browse files
jgu222igcbot
authored andcommitted
Rename 'execSize' to 'numElts'
As 'execSize' in PayloadSource actually is the number of elements of a MSG payload for that given payload source operand, change the name to reflect that to avoid misunderstanding.
1 parent 0f0b730 commit 7ce55d8

File tree

4 files changed

+55
-55
lines changed

4 files changed

+55
-55
lines changed

visa/BuildIR.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1856,7 +1856,7 @@ class IR_Builder
18561856

18571857
struct PayloadSource {
18581858
G4_SrcRegRegion *opnd;
1859-
G4_ExecSize execSize;
1859+
uint32_t numElts; // 'opnd's size in msg payload
18601860
G4_InstOpts instOpt;
18611861
};
18621862

visa/VisaToG4/TranslateMisc.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -134,17 +134,17 @@ static void CopySrcToMsgPayload(
134134
}
135135

136136
static void Copy_Source_To_Payload(
137-
IR_Builder *IRB, G4_ExecSize batchExSize,
138-
G4_Declare *msg, unsigned &regOff,
139-
G4_SrcRegRegion *source, G4_ExecSize execSize,
137+
IR_Builder* IRB, G4_ExecSize batchExSize,
138+
G4_Declare* msg, unsigned& regOff,
139+
G4_SrcRegRegion* source, uint32_t numElts,
140140
uint32_t eMask)
141141
{
142142
ASSERT_USER(batchExSize == 1 || batchExSize == 2 || batchExSize == 4 ||
143143
batchExSize == 8 || batchExSize == 16 || batchExSize == 32,
144144
"Invalid execution size for message payload copy!");
145145

146146
unsigned srcRegOff = 0;
147-
G4_ExecSize batchSize = std::min(batchExSize, execSize);
147+
G4_ExecSize batchSize { std::min((uint32_t)batchExSize, numElts) };
148148
uint32_t numSrcRegs = (source->getElemSize() * batchSize) / IRB->getGRFSize();
149149
if (numSrcRegs == 0)
150150
{
@@ -165,13 +165,13 @@ static void Copy_Source_To_Payload(
165165
msg, regOff, source, srcRegOff);
166166
}
167167
// regOff : need to advance to the next payload grf
168-
// This payload takes this size: execSize * source->getElemSize()
169-
uint32_t numPayloadRegs = (source->getElemSize() * execSize) / IRB->getGRFSize();
168+
// This payload takes this size: numElts * source->getElemSize()
169+
uint32_t numPayloadRegs = (source->getElemSize() * numElts) / IRB->getGRFSize();
170170
regOff += (numPayloadRegs == 0 ? 1 : numPayloadRegs);
171171
return;
172172
}
173173

174-
for (unsigned i = 0; i < execSize; i += batchSize) {
174+
for (unsigned i = 0; i < numElts; i += batchSize) {
175175
if (!source->isNullReg()) {
176176
CopySrcToMsgPayload(IRB, batchSize, eMask,
177177
msg, regOff, source, srcRegOff);
@@ -210,7 +210,7 @@ void IR_Builder::preparePayload(
210210

211211
// this is the size of message payload that holds srcReg.
212212
// (Thus, this size >= srcReg's size!)
213-
unsigned regionSize = srcs[i].execSize * srcReg->getTypeSize();
213+
unsigned regionSize = srcs[i].numElts * srcReg->getTypeSize();
214214

215215
if (regionSize < getGRFSize()) {
216216
// FIXME: Need a better solution to decouple the value type from
@@ -286,7 +286,7 @@ void IR_Builder::preparePayload(
286286
// Count remaining message size.
287287
for (; i != len; ++i) {
288288
G4_SrcRegRegion *srcReg = srcs[i].opnd;
289-
unsigned regionSize = srcs[i].execSize * srcReg->getTypeSize();
289+
unsigned regionSize = srcs[i].numElts * srcReg->getTypeSize();
290290
if (regionSize < getGRFSize()) {
291291
// FIXME: Need a better solution to decouple the value type from
292292
// the container type to generate better COPY if required.
@@ -305,7 +305,7 @@ void IR_Builder::preparePayload(
305305
for (i = splitPos; i != len; ++i)
306306
{
307307
Copy_Source_To_Payload(this, batchExSize, msg, regOff, srcs[i].opnd,
308-
srcs[i].execSize, srcs[i].instOpt);
308+
srcs[i].numElts, srcs[i].instOpt);
309309
}
310310

311311
i = 0;

visa/VisaToG4/TranslateSend3D.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1911,7 +1911,7 @@ int IR_Builder::translateVISASampler3DInst(
19111911
// Collect header if present.
19121912
if (header) {
19131913
sources[i].opnd = header;
1914-
sources[i].execSize = g4::SIMD8;
1914+
sources[i].numElts = g4::SIMD8;
19151915
sources[i].instOpt = InstOpt_WriteEnable | dbgOpt;
19161916
++i;
19171917
}
@@ -1920,7 +1920,7 @@ int IR_Builder::translateVISASampler3DInst(
19201920
unsigned uPos = needNoMask ? getUPosition(actualop) : ~0u;
19211921
for (unsigned j = 0; j != numParms; ++j) {
19221922
sources[i].opnd = params[j];
1923-
sources[i].execSize = execSize;
1923+
sources[i].numElts = execSize;
19241924
sources[i].instOpt = (needNoMask && (uPos <= j && j < (uPos + 3))) ?
19251925
InstOpt_WriteEnable | dbgOpt : instOpt | dbgOpt;
19261926
++i;
@@ -2036,7 +2036,7 @@ int IR_Builder::translateVISALoad3DInst(
20362036
// Collect header if present.
20372037
if (header) {
20382038
sources[i].opnd = header;
2039-
sources[i].execSize = g4::SIMD8;
2039+
sources[i].numElts = g4::SIMD8;
20402040
sources[i].instOpt = InstOpt_WriteEnable;
20412041
++i;
20422042
}
@@ -2045,7 +2045,7 @@ int IR_Builder::translateVISALoad3DInst(
20452045
unsigned uPos = needNoMask ? getUPosition(actualop) : ~0u;
20462046
for (unsigned j = 0; j != numParms; ++j) {
20472047
sources[i].opnd = opndArray[j];
2048-
sources[i].execSize = execSize;
2048+
sources[i].numElts = execSize;
20492049
sources[i].instOpt = (needNoMask && (uPos <= j && j < (uPos + 3))) ?
20502050
InstOpt_WriteEnable : instOpt;
20512051
++i;
@@ -2165,7 +2165,7 @@ int IR_Builder::translateVISAGather3dInst(
21652165
// Collect header if present.
21662166
if (header) {
21672167
sources[i].opnd = header;
2168-
sources[i].execSize = g4::SIMD8;
2168+
sources[i].numElts = g4::SIMD8;
21692169
sources[i].instOpt = InstOpt_WriteEnable;
21702170
++i;
21712171
}
@@ -2174,7 +2174,7 @@ int IR_Builder::translateVISAGather3dInst(
21742174
unsigned uPos = needNoMask ? getUPosition(actualop) : ~0u;
21752175
for (unsigned j = 0; j != numOpnds; ++j) {
21762176
sources[i].opnd = opndArray[j];
2177-
sources[i].execSize = execSize;
2177+
sources[i].numElts = execSize;
21782178
sources[i].instOpt = (needNoMask && (uPos <= j && j < (uPos + 3))) ?
21792179
InstOpt_WriteEnable : instOpt;
21802180
++i;

0 commit comments

Comments
 (0)