Removing BoolOpPattern

This change is to remove BoolOpPattern which seems to be redundant because of vISA optimizations to reuse registers.

Author: krystian-andrzejewski

IGC/Compiler/CISACodeGen/EmitVISAPass.cpp

@@ -15643,21 +15643,6 @@ void EmitPass::emitAtomicCounter(llvm::GenIntrinsicInst* pInsn)
     m_currShader->isMessageTargetDataCacheDataPort = true;
 }
 
-void EmitPass::CmpBoolOp(Pattern* cmpPattern,
-    llvm::BinaryOperator* inst,
-    const SSource& bitSource,
-    const DstModifier& modifier)
-{
-    DstModifier init;
-    cmpPattern->Emit(this, init);
-
-    IGC_ASSERT(bitSource.mod == EMOD_NONE);
-    CVariable* boolOpSource = GetSrcVariable(bitSource);
-    m_encoder->SetDstModifier(modifier);
-
-    EmitSimpleAlu(inst, m_destination, m_destination, boolOpSource);
-}
-
 void EmitPass::emitAluConditionMod(Pattern* aluPattern, Instruction* alu, CmpInst* cmp, int aluOprdNum)
 {
     CVariable* temp = m_currShader->GetNewVector(alu);

IGC/Compiler/CISACodeGen/EmitVISAPass.hpp

@@ -114,10 +114,6 @@ class EmitPass : public llvm::FunctionPass
     void Alu(e_opcode opCode, const SSource sources[N], const DstModifier& modifier);
 
     void BinaryUnary(llvm::Instruction* inst, const  SSource source[2], const DstModifier& modifier);
-    void CmpBoolOp(Pattern* cmpPattern,
-        llvm::BinaryOperator* inst,
-        const SSource& bitSource,
-        const DstModifier& modifier);
     void emitAluConditionMod(Pattern* aluPattern, llvm::Instruction* alu, llvm::CmpInst* cmp, int aluOprdNum);
 
     void EmitGenericPointersCmp(llvm::Instruction* inst, const SSource source[2], const DstModifier& modifier, uint8_t clearTagMask);

IGC/Compiler/CISACodeGen/PatternMatchPass.cpp

@@ -1207,13 +1207,11 @@ namespace IGC
         case Instruction::And:
             match =
                 MatchBfn(I) ||
-                MatchBoolOp(I) ||
                 MatchLogicAlu(I);
             break;
         case Instruction::Or:
             match =
                 MatchBfn(I) ||
-                MatchBoolOp(I) ||
                 MatchLogicAlu(I);
             break;
         case Instruction::Xor:
@@ -3998,47 +3996,6 @@ namespace IGC
         return found;
     }
 
-    // we match the following pattern
-    // %f = cmp %1 %2
-    // %o = or/and %f %g
-    bool CodeGenPatternMatch::MatchBoolOp(llvm::BinaryOperator& I)
-    {
-        struct BoolOpPattern : public Pattern
-        {
-            Pattern* cmpPattern;
-            llvm::BinaryOperator* boolOp;
-            SSource binarySource;
-            virtual void Emit(EmitPass* pass, const DstModifier& modifier)
-            {
-                pass->CmpBoolOp(cmpPattern, boolOp, binarySource, modifier);
-            }
-        };
-
-        IGC_ASSERT(I.getOpcode() == Instruction::Or || I.getOpcode() == Instruction::And);
-        bool found = false;
-        if (I.getType()->isIntegerTy(1))
-        {
-            for (uint i = 0; i < 2; i++)
-            {
-                if (CmpInst * cmp = llvm::dyn_cast<CmpInst>(I.getOperand(i)))
-                {
-                    // only beneficial if the other operand only have one use
-                    if (I.getOperand(1 - i)->hasOneUse())
-                    {
-                        BoolOpPattern* pattern = new (m_allocator) BoolOpPattern();
-                        pattern->cmpPattern = Match(*cmp);
-                        pattern->boolOp = &I;
-                        pattern->binarySource = GetSource(I.getOperand(1 - i), false, false, IsSourceOfSample(&I));
-                        AddPattern(pattern);
-                        found = true;
-                        break;
-                    }
-                }
-            }
-        }
-        return found;
-    }
-
     bool CodeGenPatternMatch::MatchFunnelShiftRotate(llvm::IntrinsicInst& I)
     {
         // Hanlde only funnel shift that can be turned into rotate.