Conform to rule of three

Delete destructors or delete copy constructors and
copy assignment operators to conform to rule of three.
User defined a special function (copy constructor,
copy assignment operator, destructor).
If one of these functions requires a user-definition then
it is likely all of them should have a definition.
To avoid erroneous copies and leaked resources we delete
copy constructors that shouldn't be used.

Author: fda0

IGC/AdaptorOCL/CLElfLib/ElfReader.h

@@ -105,6 +105,8 @@ class RAIIElf
 public:
   explicit RAIIElf(CElfReader *pElf);
   ~RAIIElf();
+  RAIIElf(const RAIIElf&) = delete;
+  RAIIElf& operator=(const RAIIElf&) = delete;
 private:
   CElfReader *p;
 };

IGC/Compiler/CISACodeGen/CShaderProgram.hpp

@@ -28,6 +28,8 @@ namespace IGC
         typedef llvm::MapVector<llvm::Function*, CShaderProgram*> KernelShaderMap;
         CShaderProgram(CodeGenContext* ctx, llvm::Function* kernel);
         ~CShaderProgram();
+        CShaderProgram(const CShaderProgram&) = delete;
+        CShaderProgram& operator=(const CShaderProgram&) = delete;
         CShader* GetOrCreateShader(SIMDMode simd, ShaderDispatchMode mode = ShaderDispatchMode::NOT_APPLICABLE);
         CShader* GetShader(SIMDMode simd, ShaderDispatchMode mode = ShaderDispatchMode::NOT_APPLICABLE);
         void DeleteShader(SIMDMode simd, ShaderDispatchMode mode = ShaderDispatchMode::NOT_APPLICABLE);

IGC/Compiler/CISACodeGen/helper.h

@@ -587,6 +587,8 @@ namespace IGC
     struct Defer
     {
         Defer(Fn F) : F(F) {}
+        Defer(const Defer&) = delete;
+        Defer& operator=(const Defer&) = delete;
         ~Defer() {
             if (Do) F();
         }

IGC/Compiler/CodeGenContextWrapper.cpp

@@ -37,9 +37,6 @@ CodeGenContextWrapper::CodeGenContextWrapper() : ImmutablePass(ID), m_ctx(nullpt
     IGC_ASSERT_MESSAGE(0, "CodeGenContextWrapper shouldn't get here in runtime");
 }
 
-CodeGenContextWrapper::~CodeGenContextWrapper()
-{
-}
 CodeGenContext* CodeGenContextWrapper::getCodeGenContext()
 {
     return m_ctx;

IGC/Compiler/CodeGenContextWrapper.hpp

@@ -36,7 +36,6 @@ namespace IGC
         // Constructs a wrapper to the given CodeGenContext instance.
         CodeGenContextWrapper(CodeGenContext* pCtx);
         CodeGenContextWrapper();
-        ~CodeGenContextWrapper();
 
         // return the Context
         CodeGenContext* getCodeGenContext();

IGC/Compiler/CustomLoopOpt.hpp

@@ -97,7 +97,6 @@ namespace IGC
         static char ID;
 
         CustomLoopVersioning();
-        ~CustomLoopVersioning() { }
 
         void getAnalysisUsage(llvm::AnalysisUsage& AU) const
         {

IGC/Compiler/CustomSafeOptPass.cpp

@@ -6487,7 +6487,7 @@ bool SinkLoadOpt::sinkLoadInstruction(Function& F)
 
     if (moveInst.size())
     {
-        for (auto mi : reverse(moveInst))
+        for (auto &mi : reverse(moveInst))
         {
             mi.first->moveBefore(mi.second);
         }

IGC/Compiler/CustomSafeOptPass.hpp

@@ -37,8 +37,6 @@ namespace IGC
 
         CustomSafeOptPass();
 
-        ~CustomSafeOptPass() {}
-
         virtual void getAnalysisUsage(llvm::AnalysisUsage& AU) const override
         {
             AU.addRequired<CodeGenContextWrapper>();
@@ -114,8 +112,6 @@ namespace IGC
 
         TrivialLocalMemoryOpsElimination();
 
-        ~TrivialLocalMemoryOpsElimination() {}
-
         virtual void getAnalysisUsage(llvm::AnalysisUsage& AU) const override
         {
             AU.addRequired<CodeGenContextWrapper>();
@@ -153,8 +149,6 @@ namespace IGC
 
         GenSpecificPattern();
 
-        ~GenSpecificPattern() {}
-
         virtual void getAnalysisUsage(llvm::AnalysisUsage& AU) const override
         {
             AU.setPreservesCFG();
@@ -199,8 +193,6 @@ namespace IGC
 
         FCmpPaternMatch();
 
-        ~FCmpPaternMatch() {}
-
         virtual bool runOnFunction(llvm::Function& F) override;
 
         virtual llvm::StringRef getPassName() const override
@@ -218,8 +210,6 @@ namespace IGC
 
         IGCConstProp(bool enableSimplifyGEP = false);
 
-        ~IGCConstProp() {}
-
         virtual void getAnalysisUsage(llvm::AnalysisUsage& AU) const override
         {
             AU.addRequired<llvm::TargetLibraryInfoWrapperPass>();

IGC/Compiler/ModuleAllocaAnalysis.hpp

@@ -36,6 +36,8 @@ namespace IGC
 
         ModuleAllocaAnalysis();
         ~ModuleAllocaAnalysis();
+        ModuleAllocaAnalysis(const ModuleAllocaAnalysis&) = delete;
+        ModuleAllocaAnalysis& operator=(const ModuleAllocaAnalysis&) = delete;
 
         virtual llvm::StringRef getPassName() const override;
 

IGC/Compiler/Optimizer/OpenCLPasses/AggregateArguments/AggregateArguments.hpp

@@ -28,8 +28,6 @@ namespace IGC
 
         AggregateArgumentsAnalysis();
 
-        ~AggregateArgumentsAnalysis() {}
-
         virtual llvm::StringRef getPassName() const override
         {
             return "AggregateArgumentsAnalysis";
@@ -63,8 +61,6 @@ namespace IGC
 
         ResolveAggregateArguments();
 
-        ~ResolveAggregateArguments() {}
-
         virtual llvm::StringRef getPassName() const override
         {
             return "ResolveAggregateArguments";

IGC/Compiler/Optimizer/OpenCLPasses/DeviceEnqueueFuncs/DeviceEnqueue.hpp

@@ -26,8 +26,6 @@ namespace IGC
 
         DeviceEnqueueFuncsAnalysis();
 
-        ~DeviceEnqueueFuncsAnalysis() {}
-
         virtual llvm::StringRef getPassName() const override
         {
             return "DeviceEnqueueFuncsAnalysis";
@@ -67,8 +65,6 @@ namespace IGC
 
         DeviceEnqueueFuncsResolution();
 
-        ~DeviceEnqueueFuncsResolution() {}
-
         virtual llvm::StringRef getPassName() const override
         {
             return "DeviceEnqueueFuncsResolution";

IGC/Compiler/Optimizer/OpenCLPasses/DisableLoopUnrollOnRetry/DisableLoopUnrollOnRetry.hpp

@@ -26,8 +26,6 @@ namespace IGC
 
         DisableLoopUnrollOnRetry();
 
-        ~DisableLoopUnrollOnRetry() {}
-
         virtual void getAnalysisUsage(llvm::AnalysisUsage& AU) const
         {
             AU.setPreservesCFG();

IGC/Compiler/Optimizer/OpenCLPasses/RayTracing/ResolveOCLRaytracingBuiltins.hpp

@@ -29,8 +29,6 @@ namespace IGC {
 
     ResolveOCLRaytracingBuiltins();
 
-    ~ResolveOCLRaytracingBuiltins() {};
-
     virtual llvm::StringRef getPassName() const override {
       return "ResolveOCLRaytracingBuiltins";
     }

IGC/Compiler/Optimizer/OpenCLPasses/WGFuncs/WGFuncResolution.hpp

@@ -27,9 +27,6 @@ namespace IGC
         /// @brief  Constructor
         WGFuncResolution();
 
-        /// @brief  Destructor
-        ~WGFuncResolution() {}
-
         /// @brief  Provides name of pass
         virtual llvm::StringRef getPassName() const override
         {

IGC/Metrics/IGCMetricImpl.h

@@ -111,6 +111,8 @@ namespace IGCMetrics
     public:
         IGCMetricImpl();
         ~IGCMetricImpl();
+        IGCMetricImpl(const IGCMetricImpl&) = delete;
+        IGCMetricImpl& operator=(const IGCMetricImpl&) = delete;
         bool Enable();
 
         size_t getMetricDataSize();

IGC/common/debug/TeeOutputStream.hpp

@@ -31,6 +31,8 @@ namespace Debug
             bool shouldDeleteRHS);
 
         ~TeeOutputStream();
+        TeeOutputStream(const TeeOutputStream&) = delete;
+        TeeOutputStream& operator=(const TeeOutputStream&) = delete;
 
         size_t preferred_buffer_size() const override;
 

visa/Arena.h

@@ -83,6 +83,9 @@ class ArenaHeader {
     _nextArena = 0;
   }
 
+  ArenaHeader(const ArenaHeader&) = delete;
+  ArenaHeader& operator=(const ArenaHeader&) = delete;
+
   void *AllocSpace(size_t size, size_t align);
 
   // Data
@@ -105,6 +108,8 @@ class ArenaManager {
   }
 
   ~ArenaManager() { FreeArenas(); }
+  ArenaManager(const ArenaManager&) = delete;
+  ArenaManager& operator=(const ArenaManager&) = delete;
 
   void *AllocDataSpace(size_t size, size_t al) {
     // Do separate memory allocations of debugMemAlloc is set, to allow

visa/LocalScheduler/G4_Sched.cpp

@@ -497,6 +497,8 @@ class BB_Scheduler {
     schedule.clear();
     OrigInstList.clear();
   }
+  BB_Scheduler(const BB_Scheduler&) = delete;
+  BB_Scheduler& operator=(const BB_Scheduler&) = delete;
 
   G4_Kernel &getKernel() const { return kernel; }
   G4_BB *getBB() const { return ddd.getBB(); }

visa/LocalScheduler/LocalScheduler_G4IR.h

@@ -413,6 +413,9 @@ class window2xSP {
     instList.clear();
   }
 
+  window2xSP(const window2xSP&) = delete;
+  window2xSP& operator=(const window2xSP&) = delete;
+
   ~window2xSP() {
     instGRFSize = 0;
     instType = Type_UNDEF;

visa/LocalScheduler/SWSB_G4IR.h

@@ -159,7 +159,6 @@ struct SBFootprint {
               unsigned short RB, G4_INST *i)
       : fType(ft), type((unsigned short)p), LeftB(LB), RightB(RB), inst(i), isPrecision(true) {
   }
-  ~SBFootprint() {}
 
   void setOffset(unsigned short o) { offset = o; }
 
@@ -322,15 +321,6 @@ class SBNode {
     instVec.push_back(i);
   }
 
-  ~SBNode() {
-    // FIXME: I'd like to replace this with type-specific allocator as well, but
-    // the ownership is unclear to me, is it safe to put the allocator in
-    // SBNode?
-    for (SBFootprint *sm : footprints) {
-      sm->~SBFootprint();
-    }
-  }
-
   void setSendID(int ID) { sendID = ID; }
 
   void setSendUseID(int ID) { sendUseID = ID; }
@@ -530,8 +520,6 @@ struct SBBucketNode {
                const SBFootprint *f)
       : node(node1), opndNum(opndNum1), footprint(f) {}
 
-  ~SBBucketNode() {}
-
   void setSendID(int ID) { sendID = ID; }
 
   int getSendID() const { return sendID; }

visa/Mem_Manager.h

@@ -48,6 +48,8 @@ template <class T> class std_arena_based_allocator {
   typedef const T &const_reference;
   typedef T value_type;
 
+  ~std_arena_based_allocator() = default;
+
   explicit std_arena_based_allocator(std::shared_ptr<Mem_Manager> _other_ptr)
       : mem_manager_ptr(_other_ptr) {}
 

visa/Optimizer.h

@@ -442,6 +442,8 @@ class Optimizer {
 #endif // DLL_MODE
     initOptimizations();
   }
+  Optimizer(const Optimizer&) = delete;
+  Optimizer& operator=(const Optimizer&) = delete;
   ~Optimizer() {
     // Normally, noMask Info will be freed in postRA workaround.
     // But in case RA fails, postRA will not be invoked. Thus, need

visa/PhyRegUsage.h

@@ -99,6 +99,9 @@ class FreePhyRegs {
     weakEdgeUsage.resize(K.getNumRegTotal(), 0);
   }
 
+  FreePhyRegs(const FreePhyRegs&) = delete;
+  FreePhyRegs& operator=(const FreePhyRegs&) = delete;
+
   ~FreePhyRegs() {
     delete[] availableGregs;
     delete[] availableAddrs;

visa/RegAlloc.h

@@ -121,6 +121,8 @@ class LivenessAnalysis {
   LivenessAnalysis(GlobalRA &gra, unsigned char kind, bool verifyRA = false,
                    bool forceRun = false);
   ~LivenessAnalysis();
+  LivenessAnalysis(const LivenessAnalysis&) = delete;
+  LivenessAnalysis& operator=(const LivenessAnalysis&) = delete;
   void computeLiveness();
   bool isLiveAtEntry(const G4_BB *bb, unsigned var_id) const;
   bool isUseThrough(const G4_BB *bb, unsigned var_id) const;

visa/Rematerialization.h

@@ -232,6 +232,9 @@ class Rematerialization {
     }
   }
 
+  Rematerialization(const Rematerialization&) = delete;
+  Rematerialization& operator=(const Rematerialization&) = delete;
+
   bool getChangesMade() const { return IRChanged; }
 
   void run();

visa/SCCAnalysis.h

@@ -64,6 +64,8 @@ class SCCAnalysis {
 
 public:
   SCCAnalysis(const FlowGraph &fg) : cfg(fg) {}
+  SCCAnalysis(const SCCAnalysis&) = delete;
+  SCCAnalysis& operator=(const SCCAnalysis&) = delete;
   ~SCCAnalysis() {
     for (auto node : SCCNodes) {
       delete node;

visa/SpillManagerGMRF.h

@@ -728,6 +728,8 @@ class SpillAnalysis {
 public:
   SpillAnalysis() = default;
   ~SpillAnalysis();
+  SpillAnalysis(const SpillAnalysis&) = delete;
+  SpillAnalysis& operator=(const SpillAnalysis&) = delete;
 
   void Dump(std::ostream &OS = std::cerr);
   void DumpHistogram(std::ostream &OS = std::cerr);

visa/VISAKernel.h

@@ -115,6 +115,8 @@ class VISAKernelImpl : public VISAFunction {
   void *alloc(size_t sz) { return m_mem.alloc(sz); }
 
   virtual ~VISAKernelImpl();
+  VISAKernelImpl(const VISAKernelImpl&) = delete;
+  VISAKernelImpl& operator=(const VISAKernelImpl&) = delete;
 
   void *operator new(size_t sz, vISA::Mem_Manager &m) { return m.alloc(sz); };
 

visa/VarSplit.h

@@ -42,6 +42,8 @@ class LoopVarSplit {
   LoopVarSplit(G4_Kernel &k, GraphColor *c,
                const LivenessAnalysis *liveAnalysis);
   ~LoopVarSplit() { delete rpe; }
+  LoopVarSplit(const LoopVarSplit&) = delete;
+  LoopVarSplit& operator=(const LoopVarSplit&) = delete;
 
   void run();
 

visa/iga/IGALibrary/IR/RegSet.hpp

@@ -42,6 +42,7 @@ class RegSet {
   bool isTrackedReg(RegName rn) const;
 
 public:
+  ~RegSet() = default;
   RegSet(const Model &m);
   RegSet(const RegSet &rs);
   RegSet &operator=(const RegSet &);

visa/iga/IGALibrary/MemManager/Arena.hpp

@@ -65,6 +65,9 @@ class ArenaHeader {
     _nextArena = 0;
   }
 
+  ArenaHeader(const ArenaHeader&) = delete;
+  ArenaHeader& operator=(const ArenaHeader&) = delete;
+
   void *AllocSpace(size_t size);
 
   ArenaHeader *_nextArena;  // Word aligned
@@ -82,6 +85,8 @@ class ArenaManager {
   }
 
   ~ArenaManager() { FreeArenas(); }
+  ArenaManager(const ArenaManager&) = delete;
+  ArenaManager& operator=(const ArenaManager&) = delete;
 
   void *AllocDataSpace(size_t size) {
     // Do separate memory allocations of debugMemAlloc is set, to allow

visa/iga/IGALibrary/MemManager/StdArenaAllocator.hpp

@@ -28,6 +28,8 @@ template <class T> class std_arena_based_allocator {
   typedef const T &const_reference;
   typedef T value_type;
 
+  ~std_arena_based_allocator() = default;
+
   explicit std_arena_based_allocator(std::shared_ptr<MemManager> _other_ptr)
       : MemManager_ptr(_other_ptr) {}
 

visa/iga/IGALibrary/system.cpp

@@ -185,6 +185,8 @@ struct StreamColorSetter {
     stream.flush();
     restoreColor();
   }
+  StreamColorSetter(const StreamColorSetter&) = delete;
+  StreamColorSetter& operator=(const StreamColorSetter&) = delete;
 
   bool colorNeedsRestore;
 #ifdef _WIN32