Iterate using references in IGC

Iterate through containers using auto& instead of auto.

Author: fda0

IGC/AdaptorOCL/LowerInvokeSIMD.cpp

@@ -195,7 +195,7 @@ bool LowerInvokeSIMD::runOnModule(Module &M) {
 
   // If there are uses of vc functions outside invoke_simd calls (e.g. function
   // pointer is taken), replace the old functions with new.
-  for (auto it : m_OldFuncToNewFuncMap) {
+  for (const auto &it : m_OldFuncToNewFuncMap) {
     Function *OldFunc = it.first;
     Function *NewFunc = it.second;
     for (auto &use : OldFunc->uses()) {

IGC/AdaptorOCL/OCL/sp/spp_g8.cpp

@@ -797,7 +797,7 @@ bool CGen8OpenCLProgram::GetZEBinary(
         if (IGC_IS_FLAG_DISABLED(ElfTempDumpEnable))
         {
             // Remove all temporary input ELF files
-            for (auto elfFile : elfVecNames)
+            for (const auto &elfFile : elfVecNames)
             {
                 if (elfFile.compare(elfLinkerLogName.c_str()))
                 {

IGC/AdaptorOCL/SPIRV/libSPIRV/SPIRVModule.cpp

@@ -346,7 +346,7 @@ class SPIRVModuleImpl : public SPIRVModule {
 };
 
 SPIRVModuleImpl::~SPIRVModuleImpl() {
-    for (auto I : IdEntryMap)
+    for (const auto &I : IdEntryMap)
         delete I.second;
 
     for (auto I : EntryNoId)

IGC/Compiler/CISACodeGen/AtomicOptPass.cpp

@@ -205,7 +205,7 @@ bool AtomicOptPass::runOnFunction(Function &F)
         }
     }
 
-    for (auto T : AtomicsEmulationToProcess)
+    for (const auto &T : AtomicsEmulationToProcess)
     {
         Instruction *AtomicInstr = std::get<0>(T);
         BasicBlock *BackBb = std::get<1>(T);

IGC/Compiler/CISACodeGen/CISABuilder.cpp

@@ -3808,7 +3808,7 @@ namespace IGC
     }
     void CEncoder::SetBuilderOptions(VISABuilder* pbuilder)
     {
-        for (auto OP : m_visaUserOptions)
+        for (const auto &OP : m_visaUserOptions)
         {
             switch (OP.second.type)
             {
@@ -5748,7 +5748,7 @@ namespace IGC
         }
 
         // Export global symbols
-        for (auto global : modMD->inlineProgramScopeOffsets)
+        for (const auto &global : modMD->inlineProgramScopeOffsets)
         {
             GlobalVariable* pGlobal = global.first;
 
@@ -5809,7 +5809,7 @@ namespace IGC
         {
             std::vector<vISA::GenSymEntry> tempBufferData;
             // Collect the data just for the symbol table entries
-            for (auto I : symbolTableList)
+            for (const auto &I : symbolTableList)
             {
                 auto symbolEntry = I.second;
                 tempBufferData.push_back(symbolEntry);
@@ -5831,7 +5831,7 @@ namespace IGC
         ModuleMetaData* modMD = m_program->GetContext()->getModuleMetaData();
 
         // Get the data for zebin
-        for (auto I : symbolTableList)
+        for (const auto &I : symbolTableList)
         {
             Value* symbolValue = I.first;
             auto symbolEntry = I.second;
@@ -5912,7 +5912,7 @@ namespace IGC
         tableEntries = 0;
 
         std::vector<vISA::GenFuncAttribEntry> attribTable;
-        for (auto it : funcAttributeMap)
+        for (const auto &it : funcAttributeMap)
         {
             vISA::GenFuncAttribEntry entry;
             Function* F = it.first;
@@ -5983,7 +5983,7 @@ namespace IGC
     {
         ModuleMetaData* modMD = m_program->GetContext()->getModuleMetaData();
 
-        for (auto global : modMD->inlineProgramScopeOffsets)
+        for (const auto &global : modMD->inlineProgramScopeOffsets)
         {
             GlobalVariable* pGlobal = global.first;
             if (pGlobal->hasAttribute("host_var_name"))

IGC/Compiler/CISACodeGen/CShader.cpp

@@ -645,7 +645,7 @@ void CShader::AllocateSimplePushConstants(uint& offset)
 {
     for (unsigned int i = 0; i < pushInfo.simplePushBufferUsed; i++)
     {
-        for (auto I : pushInfo.simplePushInfoArr[i].simplePushLoads)
+        for (const auto &I : pushInfo.simplePushInfoArr[i].simplePushLoads)
         {
             uint subOffset = I.first;
             CVariable* var = GetSymbol(m_argListCache[I.second]);

IGC/Compiler/CISACodeGen/EstimateFunctionSize.cpp

@@ -427,9 +427,9 @@ namespace {
 
 void FunctionNode::print(raw_ostream& os) {
     os << "Function: " << F->getName() << ", " << InitialSize << "\n";
-    for (auto G : CalleeList)
+    for (const auto &G : CalleeList)
         os << "--->>>" << G.first->F->getName() << "\n";
-    for (auto G : CallerList)
+    for (const auto &G : CallerList)
         os << "<<<---" << G.first->F->getName() << "\n";
 }
 #endif
@@ -933,7 +933,7 @@ bool EstimateFunctionSize::onlyCalledOnce(const Function* F) {
         auto MdWrapper = getAnalysisIfAvailable<MetaDataUtilsWrapper>();
         if (MdWrapper) {
             auto pMdUtils = MdWrapper->getMetaDataUtils();
-            for (auto node : Node->CallerList) {
+            for (const auto &node : Node->CallerList) {
                 FunctionNode* Caller = node.first;
                 uint32_t cnt = node.second;
                 if (cnt > 1) {
@@ -1104,7 +1104,7 @@ void EstimateFunctionSize::UpdateSizeAfterCollapsing(std::deque<void*> &nodesToP
             }
         }
 
-        for (auto c : Node->CallerList)
+        for (const auto &c : Node->CallerList)
         {
             FunctionNode* caller = c.first;
             uint16_t call_cnt = c.second;
@@ -1156,7 +1156,7 @@ uint32_t EstimateFunctionSize::updateExpandedUnitSize(Function* F, bool ignoreSt
                 << ", Total chunck size: " << unitTotalSize);
         }
 
-        for (auto c : node->CallerList)
+        for (const auto &c : node->CallerList)
         {
             FunctionNode* caller = c.first;
             if (FunctionsInUnit.find(caller) == FunctionsInUnit.end()) //Caller is in another compilation unit
@@ -1222,7 +1222,7 @@ uint32_t EstimateFunctionSize::bottomUpHeuristic(Function* F, uint32_t& stackCal
             }
         }
 
-        for (auto c : Node->CallerList)
+        for (const auto &c : Node->CallerList)
         {
             FunctionNode* caller = c.first;
             if (FunctionsInUnit.find(caller) == FunctionsInUnit.end()) //The caller is in another kernel, skip

IGC/Compiler/CISACodeGen/GenCodeGenModule.cpp

@@ -248,7 +248,7 @@ void GenXCodeGenModule::processFunction(Function& F)
         // have the same SIMD sizes, otherwise we cannot make it an indirect call
         int simd_size = 0;
         unsigned CallersPerSIMD[3] = { 0, 0, 0 };
-        for (auto iter : CallerFGs)
+        for (const auto &iter : CallerFGs)
         {
             Function* callerKernel = iter.first->getHead();
             auto funcInfoMD = pMdUtils->getFunctionsInfoItem(callerKernel);
@@ -314,7 +314,7 @@ void GenXCodeGenModule::processFunction(Function& F)
     }
 
     bool FirstPair = true;
-    for (auto FGPair : CallerFGs)
+    for (const auto &FGPair : CallerFGs)
     {
         if (FirstPair)
         {
@@ -986,7 +986,7 @@ void GenXFunctionGroupAnalysis::CloneFunctionGroupForMultiSIMDCompile(llvm::Modu
                         auto pNewICG = getOrCreateIndirectCallGroup(pModule, simdsz);
                         addToFunctionGroup(FCloned, pNewICG, FCloned);
 
-                        for (auto iter : UsersMap)
+                        for (const auto &iter : UsersMap)
                         {
                             if (iter.second == simdsz)
                             {

IGC/Compiler/ModuleAllocaAnalysis.cpp

@@ -164,7 +164,7 @@ bool ModuleAllocaAnalysis::safeToUseScratchSpace() const
         if (Ctx.type == ShaderType::OPENCL_SHADER && IGC_IS_FLAG_ENABLED(ForceStatelessForQueueT)) {
             if (!F.arg_empty()) {
                 KernelArgs kernelArgs(F, DL, pMdUtils, &modMD, Ctx.platform.getGRFSize());
-                for (auto arg : kernelArgs) {
+                for (const auto &arg : kernelArgs) {
                     const KernelArg::ArgType argTy = arg.getArgType();
                     if (argTy == KernelArg::ArgType::PTR_DEVICE_QUEUE)
                     {

IGC/Compiler/Optimizer/BuiltInFuncImport.cpp

@@ -1445,7 +1445,7 @@ bool PreBIImportAnalysis::runOnModule(Module& M)
         }
     }
 
-    for (auto InstTuple : InstToModify)
+    for (const auto &InstTuple : InstToModify)
     {
       auto inst = std::get<0>(InstTuple);
       auto value = std::get<1>(InstTuple);

IGC/Compiler/Optimizer/OpenCLPasses/PrivateMemory/PrivateMemoryToSLM.cpp

@@ -191,7 +191,7 @@ namespace IGC
 
             // Calculate an offset for new SLM variables.
             unsigned int offset = 0;
-            for (auto offsets : ModuleMD->FuncMD[F].localOffsets)
+            for (const auto &offsets : ModuleMD->FuncMD[F].localOffsets)
             {
                 PointerType* ptrType = dyn_cast<PointerType>(offsets.m_Var->getType());
                 Type* varType = IGCLLVM::getNonOpaquePtrEltTy(ptrType);

IGC/Compiler/Optimizer/OpenCLPasses/ProgramScopeConstants/ProgramScopeConstantAnalysis.cpp

@@ -251,7 +251,7 @@ bool ProgramScopeConstantAnalysis::runOnModule(Module& M)
     {
         // Add globals tracked in metadata to the "llvm.used" list so they won't be deleted by optimizations
         llvm::SmallVector<GlobalValue*, 4> gvec;
-        for (auto Node : inlineProgramScopeOffsets)
+        for (const auto &Node : inlineProgramScopeOffsets)
         {
             gvec.push_back(Node.first);
         }
@@ -346,7 +346,7 @@ bool ProgramScopeConstantAnalysis::runOnModule(Module& M)
     }
 
     const bool changed = !inlineProgramScopeOffsets.empty();
-    for (auto offset : inlineProgramScopeOffsets)
+    for (const auto &offset : inlineProgramScopeOffsets)
     {
         std::string globalName = offset.first->getName().str();
         if (Ctx->m_retryManager.IsFirstTry())

IGC/Compiler/Optimizer/OpenCLPasses/ResourceAllocator/ResourceAllocator.cpp

@@ -264,7 +264,7 @@ bool ResourceAllocator::runOnFunction(llvm::Function& F)
         allocationMode = BindlessAllocationMode::Preferred;
     }
 
-    for (auto arg : kernelArgs)
+    for (const auto &arg : kernelArgs)
     {
         const AllocationType allocType = getAllocationType(arg.getArgType(), allocationMode);
 
@@ -356,7 +356,7 @@ bool ResourceAllocator::runOnFunction(llvm::Function& F)
     }
 
     // Param allocations must be inserted to the Metadata Utils in order.
-    for (auto i : paramAllocations)
+    for (const auto &i : paramAllocations)
     {
         resAllocMD->argAllocMDList.push_back(i);
     }

IGC/Compiler/Optimizer/OpenCLPasses/StatelessToStateful/StatelessToStateful.cpp

@@ -924,7 +924,7 @@ void StatelessToStateful::finalizeArgInitialValue(Function* F)
     Type* int32Ty = Type::getInt32Ty(M->getContext());
     Value* ZeroValue = ConstantInt::get(int32Ty, 0);
 
-    for (auto II : m_argsInfo)
+    for (const auto &II : m_argsInfo)
     {
         const KernelArg* kernelArg = II.first;
         int mapVal = II.second;

IGC/Compiler/Optimizer/OpenCLPasses/SubGroupFuncs/SubGroupFuncsResolution.cpp

@@ -265,7 +265,7 @@ void SubGroupFuncsResolution::CheckSIMDSize(Instruction& I, StringRef msg)
 
 WaveOps SubGroupFuncsResolution::GetWaveOp(StringRef funcName)
 {
-    for (auto op : SubGroupFuncsResolution::m_spvOpToWaveOpMap)
+    for (const auto &op : SubGroupFuncsResolution::m_spvOpToWaveOpMap)
     {
         if (funcName.contains(op.first))
         {

IGC/Compiler/Optimizer/PreCompiledFuncImport.cpp

@@ -810,7 +810,7 @@ bool PreCompiledFuncImport::runOnModule(Module& M)
         }
     }
 
-    for (auto p : replaceInsts)
+    for (const auto &p : replaceInsts)
     {
         p.first->replaceAllUsesWith(p.second);
         p.first->eraseFromParent();
@@ -998,7 +998,7 @@ bool PreCompiledFuncImport::runOnModule(Module& M)
         }
 
         // free FuncsImpArgs
-        for (auto I : FuncsImpArgs) {
+        for (const auto &I : FuncsImpArgs) {
             ImplicitArgs* IA = I.second;
             delete IA;
         }

IGC/Compiler/Optimizer/ReduceOptPass.cpp

@@ -65,7 +65,7 @@ bool ReduceOptPass::createReduceWI0(Instruction *ReduceInstr) {
     std::string Prefix = "__builtin_IB_WorkGroupReduce_WI0_";
 
     std::string Op = "";
-    for (auto I : OpSet) {
+    for (const auto &I : OpSet) {
         if (Name.find(I) != std::string::npos) {
             Op = I;
             break;

IGC/Compiler/Optimizer/Scalarizer.cpp

@@ -1400,7 +1400,7 @@ void ScalarizeFunction::resolveDeferredInstructions()
         }
     }
 
-    for ( auto entry : dummyToScalarMap )
+    for (const auto &entry : dummyToScalarMap)
     {
         // Replace and erase all dummy instructions (don't use eraseFromParent as the dummy is not in the function)
         Instruction *dummyInst = cast<Instruction>(entry.first);

IGC/Compiler/SPIRMetaDataTranslation.cpp

@@ -95,7 +95,7 @@ void SPIRMetaDataTranslation::translateKernelMetadataIntoOpenCLKernelsMD(Module&
             Func.getContext().getMDKindNames(Names);
             Func.getAllMetadata(Info);
             Args.push_back(ConstantAsMetadata::get(&Func));
-            for (auto i : Info)
+            for (const auto &i : Info)
             {
                 llvm::SmallVector<Metadata*, 2> Mdvector;
                 auto firstElem = MDString::get(M.getContext(), Names[i.first]);

IGC/Compiler/SampleMultiversioning.cpp

@@ -284,7 +284,7 @@ bool SampleMultiversioning::runOnFunction(Function& F)
                         }
                         else
                         {
-                            for (auto tempSI : SampleInsts)
+                            for (const auto &tempSI : SampleInsts)
                             {
                                 // Corner case where two samplers can be branched for one Mul.
                                 if (val_insn == tempSI.Sample)

IGC/DebugInfo/DwarfDebug.cpp

@@ -1562,7 +1562,7 @@ void DwarfDebug::collectVariableInfo(
     write(TempDotDebugLocEntries.back().loc, (unsigned char *)&startRange,
           pointerSize);
 
-    for (auto it : allCallerSave) {
+    for (const auto &it : allCallerSave) {
       TempDotDebugLocEntries.back().end = std::get<0>(it);
       write(TempDotDebugLocEntries.back().loc,
             (unsigned char *)&std::get<0>(it), pointerSize);
@@ -1768,7 +1768,7 @@ void DwarfDebug::collectVariableInfo(
         continue;
       }
 
-      for (auto range : GenISARange) {
+      for (const auto &range : GenISARange) {
         DbgValuesWithGenIP[RegVar].push_back(
             std::make_tuple(range.first, range.second, RegVar, pInst));
       }

IGC/DebugInfo/VISAModule.cpp

@@ -295,7 +295,7 @@ VISAModule::getAllCallerSave(const VISAObjectDebugInfo &VDI,
       if (startRange < callerSaveIp) {
         callerRestoreIp = std::min<uint64_t>(endRange, callerRestoreIp);
         // Variable is live over stack call function.
-        for (auto callerSaveReg : (*callerSaveStartIt).data) {
+        for (const auto &callerSaveReg : (*callerSaveStartIt).data) {
           // startRegNum is saved to caller save area around the stack call.
           if ((callerSaveReg.srcRegOff / getGRFSizeInBytes()) == startRegNum) {
             // Emit caller save/restore only if %ip is within range

IGC/ElfPackager/main.cpp

@@ -272,7 +272,7 @@ int main(int argc, char *argv[])
             if (FuncName.str().find("__builtin_IB_") == std::string::npos &&
                 FuncName.str().find("llvm.") == std::string::npos)
             {
-                for (auto iterator2 : FunctionList)
+                for (const auto &iterator2 : FunctionList)
                 {
                     if (FuncName.find(iterator2) != std::string::npos)
                     {
@@ -337,7 +337,7 @@ int main(int argc, char *argv[])
     else
         counter = 2;
 
-    for (auto map_iterator : Map)
+    for (const auto &map_iterator : Map)
     {
         std::vector<GlobalValue*> ExtractValue = map_iterator.second;
         llvm::ValueToValueMapTy Val;
@@ -351,7 +351,7 @@ int main(int argc, char *argv[])
         ElfMap[map_iterator.first] = OS.str().str();
     }
 
-    for (auto map_iterator : Map)
+    for (const auto &map_iterator : Map)
     {
         std::vector<GlobalValue*> ExtractValue = map_iterator.second;
         for (size_t i = 0, e = ExtractValue.size(); i != e; ++i)
@@ -459,7 +459,7 @@ int main(int argc, char *argv[])
     }
 
     //Now to add all of the sections in the file
-    for (auto elf_iterator : ElfMap)
+    for (const auto &elf_iterator : ElfMap)
     {
         CreateElfSection(pWriter,
             sectionNode,