Refactor preload checks for spills.

weiyu-chen · sys_zuul · commit b6abc581102f · 2020-02-01T18:56:31.000-08:00
Change-Id: I26fe2df4688f1047f02d68c6a3669c2b13ecc017
diff --git a/visa/SpillManagerGMRF.h b/visa/SpillManagerGMRF.h
@@ -904,15 +904,17 @@ inline bool isPartialContext (
     bool          isInSimdFlow
 )
 {
-    if ((ctxt->getPredicate () != NULL && ctxt->opcode() != G4_sel) ||
-        (isInSimdFlow == true &&
-         ctxt->isWriteEnableInst() == false &&
-         region->getElemSize() != 4 ) ) {
+    if (ctxt->isPartialWrite())
+    {
         return true;
     }
 
-    if (ctxt->getDst()) {
-        return false;
+    if (isInSimdFlow && !ctxt->isWriteEnableInst())
+    {
+        if (region->getElemSize() != 4)
+        {
+            return true;
+        }
     }
 
     return false;

Original file line number	Diff line number	Diff line change
`@@ -904,15 +904,17 @@ inline bool isPartialContext (`
`904`	`904`	`bool isInSimdFlow`
`905`	`905`	`)`
`906`	`906`	`{`
`907`		`- if ((ctxt->getPredicate () != NULL && ctxt->opcode() != G4_sel) \|\|`
`908`		`- (isInSimdFlow == true &&`
`909`		`- ctxt->isWriteEnableInst() == false &&`
`910`		`- region->getElemSize() != 4 ) ) {`
	`907`	`+ if (ctxt->isPartialWrite())`
	`908`	`+ {`
`911`	`909`	`return true;`
`912`	`910`	`}`
`913`	`911`
`914`		`- if (ctxt->getDst()) {`
`915`		`- return false;`
	`912`	`+ if (isInSimdFlow && !ctxt->isWriteEnableInst())`
	`913`	`+ {`
	`914`	`+ if (region->getElemSize() != 4)`
	`915`	`+ {`
	`916`	`+ return true;`
	`917`	`+ }`
`916`	`918`	`}`
`917`	`919`
`918`	`920`	`return false;`