Add spill size generated by IGC

Add spill size generated by IGC for private variables in *.asm shader dumps.

Author: lwesiers

IGC/Compiler/CISACodeGen/CISABuilder.cpp

@@ -5307,8 +5307,13 @@ namespace IGC
         IGC_ASSERT(nullptr != vKernel);
         uint scratchSpaceSizeTemp = m_program->m_ScratchSpaceSize;
 
-        if (scratchSpaceSizeTemp == 0 ||
-            !m_program->GetContext()->getModuleMetaData()->compOpt.UseScratchSpacePrivateMemory)
+        CodeGenContext* context = m_program->GetContext();
+
+        bool noticedScratchSpaceByIGC = context->m_ScratchSpaceUsage.count(m_program->entry) > 0 &&
+            context->m_ScratchSpaceUsage[m_program->entry] > 0;
+
+        if (!noticedScratchSpaceByIGC && (scratchSpaceSizeTemp == 0 ||
+            !m_program->GetContext()->getModuleMetaData()->compOpt.UseScratchSpacePrivateMemory))
             return;
         // slot1 is used for spilling only when SeparatingSpillAndPrivateScratchMemorySpace is on
         // and Slot0 is used for IGC private memory

IGC/Compiler/CISACodeGen/LowerGEPForPrivMem.cpp

@@ -522,6 +522,19 @@ void LowerGEPForPrivMem::MarkNotPromtedAllocas(llvm::AllocaInst& I, IGC::StatusP
         I.getContext(),
         MDString::get(I.getContext(), reason));
 
+
+    auto allocationSize = I.getAllocationSizeInBits(m_ctx->getModule()->getDataLayout());
+
+    if (allocationSize)
+    {
+        auto scratchUsage_i = m_ctx->m_ScratchSpaceUsage.find(I.getFunction());
+        if (scratchUsage_i == m_ctx->m_ScratchSpaceUsage.end())
+        {
+            m_ctx->m_ScratchSpaceUsage.insert({ I.getFunction(), 0 });
+        }
+        m_ctx->m_ScratchSpaceUsage[I.getFunction()] += allocationSize.getValue() / 8;
+    }
+
     UserAddrSpaceMD& userASMD = m_ctx->m_UserAddrSpaceMD;
     std::function<void(Instruction*, MDNode*)> markAS_PRIV;
     markAS_PRIV = [&markAS_PRIV, &userASMD](Instruction* instr, MDNode* node) -> void

IGC/Compiler/CodeGenPublic.h

@@ -905,6 +905,9 @@ namespace IGC
 
         UserAddrSpaceMD m_UserAddrSpaceMD;
 
+        // Used scratch space for private variables
+        llvm::DenseMap<llvm::Function*, uint64_t> m_ScratchSpaceUsage;
+
         // shader stat for opt customization
         uint32_t     m_tempCount = 0;
         uint32_t     m_sampler = 0;

IGC/ocloc_tests/features/metadata_travel_check/user_private_var.cl

@@ -17,6 +17,8 @@ SPDX-License-Identifier: MIT
 // RUN: ocloc compile -file %s -options " -g -igc_opts 'PrintToConsole=1 PrintMDBeforeModule=1 PrintAfter=EmitPass'" -device pvc 2>&1 | FileCheck %s --check-prefix=CHECK-LLVM3
 // RUN: ocloc compile -file %s -options " -g -igc_opts 'PrintToConsole=1 PrintMDBeforeModule=1 PrintAfter=EmitPass'" -device pvc 2>&1 | FileCheck %s --check-prefix=CHECK-LLVM4
 
+// Looking for the comment which informs about the amount of spill size
+// CHECK-ASM: //.private memory size
 // Looking for the comment attached to the instructions ex:
 // (W)     store.ugm .... //  address space: private; ; $193
 // CHECK-ASM: address space: private;