Skip to content

Commit e8f25ba

Browse files
jgu222igcbot
authored andcommitted
Revert Fixed preparePayload for more sends
revert the previous change: This is to continue what "OS Summary: Incorrect payload preparation for some send" does, to fix more sends.
1 parent e833c2b commit e8f25ba

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

visa/VisaToG4/TranslateSendLdStLegacy.cpp

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,7 @@ int IR_Builder::translateVISAQWScatterInst(
109109

110110
G4_SrcRegRegion *msgs[2] {0, 0};
111111
unsigned sizes[2] {0, 0};
112-
// For send that has smaller execsize than exSize, like
113-
// "send (4) ..."
114-
// Make sure to use send's execsize (4) as batchsize, not 8/16/32.
115-
// Thus, batchsize is min(exSize, instExSize).
116-
preparePayload(msgs, sizes, std::min(exSize, instExSize), useSplitSend, sources, len);
112+
preparePayload(msgs, sizes, exSize, useSplitSend, sources, len);
117113

118114
uint32_t desc = buildDescForScatter(DC_QWORD_SCATTERED_WRITE, numBlocks,
119115
execSize == EXEC_SIZE_8 ? MDC_SM2_SIMD8 : MDC_SM2_SIMD16);
@@ -1514,7 +1510,7 @@ int IR_Builder::translateVISADwordAtomicInst(
15141510

15151511
G4_SrcRegRegion *msgs[2] = {0, 0};
15161512
unsigned sizes[2] = {0, 0};
1517-
preparePayload(msgs, sizes, std::min(exSize, instExSize), useSplitSend, sources, len);
1513+
preparePayload(msgs, sizes, exSize, useSplitSend, sources, len);
15181514

15191515
SFID sfid = SFID::DP_DC1;
15201516
unsigned MD = 0;
@@ -1881,7 +1877,7 @@ int IR_Builder::translateVISATypedAtomicInst(
18811877

18821878
G4_SrcRegRegion *msgs[2] = {0, 0};
18831879
unsigned sizes[2] = {0, 0};
1884-
preparePayload(msgs, sizes, std::min(exSize, instExSize), useSplitSend, sources, len);
1880+
preparePayload(msgs, sizes, exSize, useSplitSend, sources, len);
18851881

18861882
unsigned dstLength = dst->isNullReg() ? 0 : 1;
18871883

@@ -2097,7 +2093,7 @@ int IR_Builder::translateGather4Inst(
20972093

20982094
G4_SrcRegRegion *msgs[2] = {0, 0};
20992095
unsigned sizes[2] = {0, 0};
2100-
preparePayload(msgs, sizes, std::min(exSize, instExSize), useSplitSend, sources, len);
2096+
preparePayload(msgs, sizes, exSize, useSplitSend, sources, len);
21012097

21022098
SFID sfid = SFID::DP_DC1;
21032099

@@ -2203,7 +2199,7 @@ int IR_Builder::translateScatter4Inst(
22032199

22042200
G4_SrcRegRegion *msgs[2] = {0, 0};
22052201
unsigned sizes[2] = {0, 0};
2206-
preparePayload(msgs, sizes, std::min(exSize, instExSize), useSplitSend, sources, len);
2202+
preparePayload(msgs, sizes, exSize, useSplitSend, sources, len);
22072203

22082204
SFID sfid = SFID::DP_DC1;
22092205

@@ -2389,7 +2385,7 @@ int IR_Builder::translateByteGatherInst(
23892385

23902386
G4_SrcRegRegion *msgs[2] = {0, 0};
23912387
unsigned sizes[2] = {0, 0};
2392-
preparePayload(msgs, sizes, std::min(exSize, instExSize), useSplitSend, sources, len);
2388+
preparePayload(msgs, sizes, exSize, useSplitSend, sources, len);
23932389

23942390
SFID sfid = SFID::DP_DC0;
23952391

@@ -2503,7 +2499,7 @@ int IR_Builder::translateByteScatterInst(
25032499

25042500
G4_SrcRegRegion *msgs[2] = {0, 0};
25052501
unsigned sizes[2] = {0, 0};
2506-
preparePayload(msgs, sizes, std::min(exSize, instExSize), useSplitSend, sources, len);
2502+
preparePayload(msgs, sizes, exSize, useSplitSend, sources, len);
25072503

25082504
SFID sfid = SFID::DP_DC0;
25092505

@@ -2864,7 +2860,7 @@ int IR_Builder::translateVISASVMScatterWriteInst(
28642860
(TypeSize(srcType) != 4))
28652861
src->setType(*this, Type_UD);
28662862

2867-
preparePayload(msgs, sizes, std::min(exSize, instExSize), useSplitSend, sources, len);
2863+
preparePayload(msgs, sizes, exSize, useSplitSend, sources, len);
28682864

28692865
// set the type back in case we changed it for preparePayload
28702866
src->setType(*this, srcType);

0 commit comments

Comments
 (0)