Ease remat cost heuristic

pratikashar · gfxbot · commit f198435b118a · 2018-08-21T13:22:40.000-07:00
Change-Id: Ia310f3e24628511cb9987eecd57c9ceb4be9a696
diff --git a/visa/Rematerialization.cpp b/visa/Rematerialization.cpp
@@ -761,7 +761,8 @@ namespace vISA
                 {
                     G4_SrcRegRegion* srcRgn = uniqueDefInst->getSrc(i)->asSrcRegRegion();
 
-                    if (srcRgn->getTopDcl()->getNumElems() > 1)
+                    if (srcRgn->getTopDcl()->getNumElems() > 1 &&
+                        !src->isSpilled())
                     {
                         // Extending non-scalar operands can be expensive
                         return false;

Original file line number	Diff line number	Diff line change
`@@ -761,7 +761,8 @@ namespace vISA`
`761`	`761`	`{`
`762`	`762`	`G4_SrcRegRegion* srcRgn = uniqueDefInst->getSrc(i)->asSrcRegRegion();`
`763`	`763`
`764`		`- if (srcRgn->getTopDcl()->getNumElems() > 1)`
	`764`	`+ if (srcRgn->getTopDcl()->getNumElems() > 1 &&`
	`765`	`+ !src->isSpilled())`
`765`	`766`	`{`
`766`	`767`	`// Extending non-scalar operands can be expensive`
`767`	`768`	`return false;`