Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Commit 051850a

Browse files
[SYCL] reenable L0 Win Sampler tests (#922)
* It looks like the last of the sampler fixes for L0 Win have landed, so these tests can be reenabled on that platform Signed-off-by: Chris Perkins <[email protected]>
1 parent 0349610 commit 051850a

8 files changed

+3
-27
lines changed

SYCL/Sampler/normalized-clamp-linear-float.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,8 @@
44
// RUN: %CPU_RUN_PLACEHOLDER %t.out
55
// RUN: %GPU_RUN_PLACEHOLDER %t.out
66

7-
// UNSUPPORTED: level_zero && windows
87
// XFAIL: cuda
98

10-
// LevelZero on Windows hangs with normalized coordinates. Waiting on fix.
11-
129
// CUDA works with image_channel_type::fp32, but not with any 8-bit per channel
1310
// type (such as unorm_int8)
1411

SYCL/Sampler/normalized-clamp-nearest.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
// RUN: %CPU_RUN_PLACEHOLDER %t.out
55
// RUN: %GPU_RUN_PLACEHOLDER %t.out
66

7-
// TODO: enable this test after flaky bug is gone on Windows
8-
// UNSUPPORTED: windows
9-
107
// LevelZero has a bug wherein it always returns the first pixel value.
118
// Will re-enable once fixed.
129

SYCL/Sampler/normalized-clampedge-linear-float.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %CPU_RUN_PLACEHOLDER %t.out
55
// XFAIL: cuda || hip
6-
// Temporarily disable test on Windows due to regressions in GPU driver.
7-
// UNSUPPORTED: windows
86

97
// CUDA works with image_channel_type::fp32, but not with any 8-bit per channel
108
// type (such as unorm_int8)

SYCL/Sampler/normalized-clampedge-nearest.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
// Missing __spirv_ImageWrite, __spirv_SampledImage,
77
// __spirv_ImageSampleExplicitLod on AMD
88
// XFAIL: hip_amd
9-
// Temporarily disable test on Windows due to regressions in GPU driver.
10-
// UNSUPPORTED: windows
119

1210
/*
1311
This file sets up an image, initializes it with data,

SYCL/Sampler/unnormalized-clamp-linear-float.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,10 @@
44
// RUN: %CPU_RUN_PLACEHOLDER %t.out
55
// RUN: %GPU_RUN_PLACEHOLDER %t.out
66
// XFAIL: cuda
7-
// Temporary disabled (#204)
8-
// UNSUPPORTED: level_zero && windows
97

108
// CUDA works with image_channel_type::fp32, but not with any 8-bit per channel
119
// type (such as unorm_int8)
1210

13-
// On Windows, LevelZero returns wrong result for outside right pixel when using
14-
// unorm_int8 data.
15-
1611
/*
1712
This file sets up an image, initializes it with data,
1813
and verifies that the data is sampled correctly with a

SYCL/Sampler/unnormalized-clamp-nearest.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
// Temporarily disable test on Windows due to regressions in GPU driver.
2-
// UNSUPPORTED: hip, windows
1+
// UNSUPPORTED: hip
32
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
43
// RUN: %HOST_RUN_PLACEHOLDER %t.out
54
// RUN: %CPU_RUN_PLACEHOLDER %t.out

SYCL/Sampler/unnormalized-clampedge-linear-float.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
// Temporarily disable test on Windows due to regressions in GPU driver.
2-
// UNSUPPORTED: hip, windows
1+
// UNSUPPORTED: hip
32
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
43
// RUN: %HOST_RUN_PLACEHOLDER %t.out
54
// RUN: %GPU_RUN_PLACEHOLDER %t.out
@@ -9,9 +8,6 @@
98
// CUDA works with image_channel_type::fp32, but not with any 8-bit per channel
109
// type (such as unorm_int8)
1110

12-
// On Windows, LevelZero returns wrong value for clampedge
13-
// out of bounds. Waiting on fix.
14-
1511
/*
1612
This file sets up an image, initializes it with data,
1713
and verifies that the data is sampled correctly with a

SYCL/Sampler/unnormalized-clampedge-nearest.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
1-
// Temporarily disable test on Windows due to regressions in GPU driver.
2-
// UNSUPPORTED: hip, windows
1+
// UNSUPPORTED: hip
32
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
43
// RUN: %HOST_RUN_PLACEHOLDER %t.out
54
// RUN: %CPU_RUN_PLACEHOLDER %t.out
65
// RUN: %GPU_RUN_PLACEHOLDER %t.out
76

8-
// On Windows, LevelZero returns wrong value for clampedge
9-
// out of bounds. Waiting on fix.
10-
117
/*
128
This file sets up an image, initializes it with data,
139
and verifies that the data is sampled correctly with a

0 commit comments

Comments
 (0)