Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Commit 094551c

Browse files
author
Aidan Belton
committed
Update from PR comments
1 parent 1d03da5 commit 094551c

File tree

4 files changed

+7
-11
lines changed

4 files changed

+7
-11
lines changed

SYCL/FilterSelector/select.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ int main() {
206206
std::cout << "Test 'rocm'";
207207
device d19(ONEAPI::filter_selector("rocm"));
208208
assert(d19.get_platform().get_backend() == backend::rocm);
209-
std:: cout << "...PASS" << std::endl;
209+
std::cout << "...PASS" << std::endl;
210210

211211
std::cout << "test 'rocm:gpu'";
212212
device d20(ONEAPI::filter_selector("rocm:gpu"));

SYCL/Plugin/sycl-ls-gpu-rocm.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// REQUIRES: gpu, rocm
1+
// REQUIRES: gpu, rocm, sycl-ls
22

33
// RUN: env SYCL_DEVICE_FILTER=rocm sycl-ls --verbose >%t.rocm.out
44
// RUN: FileCheck %s --check-prefixes=CHECK-BUILTIN-GPU-ROCM,CHECK-CUSTOM-GPU-ROCM --input-file %t.rocm.out
@@ -13,7 +13,3 @@
1313
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
1414
//
1515
//===----------------------------------------------------------------------===//
16-
17-
18-
19-

SYCL/Plugin/sycl-ls-gpu-sycl-be.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// REQUIRES: gpu, cuda, rocm, opencl
1+
// REQUIRES: gpu, cuda, rocm, opencl, sycl-ls
22

33
// RUN: sycl-ls --verbose >%t.default.out
44
// RUN: FileCheck %s --check-prefixes=CHECK-BUILTIN-GPU-OPENCL,CHECK-CUSTOM-GPU-OPENCL --input-file %t.default.out
@@ -18,8 +18,8 @@
1818
// RUN: env SYCL_DEVICE_FILTER=rocm sycl-ls --verbose >%t.rocm.out
1919
// RUN: FileCheck %s --check-prefixes=CHECK-BUILTIN-GPU-ROCM,CHECK-CUSTOM-GPU-ROCM --input-file %t.rocm.out
2020

21-
// CHECK-BUILTIN-GPU-ROCM: gpu_selector(){{.*}}GPU : ROCM
22-
// CHECK-CUSTOM-GPU-ROCM: custom_selector(gpu){{.*}}GPU : ROCM
21+
// CHECK-BUILTIN-GPU-ROCM: gpu_selector(){{.*}}GPU : ROCm
22+
// CHECK-CUSTOM-GPU-ROCM: custom_selector(gpu){{.*}}GPU : ROCm
2323

2424
//==---- sycl-ls-gpu-sycl-be.cpp - SYCL test for discovered/selected devices
2525
//--==//

SYCL/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ from comma-separated list of target devices with colon. Example:
8787
***SYCL_BE*** SYCL backend to be used for testing. Supported values are:
8888
- **opencl** - for OpenCL backend;
8989
- **cuda** - for CUDA backend;
90-
- **ROCm** - for ROCm backend;
90+
- **rocm** - for ROCm backend;
9191
- **level_zero** - Level Zero backend.
9292

9393
***SYCL_TARGET_DEVICES*** comma separated list of target devices for testing.
@@ -111,7 +111,7 @@ Defaults to AMD if no value is given. Supported values are:
111111
- **AMD** - for ROCm to target AMD GPUs
112112
- **NVIDIA** - for ROCm to target NVIDIA GPUs
113113

114-
***MCPU*** Please not, flag must be set for when using ROCm triple.
114+
***MCPU*** Flag must be set for when using ROCm triple.
115115
For example it may be set to "gfx906".
116116

117117

0 commit comments

Comments
 (0)