Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Commit 3f55d85

Browse files
committed
1) add REQUIRES:aspect-fp64 to restrict some 'double' type tests running on Gen12 or late
2) fix typo issue in dgetrf_8x8.cpp 3) split test replicate_smoke.cpp 4) reslve conflict in SYCL/ESIMD/api/bin_and_cmp_ops_heavy.cpp
1 parent 9904e76 commit 3f55d85

13 files changed

+35
-14
lines changed

SYCL/ESIMD/aot_mixed.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
// REQUIRES: gpu
99
// UNSUPPORTED: cuda || hip
1010
// UNSUPPORTED: esimd_emulator
11-
// RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend=spir64_gen "-device gen9" -o %t.sycl.out -DENABLE_SYCL=0 %s
11+
// RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend=spir64_gen "-device *" -o %t.sycl.out -DENABLE_SYCL=0 %s
1212
// RUN: %GPU_RUN_PLACEHOLDER %t.sycl.out
13-
// RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend=spir64_gen "-device gen9" -o %t.out %s
13+
// RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend=spir64_gen "-device *" -o %t.out %s
1414
// RUN: %GPU_RUN_PLACEHOLDER %t.out
1515

1616
// This test checks the following ESIMD ahead-of-time compilation scenarios:

SYCL/ESIMD/api/bin_and_cmp_ops_heavy.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,9 @@ int main(void) {
290290
auto cmp_ops = esimd_test::CmpOps;
291291
passed &= test<unsigned char, int, 1, CmpOp, VSf, IDf>(cmp_ops, q);
292292
passed &= test<char, float, 7, CmpOp, VSf, IDf>(cmp_ops, q);
293+
#ifdef ENABLE_FP64
294+
passed &= test<short, double, 7, BinOp, VEf, IDf>(arith_ops, q, 1e-15);
295+
#endif
293296
passed &= test<float, float, 32, CmpOp, VSf, IDf>(cmp_ops, q);
294297
passed &= test<half, char, 1, CmpOp, VSf, IDf>(cmp_ops, q, 1);
295298
passed &= test<half, unsigned int, 32, CmpOp, VSf, IDf>(cmp_ops, q, 1);

SYCL/ESIMD/api/functional/ctors/ctor_converting_fp_extra.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// REQUIRES: gpu, level_zero
8+
// REQUIRES: gpu, level_zero, aspect-fp64
99
// XREQUIRES: gpu
1010
// TODO gpu and level_zero in REQUIRES due to only this platforms supported yet.
1111
// The current "REQUIRES" should be replaced with "gpu" only as mentioned in

SYCL/ESIMD/api/functional/ctors/ctor_load_acc_fp_extra.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// REQUIRES: gpu, level_zero
8+
// REQUIRES: gpu, level_zero, aspect-fp64
99
// XREQUIRES: gpu
1010
// TODO gpu and level_zero in REQUIRES due to only this platforms supported yet.
1111
// The current "REQUIRES" should be replaced with "gpu" only as mentioned in

SYCL/ESIMD/api/functional/ctors/ctor_load_usm_fp_extra.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// REQUIRES: gpu, level_zero
8+
// REQUIRES: gpu, level_zero, aspect-fp64
99
// XREQUIRES: gpu
1010
// TODO gpu and level_zero in REQUIRES due to only this platforms supported yet.
1111
// The current "REQUIRES" should be replaced with "gpu" only as mentioned in

SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment_accuracy_fp_extra.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
77
//
88
//===----------------------------------------------------------------------===//
9-
// REQUIRES: gpu, level_zero
9+
// REQUIRES: gpu, level_zero, aspect-fp64
1010
// XREQUIRES: gpu
1111
// TODO gpu and level_zero in REQUIRES due to only this platforms supported yet.
1212
// The current "REQUIRES" should be replaced with "gpu" only as mentioned in

SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment_fp_extra.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
77
//
88
//===----------------------------------------------------------------------===//
9-
// REQUIRES: gpu, level_zero
9+
// REQUIRES: gpu, level_zero, aspect-fp64
1010
// XREQUIRES: gpu
1111
// TODO gpu and level_zero in REQUIRES due to only this platforms supported yet.
1212
// The current "REQUIRES" should be replaced with "gpu" only as mentioned in

SYCL/ESIMD/api/replicate_smoke.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,9 @@ int main(int argc, char **argv) {
184184
passed &= test<int>(q);
185185
passed &= test<uint64_t>(q);
186186
passed &= test<float>(q);
187+
#ifdef ENABLE_FP64
187188
passed &= test<double>(q);
189+
#endif
188190

189191
std::cout << (passed ? "Test passed\n" : "Test FAILED\n");
190192
return passed ? 0 : 1;
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
//==------- replicate_smoke.cpp - DPC++ ESIMD on-device test --------------==//
2+
//
3+
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4+
// See https://llvm.org/LICENSE.txt for license information.
5+
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6+
//
7+
//===----------------------------------------------------------------------===//
8+
//
9+
// Enable FP64 part of <replicate_smoke.cpp>. To be removed once DPC++
10+
// supports optional device features and the code could be enabled
11+
// unconditionally without causing failures in speculative compilation
12+
// of the kernels.
13+
//
14+
// REQUIRES: gpu, aspect-fp64
15+
// UNSUPPORTED: cuda || hip
16+
// RUN: %clangxx -fsycl -DENABLE_FP64 %s -o %t.out
17+
// RUN: %GPU_RUN_PLACEHOLDER %t.out
18+
//
19+
#include "replicate_smoke.cpp"

SYCL/ESIMD/regression/dgetrf_8x8.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ ESIMD_INLINE void dgetrfnp_left_step(T *a, int64_t lda, int64_t *info) {
109109
V8(p1, j * M + i) = data;
110110
}
111111
// (getrf) factorize T=P*L*U
112-
dgetrfnp_panel<M, N, K>(info);
112+
dgetrfnp_panel<T, M, N, K>(info);
113113

114114
// store P1
115115
for (j = 0, a1 = a + K * lda; j < N; j++, a1 += lda)
@@ -279,11 +279,6 @@ static int dgetrfnp_batch_strided_check(int64_t m, int64_t n, T *a_in, T *a,
279279
return fail;
280280
}
281281

282-
void dgetrfnp_batch_strided_c(int64_t m, int64_t n, T *a, int64_t lda,
283-
int64_t stride_a, int64_t *ipiv,
284-
int64_t stride_ipiv, int64_t batch,
285-
int64_t *info);
286-
287282
template <typename T> int check(int argc, char *argv[]) {
288283
int exit_status = 0;
289284
constexpr int64_t m = 8, n = 8, lda = 8;

SYCL/ESIMD/spec_const/spec_const_double.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// REQUIRES: gpu
8+
// REQUIRES: gpu, aspect-fp64
99
// RUN: %clangxx -fsycl -I%S/.. %s -o %t.out
1010
// RUN: %GPU_RUN_PLACEHOLDER %t.out
1111
// UNSUPPORTED: cuda || hip

SYCL/SubGroup/broadcast_fp64.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// REQUIRES: aspect-fp64
12
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
23
// RUN: %CPU_RUN_PLACEHOLDER %t.out
34
// RUN: %GPU_RUN_PLACEHOLDER %t.out

SYCL/SubGroup/shuffle_fp64.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// REQUIRES: aspect-fp64
12
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
23
// RUN: %CPU_RUN_PLACEHOLDER %t.out
34
// RUN: %GPU_RUN_PLACEHOLDER %t.out

0 commit comments

Comments
 (0)