Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Commit 43f3f33

Browse files
authored
[SYCL] Fix lit.cfg.py to set SYCL_DEVICE_FILTER correctly. (#190)
We should not use {SYCL_PLUGIN}: prefix for HOST/CPU/ACC_RUN_PLACEHOLDERs. These are incorrect combination of BE:DEV_TYPE, and it will cause device_selectors to return no device because they cannot find any device that can satisfy that invalid combination. Signed-off-by: Byoungro So <[email protected]>
1 parent 86b837d commit 43f3f33

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

SYCL/lit.cfg.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -198,11 +198,11 @@
198198
if 'host' in config.target_devices.split(','):
199199
found_at_least_one_device = True
200200
lit_config.note("Test HOST device")
201-
host_run_substitute = "env SYCL_DEVICE_FILTER={SYCL_PLUGIN}:host ".format(SYCL_PLUGIN=config.sycl_be)
201+
host_run_substitute = "env SYCL_DEVICE_FILTER=host "
202202
host_check_substitute = "| FileCheck %s"
203203
config.available_features.add('host')
204204
if platform.system() == "Linux":
205-
host_run_on_linux_substitute = "env SYCL_DEVICE_FILTER={SYCL_PLUGIN}:host ".format(SYCL_PLUGIN=config.sycl_be)
205+
host_run_on_linux_substitute = "env SYCL_DEVICE_FILTER=host "
206206
host_check_on_linux_substitute = "| FileCheck %s"
207207
else:
208208
lit_config.warning("HOST device not used")
@@ -220,11 +220,11 @@
220220
if 'cpu' in config.target_devices.split(','):
221221
found_at_least_one_device = True
222222
lit_config.note("Test CPU device")
223-
cpu_run_substitute = "env SYCL_DEVICE_FILTER={SYCL_PLUGIN}:cpu ".format(SYCL_PLUGIN=config.sycl_be)
223+
cpu_run_substitute = "env SYCL_DEVICE_FILTER=cpu,host "
224224
cpu_check_substitute = "| FileCheck %s"
225225
config.available_features.add('cpu')
226226
if platform.system() == "Linux":
227-
cpu_run_on_linux_substitute = "env SYCL_DEVICE_FILTER={SYCL_PLUGIN}:cpu ".format(SYCL_PLUGIN=config.sycl_be)
227+
cpu_run_on_linux_substitute = "env SYCL_DEVICE_FILTER=cpu,host "
228228
cpu_check_on_linux_substitute = "| FileCheck %s"
229229
else:
230230
lit_config.warning("CPU device not used")
@@ -244,15 +244,15 @@
244244
if 'gpu' in config.target_devices.split(','):
245245
found_at_least_one_device = True
246246
lit_config.note("Test GPU device")
247-
gpu_run_substitute = " env SYCL_DEVICE_FILTER={SYCL_PLUGIN}:gpu ".format(SYCL_PLUGIN=config.sycl_be)
247+
gpu_run_substitute = " env SYCL_DEVICE_FILTER={SYCL_PLUGIN}:gpu,host ".format(SYCL_PLUGIN=config.sycl_be)
248248
gpu_check_substitute = "| FileCheck %s"
249249
config.available_features.add('gpu')
250250

251251
if config.sycl_be == "level_zero":
252252
gpu_l0_check_substitute = "| FileCheck %s"
253253

254254
if platform.system() == "Linux":
255-
gpu_run_on_linux_substitute = "env SYCL_DEVICE_FILTER={SYCL_PLUGIN}:gpu ".format(SYCL_PLUGIN=config.sycl_be)
255+
gpu_run_on_linux_substitute = "env SYCL_DEVICE_FILTER={SYCL_PLUGIN}:gpu,host ".format(SYCL_PLUGIN=config.sycl_be)
256256
gpu_check_on_linux_substitute = "| FileCheck %s"
257257

258258
else:
@@ -269,7 +269,7 @@
269269
if 'acc' in config.target_devices.split(','):
270270
found_at_least_one_device = True
271271
lit_config.note("Tests accelerator device")
272-
acc_run_substitute = " env SYCL_DEVICE_FILTER={SYCL_PLUGIN}:acc ".format(SYCL_PLUGIN=config.sycl_be)
272+
acc_run_substitute = " env SYCL_DEVICE_FILTER=acc "
273273
acc_check_substitute = "| FileCheck %s"
274274
config.available_features.add('accelerator')
275275
else:

0 commit comments

Comments
 (0)