Apply code review comments

Author: AlexeySachkov

SYCL/GroupAlgorithm/SYCL2020/sort.cpp

@@ -349,9 +349,6 @@ int main(int argc, char *argv[]) {
     return 0;
   }
 
-  bool doubleIsSupported = q.get_device().has(sycl::aspect::fp64);
-  bool halfIsSupported = q.get_device().has(sycl::aspect::fp16);
-
   std::vector<int> sizes{1, 12, 32};
 
   for (int i = 0; i < sizes.size(); ++i) {
@@ -360,9 +357,9 @@ int main(int argc, char *argv[]) {
     test_sort_by_type<std::int32_t>(q, sizes[i]);
     test_sort_by_type<std::uint32_t>(q, sizes[i]);
     test_sort_by_type<float>(q, sizes[i]);
-    if (halfIsSupported)
+    if (q.get_device().has(sycl::aspect::fp16))
       test_sort_by_type<sycl::half>(q, sizes[i]);
-    if (doubleIsSupported)
+    if (q.get_device().has(sycl::aspect::fp64))
       test_sort_by_type<double>(q, sizes[i]);
     test_sort_by_type<std::size_t>(q, sizes[i]);
 

SYCL/KernelParams/union_kernel_param.cpp

@@ -12,27 +12,27 @@ union TestUnion {
 public:
   int myint;
   char mychar;
-  float myfloat;
+  double mydouble;
 
-  TestUnion() { myfloat = 0.0; };
+  TestUnion() { mydouble = 0.0; };
 };
 
 int main(int argc, char **argv) {
   TestUnion x;
-  x.myfloat = 5.0;
-  float myfloat = 0.0;
+  x.mydouble = 5.0;
+  double mydouble = 0.0;
 
   sycl::queue queue;
   {
-    sycl::buffer<float, 1> buf(&myfloat, 1);
+    sycl::buffer<double, 1> buf(&mydouble, 1);
     queue.submit([&](sycl::handler &cgh) {
       auto acc = buf.get_access<sycl::access::mode::read_write>(cgh);
-      cgh.single_task<class test>([=]() { acc[0] = x.myfloat; });
+      cgh.single_task<class test>([=]() { acc[0] = x.mydouble; });
     });
   }
 
-  if (myfloat != 5.0) {
-    printf("FAILED\nmyfloat = %d\n", myfloat);
+  if (mydouble != 5.0) {
+    printf("FAILED\nmydouble = %d\n", mydouble);
     return 1;
   }
   return 0;