Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Commit aef8a59

Browse files
committed
[SYCL] Removed XFAIL for AMD from group collectives related tests
1 parent 382b5eb commit aef8a59

26 files changed

+7
-86
lines changed

SYCL/GroupAlgorithm/SYCL2020/all_of.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5-
//
6-
// Missing __spirv_GroupAll on AMD:
7-
// XFAIL: hip_amd
85

96
#include "support.h"
107
#include <CL/sycl.hpp>

SYCL/GroupAlgorithm/SYCL2020/any_of.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5-
//
6-
// Missing __spirv_GroupAny on AMD:
7-
// XFAIL: hip_amd
85

96
#include "support.h"
107
#include <CL/sycl.hpp>

SYCL/GroupAlgorithm/SYCL2020/exclusive_scan.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5-
//
6-
// Missing __spirv_GroupIAdd, __spirv_GroupBroadcast, __spirv_GroupSMin and
7-
// __spirv_GroupSMax on AMD:
8-
// XFAIL: hip_amd
95

106
// TODO: enable compile+runtime checks for operations defined in SPIR-V 1.3.
117
// That requires either adding a switch to clang (-spirv-max-version=1.3) or

SYCL/GroupAlgorithm/SYCL2020/group_broadcast.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5-
//
6-
// Missing __spirv_GroupBroadcast on AMD:
7-
// XFAIL: hip_amd
85

96
#include "support.h"
107
#include <CL/sycl.hpp>

SYCL/GroupAlgorithm/SYCL2020/inclusive_scan.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5-
//
6-
// Missing __spirv_GroupIAdd, __spirv_GroupBroadcast, __spirv_GroupSMin and
7-
// __spirv_GroupSMax on AMD:
8-
// XFAIL: hip_amd
95

106
// TODO: enable compile+runtime checks for operations defined in SPIR-V 1.3.
117
// That requires either adding a switch to clang (-spirv-max-version=1.3) or

SYCL/GroupAlgorithm/SYCL2020/none_of.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5-
//
6-
// Missing __spirv_GroupAll and __spirv_GroupAny on AMD:
7-
// XFAIL: hip_amd
85

96
#include "support.h"
107
#include <CL/sycl.hpp>

SYCL/GroupAlgorithm/SYCL2020/reduce.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5-
//
6-
// Missinsg __spirv_GroupIAdd, __spirv_GroupSMin and __spirv_GroupSMax on AMD:
7-
// XFAIL: hip_amd
85

96
// TODO: enable compile+runtime checks for operations defined in SPIR-V 1.3.
107
// That requires either adding a switch to clang (-spirv-max-version=1.3) or

SYCL/GroupAlgorithm/all_of.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
6-
//
7-
// Missing __spirv_GroupAll on AMD
8-
// XFAIL: hip_amd
96

107
#include "support.h"
118
#include <CL/sycl.hpp>

SYCL/GroupAlgorithm/any_of.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
6-
//
7-
// Missing __spirv_GroupAny on AMD
8-
// XFAIL: hip_amd
96

107
#include "support.h"
118
#include <CL/sycl.hpp>

SYCL/GroupAlgorithm/back_to_back_collectives.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
6-
//
7-
// Missing __spirv_GroupIAdd on AMD:
8-
// XFAIL: hip_amd
96

107
#include <CL/sycl.hpp>
118
#include <numeric>

SYCL/GroupAlgorithm/broadcast.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
6-
//
7-
// Missing __spirv_GroupBroadcast on AMD
8-
// XFAIL: hip_amd
96

107
#include "support.h"
118
#include <CL/sycl.hpp>

SYCL/GroupAlgorithm/exclusive_scan.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
6-
//
7-
// Missing __spirv_GroupIAdd, __spirv_GroupBroadcast, __spirv_GroupSMin,
8-
// __spirv_GroupSMax on AMD
9-
// XFAIL: hip_amd
106

117
// TODO: enable compile+runtime checks for operations defined in SPIR-V 1.3.
128
// That requires either adding a switch to clang (-spirv-max-version=1.3) or

SYCL/GroupAlgorithm/inclusive_scan.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
6-
//
7-
// Missing __spirv_GroupIAdd, __spirv_GroupBroadcast, __spirv_GroupSMin,
8-
// __spirv_GroupSMax on AMD
9-
// XFAIL: hip_amd
106

117
// TODO: enable compile+runtime checks for operations defined in SPIR-V 1.3.
128
// That requires either adding a switch to clang (-spirv-max-version=1.3) or

SYCL/GroupAlgorithm/none_of.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
6-
//
7-
// Missing __spirv_GroupAll, __spirv_GroupAny on AMD
8-
// XFAIL: hip_amd
96

107
#include "support.h"
118
#include <CL/sycl.hpp>

SYCL/GroupAlgorithm/reduce.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
6-
//
7-
// Missing __spirv_GroupIAdd, __spirv_GroupSMin, __spirv_GroupSMax on AMD
8-
// XFAIL: hip_amd
96

107
// TODO: enable compile+runtime checks for operations defined in SPIR-V 1.3.
118
// That requires either adding a switch to clang (-spirv-max-version=1.3) or

SYCL/Reduction/reduction_nd_conditional.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
66
//
7-
// Missing __spirv_GroupIAdd on AMD, error message `The implementation handling
7+
// Error message `The implementation handling
88
// parallel_for with reduction requires work group size not bigger than 1` on
99
// Nvidia.
10-
// XFAIL: hip_amd || hip_nvidia
10+
// XFAIL: hip_nvidia
1111

1212
// This test performs basic checks of parallel_for(nd_range, reduction, func)
1313
// with reduction and conditional increment of the reduction variable.

SYCL/Reduction/reduction_nd_ext_double.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
55
//
6-
// Missing __spirv_GroupFAdd, __spirv_GroupFMin, __spirv_GroupFMax on AMD, error
6+
// Error
77
// message `The implementation handling parallel_for with reduction requires
88
// work group size not bigger than 1` on Nvidia.
9-
// XFAIL: hip_amd || hip_nvidia
9+
// XFAIL: hip_nvidia
1010

1111
// TODO: Enable the test for HOST when it supports intel::reduce() and barrier()
1212
// RUNx: %HOST_RUN_PLACEHOLDER %t.out

SYCL/Reduction/reduction_range_usm_dw.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
55
//
6-
// Missing __spirv_GroupFAdd on AMD, error message `Group algorithms are not
6+
// Error message `Group algorithms are not
77
// supported on host device.` on Nvidia.
8-
// XFAIL: hip_amd || hip_nvidia
8+
// XFAIL: hip_nvidia
99

1010
// TODO: test disabled due to sporadic fails in level_zero:gpu RT.
1111
// UNSUPPORTED: linux && level_zero

SYCL/SubGroup/broadcast.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
6-
//
7-
// Missing __spirv_GroupBroadcast on AMD
8-
// XFAIL: hip_amd
96

107
//==--------- broadcast.cpp - SYCL sub_group broadcast test ----*- C++ -*---==//
118
//

SYCL/SubGroup/broadcast_fp16.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
22
// RUN: %GPU_RUN_PLACEHOLDER %t.out
3-
//
4-
// Missing __spirv_GroupBroadcast on AMD
5-
// XFAIL: hip_amd
63

74
//==---- broadcast_fp16.cpp - SYCL sub_group broadcast test ----*- C++ -*---==//
85
//

SYCL/SubGroup/broadcast_fp64.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
6-
//
7-
// Missing __spirv_GroupBroadcast on AMD
8-
// XFAIL: hip_amd
96

107
//==----- broadcast_fp64.cpp - SYCL sub_group broadcast test ----*- C++ -*--==//
118
//

SYCL/SubGroup/reduce.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,7 @@
77
// RUN: %CPU_RUN_PLACEHOLDER %t.out
88
// RUN: %GPU_RUN_PLACEHOLDER %t.out
99
// RUN: %ACC_RUN_PLACEHOLDER %t.out
10-
//
11-
// Missing __spirv_GroupIAdd, __spirv_GroupSMin, __spirv_GroupSMax,
12-
// __spirv_GroupUMin, __spirv_GroupUMax, __spirv_GroupFAdd, __spirv_GroupFMin,
13-
// __spirv_GroupFMax on AMD
14-
// XFAIL: hip_amd
15-
//
10+
1611
//==--------------- reduce.cpp - SYCL sub_group reduce test ----*- C++ -*---==//
1712
//
1813
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.

SYCL/SubGroup/reduce_fp64.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@
77
// RUN: %CPU_RUN_PLACEHOLDER %t.out
88
// RUN: %GPU_RUN_PLACEHOLDER %t.out
99
// RUN: %ACC_RUN_PLACEHOLDER %t.out
10-
//
11-
// Missing __spirv_GroupFAdd, __spirv_GroupFMin, __spirv_GroupFMax on AMD
12-
// XFAIL: hip_amd
1310

1411
// This test verifies the correct work of the sub-group algorithm reduce().
1512

SYCL/SubGroup/scan.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@
77
// RUN: %CPU_RUN_PLACEHOLDER %t.out
88
// RUN: %GPU_RUN_PLACEHOLDER %t.out
99
// RUN: %ACC_RUN_PLACEHOLDER %t.out
10-
//
11-
// Missing __spirv_SubgroupLocalInvocationId, __spirv_GroupIAdd,
12-
// __spirv_GroupSMin, __spirv_GroupSMax, __spirv_GroupUMin, __spirv_groupUMax,
13-
// __spirv_GroupFAdd, __spirv_GroupFMin, __spirv_GroupFMax on AMD
14-
// XFAIL: hip_amd
1510

1611
//==--------------- scan.cpp - SYCL sub_group scan test --------*- C++ -*---==//
1712
//

SYCL/SubGroup/scan_fp64.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@
77
// RUN: %CPU_RUN_PLACEHOLDER %t.out
88
// RUN: %GPU_RUN_PLACEHOLDER %t.out
99
// RUN: %ACC_RUN_PLACEHOLDER %t.out
10-
//
11-
// Missing __spirv_SubgroupLocalInvocationId, __spirv_GroupFAdd,
12-
// __spirv_GroupFMin, __spirv_GroupFMax on AMD
13-
// XFAIL: hip_amd
1410

1511
// This test verifies the correct work of the sub-group algorithms
1612
// exclusive_scan() and inclusive_scan().

SYCL/SubGroup/vote.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out
44
// RUN: %GPU_RUN_PLACEHOLDER %t.out
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out
6-
//
7-
// Missing __spirv_SubgroupLocalInvocationId, __spirv_GroupAny, __spirv_GroupAll
8-
// on AMD
9-
// XFAIL: hip_amd
106

117
//==--------------- vote.cpp - SYCL sub_group vote test --*- C++ -*---------==//
128
//

0 commit comments

Comments
 (0)