Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Commit cfbe08a

Browse files
committed
reviewer feedback
1 parent 74203fd commit cfbe08a

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

SYCL/Basic/partition_supported.cpp

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,7 @@
99
1) if partition_equally is supported, then we check that the correct
1010
invalid errc is returned if more than max_compute_units are requested
1111
12-
2) [info::device::partition_properties]: returns the partition properties
13-
supported by this SYCL device; a vector of info::partition_property. If this
14-
SYCL device cannot be partitioned into at least two sub devices then the
15-
returned vector **must be empty**.
16-
17-
3) [create_sub_devices()]: If the SYCL device
18-
does not support info::partition_property::partition_by_affinity_domain or the
12+
2) If the SYCL device does not support info::partition_property::partition_by_affinity_domain or the
1913
SYCL device does not support the info::partition_affinity_domain provided, an
2014
exception with the **feature_not_supported error code must be thrown**.
2115
*/
@@ -60,7 +54,7 @@ int main() {
6054

6155
auto dev = cl::sycl::device(cl::sycl::default_selector());
6256

63-
// check exceed max_compute_units
57+
// 1 - check exceed max_compute_units
6458
cl::sycl::info::partition_property partitionEqually =
6559
cl::sycl::info::partition_property::partition_equally;
6660
if (supports_partition_property(dev, partitionEqually)) {
@@ -84,11 +78,11 @@ int main() {
8478
}
8579
}
8680

81+
// 2 - check affinity
8782
cl::sycl::info::partition_property partitionProperty =
8883
cl::sycl::info::partition_property::partition_by_affinity_domain;
8984
cl::sycl::info::partition_affinity_domain affinityDomain =
9085
cl::sycl::info::partition_affinity_domain::next_partitionable;
91-
9286
if (supports_partition_property(dev, partitionProperty)) {
9387
if (supports_affinity_domain(dev, partitionProperty, affinityDomain)) {
9488
auto subDevices = dev.create_sub_devices<

0 commit comments

Comments
 (0)