Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Commit d4eb232

Browse files
authored
Revert "Add tests for bfloat16 isnan" (#1532)
Revert "Add tests for bfloat16 isnan (#1509)" This reverts commit b1ef695.
1 parent 4df8936 commit d4eb232

File tree

1 file changed

+9
-15
lines changed

1 file changed

+9
-15
lines changed

SYCL/BFloat16/bfloat16_builtins.cpp

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ bool check(float a, float b) {
2929
return fabs(2 * (a - b) / (a + b)) > bf16_eps * 2;
3030
}
3131

32-
bool check(bool a, bool b) { return (a == b); }
33-
3432
#define TEST_BUILTIN_1_SCAL_IMPL(NAME) \
3533
{ \
3634
buffer<float> a_buf(&a[0], N); \
@@ -48,7 +46,7 @@ bool check(bool a, bool b) { return (a == b); }
4846
} \
4947
assert(err == 0);
5048

51-
#define TEST_BUILTIN_1_ARR_IMPL(NAME, SZ, RETTY) \
49+
#define TEST_BUILTIN_1_ARR_IMPL(NAME, SZ) \
5250
{ \
5351
buffer<float, 2> a_buf{range<2>{N / SZ, SZ}}; \
5452
buffer<int> err_buf(&err, 1); \
@@ -61,7 +59,7 @@ bool check(bool a, bool b) { return (a == b); }
6159
for (int i = 0; i < SZ; i++) { \
6260
arg[i] = A[index][i]; \
6361
} \
64-
marray<RETTY, SZ> res = NAME(arg); \
62+
marray<bfloat16, SZ> res = NAME(arg); \
6563
for (int i = 0; i < SZ; i++) { \
6664
if (check(res[i], NAME(A[index][i]))) { \
6765
ERR[0] = 1; \
@@ -72,13 +70,13 @@ bool check(bool a, bool b) { return (a == b); }
7270
} \
7371
assert(err == 0);
7472

75-
#define TEST_BUILTIN_1(NAME, RETTY) \
73+
#define TEST_BUILTIN_1(NAME) \
7674
TEST_BUILTIN_1_SCAL_IMPL(NAME) \
77-
TEST_BUILTIN_1_ARR_IMPL(NAME, 1, RETTY) \
78-
TEST_BUILTIN_1_ARR_IMPL(NAME, 2, RETTY) \
79-
TEST_BUILTIN_1_ARR_IMPL(NAME, 3, RETTY) \
80-
TEST_BUILTIN_1_ARR_IMPL(NAME, 4, RETTY) \
81-
TEST_BUILTIN_1_ARR_IMPL(NAME, 5, RETTY)
75+
TEST_BUILTIN_1_ARR_IMPL(NAME, 1) \
76+
TEST_BUILTIN_1_ARR_IMPL(NAME, 2) \
77+
TEST_BUILTIN_1_ARR_IMPL(NAME, 3) \
78+
TEST_BUILTIN_1_ARR_IMPL(NAME, 4) \
79+
TEST_BUILTIN_1_ARR_IMPL(NAME, 5)
8280

8381
#define TEST_BUILTIN_2_SCAL_IMPL(NAME) \
8482
{ \
@@ -235,18 +233,14 @@ int main() {
235233
c[i] = (float)(3 * i);
236234
}
237235

238-
TEST_BUILTIN_1(fabs, bfloat16);
236+
TEST_BUILTIN_1(fabs);
239237
TEST_BUILTIN_2(fmin);
240238
TEST_BUILTIN_2(fmax);
241239
TEST_BUILTIN_3(fma);
242240

243241
float check_nan = 0;
244242
TEST_BUILTIN_2_NAN(fmin);
245243
TEST_BUILTIN_2_NAN(fmax);
246-
247-
// Insert NAN value in a to test isnan
248-
a[0] = a[N - 1] = NAN;
249-
TEST_BUILTIN_1(isnan, bool);
250244
}
251245
return 0;
252246
}

0 commit comments

Comments
 (0)