This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][CUDA] CXX std lib funcs for CUDA backend #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Sep 2, 2022
This PR allows CXX stdlib funcs to be used for NVPTX backend. See #6379 llvm-test-suite test: intel/llvm-test-suite#1112 It also adds the compiler flag `"-fbundle-no-offload-arch"`, which allows device code bundles to omit arch information, meaning a bundle with the tag `sycl-nvptx64-nvidia-cuda-sm_50` can be bundled with the tag `sycl-nvptx64-nvidia-cuda` when the flag is enabled. This allows for generic bc bundles for a given backend. I have not moved the NVPTX complex implementation to libdevice. Let me know if I should do so. The behaviour of `IsMathErrnoDefault()` now changes so that `-fmath-errno` is enabled by default for the CUDA toolchain. This allows libdevice funcs to be used by a similar exploit that the SYCL toolchain uses. If necessary this could be reset once the upstream discussion on NVPTX codegen for `llvm.sin` and other llvm builtins has been resolved and implemented. See https://discourse.llvm.org/t/nvptx-codegen-for-llvm-sin-and-friends/58170/11?u=jdoerfert
|
@hdelan - Could you please add a merge commit to rerun testing? |
|
Yep done |
|
Windows failures are known and are unrelated. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating to PR intel/llvm#6482