This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix events caching test #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like some resources can be released asynchronously in the scheduler. That's why at some runs 1 event is enough but sometimes 2 events are needed. So use regular expression to allow up to 9 events just in case.
| @@ -7,7 +7,7 @@ | |||
| // RUN: env SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=0 ZE_DEBUG=4 %GPU_RUN_PLACEHOLDER %t.out 2>&1 | FileCheck --check-prefixes=CACHING-ENABLED %s | |||
| // RUN: env SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=0 SYCL_PI_LEVEL_ZERO_DISABLE_EVENTS_CACHING=1 ZE_DEBUG=4 %GPU_RUN_PLACEHOLDER %t.out 2>&1 | FileCheck --check-prefixes=CACHING-DISABLED %s | |||
|
|
|||
| // CACHING-ENABLED: zeEventCreate = 1 | |||
| // CACHING-ENABLED: zeEventCreate = {{[1-9]}} | |||
There was a problem hiding this comment.
Suggested change
| // CACHING-ENABLED: zeEventCreate = {{[1-9]}} | |
| // With events caching we should be reusing them and 9 should be enough. | |
| // Might require more than one if previous one has already been released | |
| // by the time we need a new one. | |
| // CACHING-ENABLED: zeEventCreate = {{[1-9]}} |
There was a problem hiding this comment.
Argh, I confused released/destroyed. Your update looks fine.
aelovikov-intel
approved these changes
Sep 9, 2022
| @@ -7,7 +7,7 @@ | |||
| // RUN: env SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=0 ZE_DEBUG=4 %GPU_RUN_PLACEHOLDER %t.out 2>&1 | FileCheck --check-prefixes=CACHING-ENABLED %s | |||
| // RUN: env SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=0 SYCL_PI_LEVEL_ZERO_DISABLE_EVENTS_CACHING=1 ZE_DEBUG=4 %GPU_RUN_PLACEHOLDER %t.out 2>&1 | FileCheck --check-prefixes=CACHING-DISABLED %s | |||
|
|
|||
| // CACHING-ENABLED: zeEventCreate = 1 | |||
| // CACHING-ENABLED: zeEventCreate = {{[1-9]}} | |||
There was a problem hiding this comment.
Argh, I confused released/destroyed. Your update looks fine.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
It looks like some resources can be released asynchronously in the scheduler. That's why at some runs 1 event is enough but sometimes 2 events are needed. So use regular expression to allow up to 9 events just in case.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
[SYCL] Fix events caching test (intel#1138)
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
It looks like some resources can be released asynchronously in the scheduler. That's why at some runs 1 event is enough but sometimes 2 events are needed. So use regular expression to allow up to 9 events just in case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like some resources can be released asynchronously in the
scheduler. That's why at some runs 1 event is enough but sometimes 2
events are needed. So use regular expression to allow up to 9 events
just in case.