This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[ESIMD] Add test for radix sort. #1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbobrovs
reviewed
Sep 20, 2022
SYCL/ESIMD/radix_sort.cpp
Outdated
| return; | ||
| } | ||
|
|
||
| // std::cout << "*** n_entries: " << n_entries << " elem_stide: " << |
There was a problem hiding this comment.
The commented lines were added for debugging purpose - removed.
kbobrovs
previously approved these changes
Sep 20, 2022
kbobrovs
approved these changes
Sep 20, 2022
|
@kychendev , please provide info on failing tests so that this PR could be merged if failures are unrelated. |
|
This change only contains a new radix_sort kernel, which has passed CI test. The following new failed cases should be irrelevant to this PR: [2022-09-20T01:59:16.620Z] New failures found: ['SYCL::Config/kernel_from_file.cpp', 'SYCL::DeviceLib/separate_compile_test.cpp', 'SYCL::SeparateCompile/test.cpp'] |
|
@kbobrovs , could you help merge as the failing tests are unrelated. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
* [ESIMD] Add test for radix sort.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
* [ESIMD] Add test for radix sort.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.